Tried, failed. I give up

It looks like this whole branch is fucking useless, considering that I'll
need to reimplement that massive switch statement again just to determine
which overwritten method to use. I might as well not have bothered.

README.md

@@ -1,17 +1,14 @@
-## Outline
-
-Tortuga is a 2D multiplayer JRPG featuring permadeath, with an emphasis on multiplayer cooperation, exploration and customization. The game runs on customizable public and private servers.
-
-This game is inspired by classic 2D RPGs (Final Fantasy, The Legend of Zelda), as well as more modern sandboxes amd MMOs (Minecraft, EVE Online). This project is currently independently created and funded, with the goal of creating a game that will engage the players and inspire a large community.
-
-## Releases
-
 The most recent stable build for Windows can be found [here](https://dl.dropboxusercontent.com/u/46669050/Tortuga.rar).
 
+Tortuga is a 2D multiplayer JRPG featuring permadeath (deletion of a character upon death). The emphasis of this game is on multiplayer cooperation, exploration and customization. The game runs on customizable server software that can support up to 150 simultaneous players or more.
+
+This game is inspired by classic 2D RPGs, as well as more modern sandbox MMOs. This project is currently independently created and funded, with the goal of creating a game that will engage user's imagination and inspire a large modding community.
+
 ## Documentation
 
-* [Tortuga Wiki](https://github.com/Ratstail91/Tortuga/wiki) - Full documentation
+Tortuga's full documentation can be found in a separate branch, see [Tortuga/docs](https://github.com/Ratstail91/Tortuga/tree/docs).  
-* [Tortuga Bug Tracker](https://github.com/Ratstail91/Tortuga/issues) - A list of all known bugs and issues
+For Tortuga's primary documentation, please read the [Tortuga Game Design Document](https://github.com/Ratstail91/Tortuga/blob/docs/Tortuga%20Game%20Design%20Document.docx?raw=true).  
+For a list of known bugs, see the [GitHub bug tracker](https://github.com/Ratstail91/Tortuga/issues).
 
 ## External Dependencies
 

client/character.cpp

@@ -19,9 +19,23 @@
  * 3. This notice may not be removed or altered from any source
  * distribution.
 */
-#include "base_character.hpp"
+#include "character.hpp"
 
-void BaseCharacter::CorrectSprite() {
+void Character::Update() {
+	if (motion.x && motion.y) {
+		origin += motion * CHARACTER_WALKING_MOD;
+	}
+	else if (motion != 0) {
+		origin += motion;
+	}
+	sprite.Update(0.016);
+}
+
+void Character::DrawTo(SDL_Surface* const dest, int camX, int camY) {
+	sprite.DrawTo(dest, origin.x - camX, origin.y - camY);
+}
+
+void Character::CorrectSprite() {
 	//NOTE: These must correspond to the sprite sheet in use
 	if (motion.y > 0) {
 		sprite.SetYIndex(0);

client/character.hpp

@@ -19,23 +19,38 @@
  * 3. This notice may not be removed or altered from any source
  * distribution.
 */
-#ifndef BASECHARACTER_HPP_
+#ifndef CHARACTER_HPP_
-#define BASECHARACTER_HPP_
+#define CHARACTER_HPP_
 
 //components
 #include "character_defines.hpp"
-#include "renderable.hpp"
+#include "vector2.hpp"
+#include "bounding_box.hpp"
+#include "statistics.hpp"
+
+//graphics
+#include "sprite_sheet.hpp"
 
 //std namespace
 #include <string>
+#include <cmath>
 
-class BaseCharacter : public Renderable {
+class Character {
 public:
-	BaseCharacter() = default;
+	Character() = default;
-	virtual ~BaseCharacter() = default;
+	~Character() = default;
+
+	void Update();
 
 	//graphics
+	void DrawTo(SDL_Surface* const, int camX, int camY);
 	void CorrectSprite();
+	SpriteSheet* GetSprite() { return &sprite; }
+
+	//gameplay
+	Statistics* GetStats() { return &stats; }
+
+	//accessors and mutators
 
 	//metadata
 	int SetOwner(int i) { return owner = i; }
@@ -45,11 +60,36 @@ public:
 	std::string SetAvatar(std::string s) { return avatar = s; }
 	std::string GetAvatar() const { return avatar; }
 
+	//position
+	Vector2 SetOrigin(Vector2 v) { return origin = v; }
+	Vector2 GetOrigin() const { return origin; }
+	Vector2 SetMotion(Vector2 v) { return motion = v; }
+	Vector2 GetMotion() const { return motion; }
+	BoundingBox SetBounds(BoundingBox b) { return bounds = b; }
+	BoundingBox GetBounds() { return bounds; }
+
 private:
+	//graphics
+	SpriteSheet sprite;
+
+	//base statistics
+	Statistics stats;
+
+	//TODO: gameplay components: equipment, items, buffs, debuffs
+
 	//metadata
 	int owner;
 	std::string handle;
 	std::string avatar;
+
+	//position
+	Vector2 origin = {0.0,0.0};
+	Vector2 motion = {0.0,0.0};
+	BoundingBox bounds;
 };
 
+//tmp
+#include <map>
+typedef std::map<int, Character> CharacterMap;
+
 #endif

client/client_application.cpp

@@ -21,7 +21,6 @@
 */
 #include "client_application.hpp"
 
-#include "serial_packet.hpp"
 #include "config_utility.hpp"
 
 #include <stdexcept>
@@ -38,18 +37,19 @@
 #include "options_menu.hpp"
 #include "lobby_menu.hpp"
 #include "in_world.hpp"
-#include "disconnected_screen.hpp"
+//#include "in_combat.hpp"
+#include "clean_up.hpp"
 
 //-------------------------
 //Public access members
 //-------------------------
 
-void ClientApplication::Init(int argc, char* argv[]) {
+void ClientApplication::Init(int argc, char** argv) {
 	std::cout << "Beginning " << argv[0] << std::endl;
 
 	//load the prerequisites
 	ConfigUtility& config = ConfigUtility::GetSingleton();
-	config.Load("rsc\\config.cfg", argc, argv);
+	config.Load("rsc\\config.cfg");
 
 	//-------------------------
 	//Initialize the APIs
@@ -88,7 +88,6 @@ void ClientApplication::Init(int argc, char* argv[]) {
 
 	std::cout << "Internal sizes:" << std::endl;
 
-	DEBUG_OUTPUT_VAR(NETWORK_VERSION);
 	DEBUG_OUTPUT_VAR(sizeof(Region::type_t));
 	DEBUG_OUTPUT_VAR(sizeof(Region));
 	DEBUG_OUTPUT_VAR(REGION_WIDTH);
@@ -96,10 +95,8 @@ void ClientApplication::Init(int argc, char* argv[]) {
 	DEBUG_OUTPUT_VAR(REGION_DEPTH);
 	DEBUG_OUTPUT_VAR(REGION_TILE_FOOTPRINT);
 	DEBUG_OUTPUT_VAR(REGION_SOLID_FOOTPRINT);
-	DEBUG_OUTPUT_VAR(PACKET_STRING_SIZE);
 	DEBUG_OUTPUT_VAR(PACKET_BUFFER_SIZE);
 	DEBUG_OUTPUT_VAR(MAX_PACKET_SIZE);
-	DEBUG_OUTPUT_VAR(static_cast<int>(SerialPacketType::LAST));
 
 #undef DEBUG_OUTPUT_VAR
 
@@ -178,13 +175,16 @@ void ClientApplication::LoadScene(SceneList sceneIndex) {
 			activeScene = new OptionsMenu();
 		break;
 		case SceneList::LOBBYMENU:
-			activeScene = new LobbyMenu(&clientIndex, &accountIndex); //TODO: can I use the ConfigUtility for these parameters?
+			activeScene = new LobbyMenu(&clientIndex, &accountIndex);
 		break;
 		case SceneList::INWORLD:
-			activeScene = new InWorld(&clientIndex, &accountIndex);
+			activeScene = new InWorld(&clientIndex, &accountIndex, &characterIndex, &characterMap);
 		break;
-		case SceneList::DISCONNECTEDSCREEN:
+//		case SceneList::INCOMBAT:
-			activeScene = new DisconnectedScreen();
+//			activeScene = new InCombat(&clientIndex, &accountIndex, &characterIndex, &characterMap);
+//		break;
+		case SceneList::CLEANUP:
+			activeScene = new CleanUp(&clientIndex, &accountIndex, &characterIndex, &characterMap);
 		break;
 		default:
 			throw(std::logic_error("Failed to recognize the scene index"));

client/client_application.hpp

@@ -26,6 +26,7 @@
 #include "base_scene.hpp"
 
 #include "udp_network_utility.hpp"
+#include "character.hpp"
 
 #include "singleton.hpp"
 
@@ -34,7 +35,7 @@
 class ClientApplication: public Singleton<ClientApplication> {
 public:
 	//public methods
-	void Init(int argc, char* argv[]);
+	void Init(int argc, char** argv);
 	void Proc();
 	void Quit();
 
@@ -53,6 +54,9 @@ private:
 	//shared parameters
 	int clientIndex = -1;
 	int accountIndex = -1;
+	int characterIndex = -1;
+
+	CharacterMap characterMap;
 };
 
 #endif

client/client_utilities/makefile

@@ -1,37 +0,0 @@
-#config
-INCLUDES+=.
-LIBS+=
-CXXFLAGS+=-std=c++11 $(addprefix -I,$(INCLUDES))
-
-#source
-CXXSRC=$(wildcard *.cpp)
-
-#objects
-OBJDIR=obj
-OBJ+=$(addprefix $(OBJDIR)/,$(CXXSRC:.cpp=.o))
-
-#output
-OUTDIR=..
-OUT=$(addprefix $(OUTDIR)/,client.a)
-
-#targets
-all: $(OBJ) $(OUT)
-	ar -crs $(OUT) $(OBJ)
-
-$(OBJ): | $(OBJDIR)
-
-$(OUT): | $(OUTDIR)
-
-$(OBJDIR):
-	mkdir $(OBJDIR)
-
-$(OUTDIR):
-	mkdir $(OUTDIR)
-
-$(OBJDIR)/%.o: %.cpp
-	$(CXX) $(CXXFLAGS) -c -o $@ $<
-
-clean:
-	$(RM) *.o *.a *.exe
-
-rebuild: clean all

client/main.cpp

@@ -30,25 +30,25 @@
 
 using namespace std;
 
-int main(int argc, char* argv[]) {
+int main(int argc, char** argv) {
 	try {
 		//create the singletons
-		ConfigUtility::CreateSingleton();
+		ConfigUtility::Create();
-		UDPNetworkUtility::CreateSingleton();
+		UDPNetworkUtility::Create();
 
 		//call the server's routines
-		ClientApplication::CreateSingleton();
+		ClientApplication::Create();
 		ClientApplication& app = ClientApplication::GetSingleton();
 
 		app.Init(argc, argv);
 		app.Proc();
 		app.Quit();
 
-		ClientApplication::DeleteSingleton();
+		ClientApplication::Delete();
 
 		//delete the singletons
-		ConfigUtility::DeleteSingleton();
+		ConfigUtility::Delete();
-		UDPNetworkUtility::DeleteSingleton();
+		UDPNetworkUtility::Delete();
 	}
 	catch(exception& e) {
 		cerr << "Fatal exception thrown: " << e.what() << endl;

client/makefile

@@ -1,5 +1,5 @@
 #config
-INCLUDES+=. client_utilities renderable scenes ../common/debugging ../common/gameplay ../common/graphics ../common/map ../common/network ../common/network/packet_types ../common/ui ../common/utilities
+INCLUDES+=. scenes ../common/debugging ../common/gameplay ../common/graphics ../common/map ../common/network ../common/network/packet_types ../common/ui ../common/utilities
 LIBS+=client.a ../libcommon.a -lSDL_net -lwsock32 -liphlpapi -lmingw32 -lSDLmain -lSDL -llua
 CXXFLAGS+=-std=c++11 $(addprefix -I,$(INCLUDES))
 
@@ -16,9 +16,7 @@ OUT=$(addprefix $(OUTDIR)/,client)
 
 #targets
 all: $(OBJ) $(OUT)
-	$(MAKE) -C client_utilities
 	$(MAKE) -C scenes
-	$(MAKE) -C renderable
 	$(CXX) $(CXXFLAGS) -o $(OUT) $(OBJ) $(LIBS)
 
 $(OBJ): | $(OBJDIR)

client/renderable/base_monster.cpp

@@ -1,23 +0,0 @@
-/* Copyright: (c) Kayne Ruse 2014
- * 
- * This software is provided 'as-is', without any express or implied
- * warranty. In no event will the authors be held liable for any damages
- * arising from the use of this software.
- * 
- * Permission is granted to anyone to use this software for any purpose,
- * including commercial applications, and to alter it and redistribute it
- * freely, subject to the following restrictions:
- * 
- * 1. The origin of this software must not be misrepresented; you must not
- * claim that you wrote the original software. If you use this software
- * in a product, an acknowledgment in the product documentation would be
- * appreciated but is not required.
- * 
- * 2. Altered source versions must be plainly marked as such, and must not be
- * misrepresented as being the original software.
- * 
- * 3. This notice may not be removed or altered from any source
- * distribution.
-*/
-#include "base_monster.hpp"
-

client/renderable/local_character.cpp

@@ -1,23 +0,0 @@
-/* Copyright: (c) Kayne Ruse 2014
- * 
- * This software is provided 'as-is', without any express or implied
- * warranty. In no event will the authors be held liable for any damages
- * arising from the use of this software.
- * 
- * Permission is granted to anyone to use this software for any purpose,
- * including commercial applications, and to alter it and redistribute it
- * freely, subject to the following restrictions:
- * 
- * 1. The origin of this software must not be misrepresented; you must not
- * claim that you wrote the original software. If you use this software
- * in a product, an acknowledgment in the product documentation would be
- * appreciated but is not required.
- * 
- * 2. Altered source versions must be plainly marked as such, and must not be
- * misrepresented as being the original software.
- * 
- * 3. This notice may not be removed or altered from any source
- * distribution.
-*/
-#include "local_character.hpp"
-

client/renderable/local_character.hpp

@@ -1,40 +0,0 @@
-/* Copyright: (c) Kayne Ruse 2014
- * 
- * This software is provided 'as-is', without any express or implied
- * warranty. In no event will the authors be held liable for any damages
- * arising from the use of this software.
- * 
- * Permission is granted to anyone to use this software for any purpose,
- * including commercial applications, and to alter it and redistribute it
- * freely, subject to the following restrictions:
- * 
- * 1. The origin of this software must not be misrepresented; you must not
- * claim that you wrote the original software. If you use this software
- * in a product, an acknowledgment in the product documentation would be
- * appreciated but is not required.
- * 
- * 2. Altered source versions must be plainly marked as such, and must not be
- * misrepresented as being the original software.
- * 
- * 3. This notice may not be removed or altered from any source
- * distribution.
-*/
-#ifndef LOCALCHARACTER_HPP_
-#define LOCALCHARACTER_HPP_
-
-#include "base_character.hpp"
-#include "statistics.hpp"
-
-class LocalCharacter : public BaseCharacter {
-public:
-	LocalCharacter() = default;
-	~LocalCharacter() = default;
-
-	Statistics* GetBaseStats() { return &baseStats; }
-
-private:
-	Statistics baseStats;
-	//TODO: weapons, armour, buffs, debuffs, etc.
-};
-
-#endif

client/renderable/makefile

@@ -1,37 +0,0 @@
-#config
-INCLUDES+=. .. ../../common/gameplay ../../common/graphics ../../common/utilities
-LIBS+=
-CXXFLAGS+=-std=c++11 $(addprefix -I,$(INCLUDES))
-
-#source
-CXXSRC=$(wildcard *.cpp)
-
-#objects
-OBJDIR=obj
-OBJ+=$(addprefix $(OBJDIR)/,$(CXXSRC:.cpp=.o))
-
-#output
-OUTDIR=..
-OUT=$(addprefix $(OUTDIR)/,client.a)
-
-#targets
-all: $(OBJ) $(OUT)
-	ar -crs $(OUT) $(OBJ)
-
-$(OBJ): | $(OBJDIR)
-
-$(OUT): | $(OUTDIR)
-
-$(OBJDIR):
-	mkdir $(OBJDIR)
-
-$(OUTDIR):
-	mkdir $(OUTDIR)
-
-$(OBJDIR)/%.o: %.cpp
-	$(CXX) $(CXXFLAGS) -c -o $@ $<
-
-clean:
-	$(RM) *.o *.a *.exe
-
-rebuild: clean all

client/renderable/renderable.cpp

@@ -1,31 +0,0 @@
-/* Copyright: (c) Kayne Ruse 2014
- * 
- * This software is provided 'as-is', without any express or implied
- * warranty. In no event will the authors be held liable for any damages
- * arising from the use of this software.
- * 
- * Permission is granted to anyone to use this software for any purpose,
- * including commercial applications, and to alter it and redistribute it
- * freely, subject to the following restrictions:
- * 
- * 1. The origin of this software must not be misrepresented; you must not
- * claim that you wrote the original software. If you use this software
- * in a product, an acknowledgment in the product documentation would be
- * appreciated but is not required.
- * 
- * 2. Altered source versions must be plainly marked as such, and must not be
- * misrepresented as being the original software.
- * 
- * 3. This notice may not be removed or altered from any source
- * distribution.
-*/
-#include "renderable.hpp"
-
-void Renderable::Update() {
-	origin += motion;
-	sprite.Update(0.016);
-}
-
-void Renderable::DrawTo(SDL_Surface* const dest, int camX, int camY) {
-	sprite.DrawTo(dest, origin.x - camX, origin.y - camY);
-}

client/renderable/renderable.hpp

@@ -1,56 +0,0 @@
-/* Copyright: (c) Kayne Ruse 2014
- * 
- * This software is provided 'as-is', without any express or implied
- * warranty. In no event will the authors be held liable for any damages
- * arising from the use of this software.
- * 
- * Permission is granted to anyone to use this software for any purpose,
- * including commercial applications, and to alter it and redistribute it
- * freely, subject to the following restrictions:
- * 
- * 1. The origin of this software must not be misrepresented; you must not
- * claim that you wrote the original software. If you use this software
- * in a product, an acknowledgment in the product documentation would be
- * appreciated but is not required.
- * 
- * 2. Altered source versions must be plainly marked as such, and must not be
- * misrepresented as being the original software.
- * 
- * 3. This notice may not be removed or altered from any source
- * distribution.
-*/
-#ifndef RENDERABLE_HPP_
-#define RENDERABLE_HPP_
-
-#include "bounding_box.hpp"
-#include "sprite_sheet.hpp"
-#include "vector2.hpp"
-
-class Renderable {
-public:
-	Renderable() = default;
-	virtual ~Renderable() = default;
-
-	virtual void Update();
-	virtual void DrawTo(SDL_Surface* const, int camX, int camY);
-
-	SpriteSheet* GetSprite() { return &sprite; }
-
-	//position
-	Vector2 SetOrigin(Vector2 v) { return origin = v; }
-	Vector2 GetOrigin() const { return origin; }
-	Vector2 SetMotion(Vector2 v) { return motion = v; }
-	Vector2 GetMotion() const { return motion; }
-
-	//collision
-	BoundingBox SetBounds(BoundingBox b) { return bounds = b; }
-	BoundingBox GetBounds() { return bounds; }
-
-protected: //TODO: should be private
-	SpriteSheet sprite;
-	Vector2 origin = {0, 0};
-	Vector2 motion = {0, 0};
-	BoundingBox bounds;
-};
-
-#endif

client/scene_list.hpp

@@ -34,7 +34,8 @@ enum class SceneList {
 	OPTIONSMENU,
 	LOBBYMENU,
 	INWORLD,
-	DISCONNECTEDSCREEN,
+	INCOMBAT,
+	CLEANUP,
 };
 
 #endif

client/scenes/clean_up.cpp

@@ -19,11 +19,10 @@
  * 3. This notice may not be removed or altered from any source
  * distribution.
 */
-#include "disconnected_screen.hpp"
+#include "clean_up.hpp"
 
 #include "channels.hpp"
 #include "config_utility.hpp"
-#include "udp_network_utility.hpp"
 
 #include <stdexcept>
 
@@ -31,7 +30,17 @@
 //Public access members
 //-------------------------
 
-DisconnectedScreen::DisconnectedScreen() {
+CleanUp::CleanUp(
+	int* const argClientIndex,
+	int* const argAccountIndex,
+	int* const argCharacterIndex,
+	CharacterMap* argCharacterMap
+	):
+	clientIndex(*argClientIndex),
+	accountIndex(*argAccountIndex),
+	characterIndex(*argCharacterIndex),
+	characterMap(*argCharacterMap)
+{
 	ConfigUtility& config = ConfigUtility::GetSingleton();
 
 	//setup the utility objects
@@ -51,13 +60,19 @@ DisconnectedScreen::DisconnectedScreen() {
 	backButton.SetText("Back");
 
 	//full reset
-	UDPNetworkUtility::GetSingleton().Unbind(Channels::SERVER);
+	network.Unbind(Channels::SERVER);
+	clientIndex = -1;
+	accountIndex = -1;
+	characterIndex = -1;
+//	combatMap.clear();
+	characterMap.clear();
+//	enemyMap.clear();
 
 	//auto return
 	startTick = std::chrono::steady_clock::now();
 }
 
-DisconnectedScreen::~DisconnectedScreen() {
+CleanUp::~CleanUp() {
 	//
 }
 
@@ -65,45 +80,43 @@ DisconnectedScreen::~DisconnectedScreen() {
 //Frame loop
 //-------------------------
 
-void DisconnectedScreen::Update() {
+void CleanUp::Update() {
 	if (std::chrono::steady_clock::now() - startTick > std::chrono::duration<int>(10)) {
 		SetNextScene(SceneList::MAINMENU);
 	}
 
-	//Eat incoming packets
+	//BUGFIX: Eat incoming packets
-	while(UDPNetworkUtility::GetSingleton().Receive());
+	while(network.Receive());
 }
 
-void DisconnectedScreen::Render(SDL_Surface* const screen) {
+void CleanUp::Render(SDL_Surface* const screen) {
-	ConfigUtility& config = ConfigUtility::GetSingleton();
-
 	backButton.DrawTo(screen);
-	font.DrawStringTo(config["client.disconnectMessage"], screen, 50, 30);
+	font.DrawStringTo("You have been disconnected.", screen, 50, 30);
 }
 
 //-------------------------
 //Event handlers
 //-------------------------
 
-void DisconnectedScreen::QuitEvent() {
+void CleanUp::QuitEvent() {
 	SetNextScene(SceneList::QUIT);
 }
 
-void DisconnectedScreen::MouseMotion(SDL_MouseMotionEvent const& motion) {
+void CleanUp::MouseMotion(SDL_MouseMotionEvent const& motion) {
 	backButton.MouseMotion(motion);
 }
 
-void DisconnectedScreen::MouseButtonDown(SDL_MouseButtonEvent const& button) {
+void CleanUp::MouseButtonDown(SDL_MouseButtonEvent const& button) {
 	backButton.MouseButtonDown(button);
 }
 
-void DisconnectedScreen::MouseButtonUp(SDL_MouseButtonEvent const& button) {
+void CleanUp::MouseButtonUp(SDL_MouseButtonEvent const& button) {
 	if (backButton.MouseButtonUp(button) == Button::State::HOVER) {
 		SetNextScene(SceneList::MAINMENU);
 	}
 }
 
-void DisconnectedScreen::KeyDown(SDL_KeyboardEvent const& key) {
+void CleanUp::KeyDown(SDL_KeyboardEvent const& key) {
 	switch(key.keysym.sym) {
 		case SDLK_ESCAPE:
 			SetNextScene(SceneList::MAINMENU);
@@ -111,6 +124,6 @@ void DisconnectedScreen::KeyDown(SDL_KeyboardEvent const& key) {
 	}
 }
 
-void DisconnectedScreen::KeyUp(SDL_KeyboardEvent const& key) {
+void CleanUp::KeyUp(SDL_KeyboardEvent const& key) {
 	//
 }

client/scenes/clean_up.hpp

@@ -19,8 +19,11 @@
  * 3. This notice may not be removed or altered from any source
  * distribution.
 */
-#ifndef DISCONNECTEDSCREEN_HPP_
+#ifndef CLEANUP_HPP_
-#define DISCONNECTEDSCREEN_HPP_
+#define CLEANUP_HPP_
+
+//network
+#include "udp_network_utility.hpp"
 
 //graphics
 #include "image.hpp"
@@ -28,16 +31,22 @@
 #include "button.hpp"
 
 //client
+#include "character.hpp"
 #include "base_scene.hpp"
 
 //std namespace
 #include <chrono>
 
-class DisconnectedScreen : public BaseScene {
+class CleanUp : public BaseScene {
 public:
 	//Public access members
-	DisconnectedScreen();
+	CleanUp(
-	~DisconnectedScreen();
+		int* const argClientIndex,
+		int* const argAccountIndex,
+		int* const argCharacterIndex,
+		CharacterMap* argCharacterMap
+	);
+	~CleanUp();
 
 protected:
 	//Frame loop
@@ -52,6 +61,13 @@ protected:
 	void KeyDown(SDL_KeyboardEvent const&);
 	void KeyUp(SDL_KeyboardEvent const&);
 
+	//shared parameters
+	UDPNetworkUtility& network = UDPNetworkUtility::GetSingleton();
+	int& clientIndex;
+	int& accountIndex;
+	int& characterIndex;
+	CharacterMap& characterMap;
+
 	//graphics
 	Image image;
 	RasterFont font;

client/scenes/in_world.cpp

@@ -34,9 +34,16 @@
 //Public access members
 //-------------------------
 
-InWorld::InWorld(int* const argClientIndex,	int* const argAccountIndex):
+InWorld::InWorld(
+	int* const argClientIndex,
+	int* const argAccountIndex,
+	int* const argCharacterIndex,
+	CharacterMap* argCharacterMap
+	):
 	clientIndex(*argClientIndex),
-	accountIndex(*argAccountIndex)
+	accountIndex(*argAccountIndex),
+	characterIndex(*argCharacterIndex),
+	characterMap(*argCharacterMap)
 {
 	ConfigUtility& config = ConfigUtility::GetSingleton();
 
@@ -64,15 +71,7 @@ InWorld::InWorld(int* const argClientIndex,	int* const argAccountIndex):
 	//load the tilesheet
 	//TODO: add the tilesheet to the map system?
 	//TODO: Tile size and tile sheet should be loaded elsewhere
-	tileSheet.Load(config["dir.tilesets"] + "overworld.bmp", 32, 32);
+	tileSheet.Load(config["dir.tilesets"] + "terrain.bmp", 32, 32);
-
-	//send this player's character info
-	CharacterPacket newPacket;
-	newPacket.type = SerialPacketType::CHARACTER_NEW;
-	strncpy(newPacket.handle, config["client.handle"].c_str(), PACKET_STRING_SIZE);
-	strncpy(newPacket.avatar, config["client.avatar"].c_str(), PACKET_STRING_SIZE);
-	newPacket.accountIndex = accountIndex;
-	network.SendTo(Channels::SERVER, &newPacket);
 
 	//request a sync
 	RequestSynchronize();
@@ -141,22 +140,6 @@ void InWorld::Update() {
 	//update the camera
 	camera.x = localCharacter->GetOrigin().x - camera.marginX;
 	camera.y = localCharacter->GetOrigin().y - camera.marginY;
-
-	//check the connection
-	if (Clock::now() - lastBeat > std::chrono::seconds(3)) {
-		if (attemptedBeats > 2) {
-			RequestDisconnect();
-			SetNextScene(SceneList::DISCONNECTEDSCREEN);
-			ConfigUtility::GetSingleton()["client.disconnectMessage"] = "Error: Lost connection to the server";
-		}
-
-		ServerPacket newPacket;
-		newPacket.type = SerialPacketType::PING;
-		network.SendTo(Channels::SERVER, &newPacket);
-
-		attemptedBeats++;
-		lastBeat = Clock::now();
-	}
 }
 
 void InWorld::FrameEnd() {
@@ -286,15 +269,9 @@ void InWorld::KeyUp(SDL_KeyboardEvent const& key) {
 //-------------------------
 
 void InWorld::HandlePacket(SerialPacket* const argPacket) {
-	switch(argPacket->type) {
+	switch(argPacket->GetType()) {
-		case SerialPacketType::PING:
-			HandlePing(static_cast<ServerPacket*>(argPacket));
-		break;
-		case SerialPacketType::PONG:
-			HandlePong(static_cast<ServerPacket*>(argPacket));
-		break;
 		case SerialPacketType::DISCONNECT:
-			HandleDisconnect(static_cast<ClientPacket*>(argPacket));
+			HandleDisconnect(argPacket);
 		break;
 		case SerialPacketType::CHARACTER_NEW:
 			HandleCharacterNew(static_cast<CharacterPacket*>(argPacket));
@@ -305,56 +282,36 @@ void InWorld::HandlePacket(SerialPacket* const argPacket) {
 		case SerialPacketType::CHARACTER_UPDATE:
 			HandleCharacterUpdate(static_cast<CharacterPacket*>(argPacket));
 		break;
-		case SerialPacketType::CHARACTER_REJECTION:
-			HandleCharacterRejection(static_cast<TextPacket*>(argPacket));
-		break;
 		case SerialPacketType::REGION_CONTENT:
 			HandleRegionContent(static_cast<RegionPacket*>(argPacket));
 		break;
 		//handle errors
 		default:
-			throw(std::runtime_error(std::string() + "Unknown SerialPacketType encountered in InWorld: " + to_string_custom(static_cast<int>(argPacket->type)) ));
+			throw(std::runtime_error(std::string() + "Unknown SerialPacketType encountered in InWorld: " + to_string_custom(static_cast<int>(argPacket->GetType())) ));
 		break;
 	}
 }
 
-void InWorld::HandlePing(ServerPacket* const argPacket) {
+void InWorld::HandleDisconnect(SerialPacket* const argPacket) {
-	ServerPacket newPacket;
+	SetNextScene(SceneList::CLEANUP);
-	newPacket.type = SerialPacketType::PONG;
-	network.SendTo(argPacket->srcAddress, &newPacket);
-}
-
-void InWorld::HandlePong(ServerPacket* const argPacket) {
-	if (network.GetIPAddress(Channels::SERVER)->host != argPacket->srcAddress.host) {
-		throw(std::runtime_error("Heartbeat message received from unknown source"));
-	}
-
-	attemptedBeats = 0;
-	lastBeat = Clock::now();
-}
-
-void InWorld::HandleDisconnect(ClientPacket* const argPacket) {
-	//TODO: More needed in the disconnection
-	SetNextScene(SceneList::DISCONNECTEDSCREEN);
-	ConfigUtility::GetSingleton()["client.disconnectMessage"] = "You have been disconnected";
 }
 
 void InWorld::HandleCharacterNew(CharacterPacket* const argPacket) {
-	if (characterMap.find(argPacket->characterIndex) != characterMap.end()) {
+	if (characterMap.find(argPacket->GetCharacterIndex()) != characterMap.end()) {
 		throw(std::runtime_error("Cannot create duplicate characters"));
 	}
 
 	//create the character object
-	BaseCharacter& newCharacter = characterMap[argPacket->characterIndex];
+	Character& newCharacter = characterMap[argPacket->GetCharacterIndex()];
 
 	//fill out the character's members
-	newCharacter.SetHandle(argPacket->handle);
+	newCharacter.SetHandle(argPacket->GetHandle());
-	newCharacter.SetAvatar(argPacket->avatar);
+	newCharacter.SetAvatar(argPacket->GetAvatar());
 
 	newCharacter.GetSprite()->LoadSurface(ConfigUtility::GetSingleton()["dir.sprites"] + newCharacter.GetAvatar(), 4, 4);
 
-	newCharacter.SetOrigin(argPacket->origin);
+	newCharacter.SetOrigin(argPacket->GetOrigin());
-	newCharacter.SetMotion(argPacket->motion);
+	newCharacter.SetMotion(argPacket->GetMotion());
 	newCharacter.SetBounds({
 		CHARACTER_BOUNDS_X,
 		CHARACTER_BOUNDS_Y,
@@ -362,17 +319,18 @@ void InWorld::HandleCharacterNew(CharacterPacket* const argPacket) {
 		CHARACTER_BOUNDS_HEIGHT
 	});
 
-//	(*newCharacter.GetBaseStats()) = argPacket->stats;
+	*newCharacter.GetStats() = *argPacket->GetStatistics();
 
 	//bookkeeping code
 	newCharacter.CorrectSprite();
 
 	//catch this client's player object
-	if (argPacket->accountIndex == accountIndex && !localCharacter) {
+	if (argPacket->GetAccountIndex() == accountIndex && !localCharacter) {
-		characterIndex = argPacket->characterIndex;
+		characterIndex = argPacket->GetCharacterIndex();
 		localCharacter = &newCharacter;
 
 		//setup the camera
+		//TODO: move this?
 		camera.width = GetScreen()->w;
 		camera.height = GetScreen()->h;
 
@@ -386,46 +344,39 @@ void InWorld::HandleCharacterDelete(CharacterPacket* const argPacket) {
 	//TODO: authenticate when own character is being deleted (linked to a TODO in the server)
 
 	//catch this client's player object
-	if (argPacket->characterIndex == characterIndex) {
+	if (argPacket->GetCharacterIndex() == characterIndex) {
 		characterIndex = -1;
 		localCharacter = nullptr;
 	}
 
-	characterMap.erase(argPacket->characterIndex);
+	characterMap.erase(argPacket->GetCharacterIndex());
 }
 
 void InWorld::HandleCharacterUpdate(CharacterPacket* const argPacket) {
-	if (characterMap.find(argPacket->characterIndex) == characterMap.end()) {
+	if (characterMap.find(argPacket->GetCharacterIndex()) == characterMap.end()) {
+		std::cout << "Warning: HandleCharacterUpdate() is passing to HandleCharacterNew()" << std::endl;
 		HandleCharacterNew(argPacket);
 		return;
 	}
 
-	BaseCharacter& character = characterMap[argPacket->characterIndex];
+	Character& character = characterMap[argPacket->GetCharacterIndex()];
 
 	//other characters moving
-	if (argPacket->characterIndex != characterIndex) {
+	if (argPacket->GetCharacterIndex() != characterIndex) {
-		character.SetOrigin(argPacket->origin);
+		character.SetOrigin(argPacket->GetOrigin());
-		character.SetMotion(argPacket->motion);
+		character.SetMotion(argPacket->GetMotion());
 		character.CorrectSprite();
 	}
 }
 
-void InWorld::HandleCharacterRejection(TextPacket* const argPacket) {
-	RequestDisconnect();
-	SetNextScene(SceneList::DISCONNECTEDSCREEN);
-	ConfigUtility& config = ConfigUtility::GetSingleton();
-	config["client.disconnectMessage"] = "Error: ";
-	config["client.disconnectMessage"] += argPacket->text;
-}
-
 void InWorld::HandleRegionContent(RegionPacket* const argPacket) {
 	//replace existing regions
-	regionPager.UnloadRegion(argPacket->x, argPacket->y);
+	regionPager.UnloadRegion(argPacket->GetX(), argPacket->GetY());
-	regionPager.PushRegion(argPacket->region);
+	regionPager.PushRegion(argPacket->GetRegion());
 
 	//clean up after the serial code
-	delete argPacket->region;
+	delete argPacket->GetRegion();
-	argPacket->region = nullptr;
+	argPacket->SetRegion(nullptr);
 }
 
 //-------------------------
@@ -436,9 +387,9 @@ void InWorld::RequestSynchronize() {
 	ClientPacket newPacket;
 
 	//request a sync
-	newPacket.type = SerialPacketType::SYNCHRONIZE;
+	newPacket.SetType(SerialPacketType::SYNCHRONIZE);
-	newPacket.clientIndex = clientIndex;
+	newPacket.SetClientIndex(clientIndex);
-	newPacket.accountIndex = accountIndex;
+	newPacket.SetAccountIndex(accountIndex);
 
 	//TODO: location, range for sync request
 
@@ -449,15 +400,15 @@ void InWorld::SendPlayerUpdate() {
 	CharacterPacket newPacket;
 
 	//pack the packet
-	newPacket.type = SerialPacketType::CHARACTER_UPDATE;
+	newPacket.SetType(SerialPacketType::CHARACTER_UPDATE);
 
-	newPacket.characterIndex = characterIndex;
+	newPacket.SetCharacterIndex(characterIndex);
 	//NOTE: omitting the handle and avatar here
-	newPacket.accountIndex = accountIndex;
+	newPacket.SetAccountIndex(accountIndex);
-	newPacket.roomIndex = 0; //TODO: room index
+	newPacket.SetRoomIndex(0); //TODO: room index
-	newPacket.origin = localCharacter->GetOrigin();
+	newPacket.SetOrigin(localCharacter->GetOrigin());
-	newPacket.motion = localCharacter->GetMotion();
+	newPacket.SetMotion(localCharacter->GetMotion());
-//	newPacket.stats = *localCharacter->GetBaseStats();
+	*newPacket.GetStatistics() = *localCharacter->GetStats();
 
 	//TODO: gameplay components: equipment, items, buffs, debuffs
 
@@ -468,9 +419,9 @@ void InWorld::RequestDisconnect() {
 	ClientPacket newPacket;
 
 	//send a disconnect request
-	newPacket.type = SerialPacketType::DISCONNECT;
+	newPacket.SetType(SerialPacketType::DISCONNECT);
-	newPacket.clientIndex = clientIndex;
+	newPacket.SetClientIndex(clientIndex);
-	newPacket.accountIndex = accountIndex;
+	newPacket.SetAccountIndex(accountIndex);
 
 	network.SendTo(Channels::SERVER, &newPacket);
 }
@@ -479,9 +430,9 @@ void InWorld::RequestShutDown() {
 	ClientPacket newPacket;
 
 	//send a shutdown request
-	newPacket.type = SerialPacketType::SHUTDOWN;
+	newPacket.SetType(SerialPacketType::SHUTDOWN);
-	newPacket.clientIndex = clientIndex;
+	newPacket.SetClientIndex(clientIndex);
-	newPacket.accountIndex = accountIndex;
+	newPacket.SetAccountIndex(accountIndex);
 
 	network.SendTo(Channels::SERVER, &newPacket);
 }
@@ -490,10 +441,10 @@ void InWorld::RequestRegion(int roomIndex, int x, int y) {
 	RegionPacket packet;
 
 	//pack the region's data
-	packet.type = SerialPacketType::REGION_REQUEST;
+	packet.SetType(SerialPacketType::REGION_REQUEST);
-	packet.roomIndex = roomIndex;
+	packet.SetRoomIndex(roomIndex);
-	packet.x = x;
+	packet.SetX(x);
-	packet.y = y;
+	packet.SetY(y);
 
 	network.SendTo(Channels::SERVER, &packet);
 }

client/scenes/in_world.hpp

@@ -27,7 +27,6 @@
 
 //networking
 #include "udp_network_utility.hpp"
-#include "serial_packet.hpp"
 
 //graphics
 #include "image.hpp"
@@ -38,8 +37,7 @@
 //common
 #include "frame_rate.hpp"
 
-#include "base_character.hpp"
+#include "character.hpp"
-#include "local_character.hpp"
 
 //client
 #include "base_scene.hpp"
@@ -47,12 +45,15 @@
 //STL
 #include <map>
 
-#include <chrono>
-
 class InWorld : public BaseScene {
 public:
 	//Public access members
-	InWorld(int* const argClientIndex, int* const argAccountIndex);
+	InWorld(
+		int* const argClientIndex,
+		int* const argAccountIndex,
+		int* const argCharacterIndex,
+		CharacterMap* argCharacterMap
+	);
 	~InWorld();
 
 protected:
@@ -73,13 +74,10 @@ protected:
 
 	//Network handlers
 	void HandlePacket(SerialPacket* const);
-	void HandlePing(ServerPacket* const);
+	void HandleDisconnect(SerialPacket* const);
-	void HandlePong(ServerPacket* const);
-	void HandleDisconnect(ClientPacket* const);
 	void HandleCharacterNew(CharacterPacket* const);
 	void HandleCharacterDelete(CharacterPacket* const);
 	void HandleCharacterUpdate(CharacterPacket* const);
-	void HandleCharacterRejection(TextPacket* const);
 	void HandleRegionContent(RegionPacket* const);
 
 	//Server control
@@ -96,8 +94,8 @@ protected:
 	UDPNetworkUtility& network = UDPNetworkUtility::GetSingleton();
 	int& clientIndex;
 	int& accountIndex;
-	int characterIndex = -1;
+	int& characterIndex;
-	std::map<int, BaseCharacter> characterMap;
+	CharacterMap& characterMap;
 
 	//graphics
 	Image buttonImage;
@@ -110,8 +108,7 @@ protected:
 	//UI
 	Button disconnectButton;
 	Button shutDownButton;
-
+	//TODO: Review the camera
-	//the camera structure
 	struct {
 		int x = 0, y = 0;
 		int width = 0, height = 0;
@@ -120,13 +117,7 @@ protected:
 	FrameRate fps;
 
 	//game
-	BaseCharacter* localCharacter = nullptr;
+	Character* localCharacter = nullptr;
-
-	//connections
-	//TODO: This needs it's own utility, for both InWorld and InCombat
-	typedef std::chrono::steady_clock Clock;
-	Clock::time_point lastBeat = Clock::now();
-	int attemptedBeats = 0;
 };
 
 #endif

client/scenes/lobby_menu.cpp

@@ -34,10 +34,6 @@ LobbyMenu::LobbyMenu(int* const argClientIndex, int* const argAccountIndex):
 	clientIndex(*argClientIndex),
 	accountIndex(*argAccountIndex)
 {
-	//preemptive reset
-	clientIndex = -1;
-	accountIndex = -1;
-
 	//setup the utility objects
 	image.LoadSurface(config["dir.interface"] + "button_menu.bmp");
 	image.SetClipH(image.GetClipH()/3);
@@ -67,7 +63,7 @@ LobbyMenu::LobbyMenu(int* const argClientIndex, int* const argAccountIndex):
 	//set the server list's position
 	listBox = {300, 50, 200, font.GetCharH()};
 
-	//Eat incoming packets
+	//BUGFIX: Eat incoming packets
 	while(network.Receive());
 
 	//Initial broadcast
@@ -116,7 +112,7 @@ void LobbyMenu::Render(SDL_Surface* const screen) {
 				(Uint16)listBox.w, (Uint16)listBox.h
 			};
 			r.y += i * listBox.h;
-			SDL_FillRect(screen, &r, SDL_MapRGB(screen->format, 49, 150, 5));
+			SDL_FillRect(screen, &r, SDL_MapRGB(screen->format, 255, 127, 39));
 		}
 
 		//draw the server name
@@ -189,19 +185,16 @@ void LobbyMenu::KeyUp(SDL_KeyboardEvent const& key) {
 //-------------------------
 
 void LobbyMenu::HandlePacket(SerialPacket* const argPacket) {
-		switch(argPacket->type) {
+		switch(argPacket->GetType()) {
 		case SerialPacketType::BROADCAST_RESPONSE:
 			HandleBroadcastResponse(static_cast<ServerPacket*>(argPacket));
 		break;
 		case SerialPacketType::JOIN_RESPONSE:
 			HandleJoinResponse(static_cast<ClientPacket*>(argPacket));
 		break;
-		case SerialPacketType::JOIN_REJECTION:
-			HandleJoinRejection(static_cast<TextPacket*>(argPacket));
-		break;
 		//handle errors
 		default:
-			throw(std::runtime_error(std::string() + "Unknown SerialPacketType encountered in LobbyMenu: " + to_string_custom(static_cast<int>(argPacket->type)) ));
+			throw(std::runtime_error(std::string() + "Unknown SerialPacketType encountered in LobbyMenu: " + to_string_custom(static_cast<int>(argPacket->GetType())) ));
 		break;
 	}
 }
@@ -209,10 +202,10 @@ void LobbyMenu::HandlePacket(SerialPacket* const argPacket) {
 void LobbyMenu::HandleBroadcastResponse(ServerPacket* const argPacket) {
 	//extract the data
 	ServerInformation server;
-	server.address = argPacket->srcAddress;
+	server.address = argPacket->GetAddress();
-	server.name = argPacket->name;
+	server.name = argPacket->GetName();
-	server.playerCount = argPacket->playerCount;
+	server.playerCount = argPacket->GetPlayerCount();
-	server.version = argPacket->version;
+	server.version = argPacket->GetVersion();
 
 	//Checking compatibility
 	server.compatible = server.version == NETWORK_VERSION;
@@ -222,14 +215,18 @@ void LobbyMenu::HandleBroadcastResponse(ServerPacket* const argPacket) {
 }
 
 void LobbyMenu::HandleJoinResponse(ClientPacket* const argPacket) {
-	clientIndex = argPacket->clientIndex;
+	clientIndex = argPacket->GetClientIndex();
-	accountIndex = argPacket->accountIndex;
+	accountIndex = argPacket->GetAccountIndex();
-	network.Bind(argPacket->srcAddress, Channels::SERVER);
+	network.Bind(argPacket->GetAddressPtr(), Channels::SERVER);
 	SetNextScene(SceneList::INWORLD);
-}
 
-void LobbyMenu::HandleJoinRejection(TextPacket* const argPacket) {
+	//send this player's character info
-	//TODO: Better output for join rejection
+	CharacterPacket newPacket;
+	newPacket.SetType(SerialPacketType::CHARACTER_NEW);
+	newPacket.SetHandle(config["client.handle"].c_str());
+	newPacket.SetAvatar(config["client.avatar"].c_str());
+	newPacket.SetAccountIndex(accountIndex);
+	network.SendTo(Channels::SERVER, &newPacket);
 }
 
 //-------------------------
@@ -238,8 +235,8 @@ void LobbyMenu::HandleJoinRejection(TextPacket* const argPacket) {
 
 void LobbyMenu::SendBroadcastRequest() {
 	//broadcast to the network, or a specific server
-		ClientPacket packet;
+		ServerPacket packet;
-		packet.type = SerialPacketType::BROADCAST_REQUEST;
+		packet.SetType(SerialPacketType::BROADCAST_REQUEST);
 		network.SendTo(config["server.host"].c_str(), config.Int("server.port"), &packet);
 
 		//reset the server list
@@ -250,10 +247,10 @@ void LobbyMenu::SendBroadcastRequest() {
 void LobbyMenu::SendJoinRequest() {
 	//pack the packet
 		ClientPacket packet;
-		packet.type = SerialPacketType::JOIN_REQUEST;
+		packet.SetType(SerialPacketType::JOIN_REQUEST);
-		strncpy(packet.username, config["client.username"].c_str(), PACKET_STRING_SIZE);
+		packet.SetUsername(config["client.username"].c_str());
 
 		//join the selected server
-		network.SendTo(selection->address, &packet);
+		network.SendTo(&selection->address, &packet);
 		selection = nullptr;
 }

client/scenes/lobby_menu.hpp

@@ -31,7 +31,6 @@
 //utilities
 #include "config_utility.hpp"
 #include "udp_network_utility.hpp"
-#include "serial_packet.hpp"
 
 //client
 #include "base_scene.hpp"
@@ -63,7 +62,6 @@ protected:
 	void HandlePacket(SerialPacket* const);
 	void HandleBroadcastResponse(ServerPacket* const);
 	void HandleJoinResponse(ClientPacket* const);
-	void HandleJoinRejection(TextPacket* const);
 
 	//server control
 	void SendBroadcastRequest();

client/scenes/makefile

@@ -1,5 +1,5 @@
 #config
-INCLUDES+=. .. ../renderable ../../common/gameplay ../../common/graphics ../../common/map ../../common/network ../../common/network/packet_types ../../common/ui ../../common/utilities
+INCLUDES+=. .. ../../common/gameplay ../../common/graphics ../../common/map ../../common/network ../../common/network/packet_types ../../common/ui ../../common/utilities
 LIBS+=
 CXXFLAGS+=-std=c++11 $(addprefix -I,$(INCLUDES))
 

common/gameplay/character_defines.hpp

@@ -27,7 +27,6 @@
 //the speeds that the characters move
 constexpr double CHARACTER_WALKING_SPEED = 2.24;
 constexpr double CHARACTER_WALKING_MOD = 1.0/sqrt(2.0);
-constexpr double CHARACTER_WALKING_NEGATIVE_MOD = 1.0 - CHARACTER_WALKING_MOD;
 
 //the bounds for the character objects, mapped to the default sprites
 constexpr int CHARACTER_BOUNDS_X = 0;

common/gameplay/combat_defines.hpp

@@ -19,18 +19,16 @@
  * 3. This notice may not be removed or altered from any source
  * distribution.
 */
-#ifndef BASEMONSTER_HPP_
+#ifndef COMBATDEFINES_HPP_
-#define BASEMONSTER_HPP_
+#define COMBATDEFINES_HPP_
 
-#include "renderable.hpp"
+#define COMBAT_MAX_CHARACTERS 16
+#define COMBAT_MAX_ENEMIES 16
 
-class BaseMonster {
+enum class TerrainType {
-public:
+	NONE = 0,
-	BaseMonster();
+	GRASSLANDS,
-	virtual ~BaseMonster();
+	//etc.
-
-private:
-	//
 };
 
 #endif

common/network/packet_types/character_packet.cpp

@@ -23,52 +23,50 @@
 
 #include "serial_utility.hpp"
 
-#include "serial_statistics.hpp"
+void CharacterPacket::Serialize(void* buffer) {
-
+	serializeCopy(&buffer, &type, sizeof(SerialPacketType));
-void serializeCharacter(void* buffer, CharacterPacket* packet) {
-	serialCopy(&buffer, &packet->type, sizeof(SerialPacketType));
 
 	//identify the character
-	serialCopy(&buffer, &packet->characterIndex, sizeof(int));
+	serializeCopy(&buffer, &characterIndex, sizeof(int));
-	serialCopy(&buffer, packet->handle, PACKET_STRING_SIZE);
+	serializeCopy(&buffer, handle, PACKET_STRING_SIZE);
-	serialCopy(&buffer, packet->avatar, PACKET_STRING_SIZE);
+	serializeCopy(&buffer, avatar, PACKET_STRING_SIZE);
 
 	//the owner
-	serialCopy(&buffer, &packet->accountIndex, sizeof(int));
+	serializeCopy(&buffer, &accountIndex, sizeof(int));
 
 	//location
-	serialCopy(&buffer, &packet->roomIndex, sizeof(int));
+	serializeCopy(&buffer, &roomIndex, sizeof(int));
-	serialCopy(&buffer, &packet->origin.x, sizeof(double));
+	serializeCopy(&buffer, &origin.x, sizeof(double));
-	serialCopy(&buffer, &packet->origin.y, sizeof(double));
+	serializeCopy(&buffer, &origin.y, sizeof(double));
-	serialCopy(&buffer, &packet->motion.x, sizeof(double));
+	serializeCopy(&buffer, &motion.x, sizeof(double));
-	serialCopy(&buffer, &packet->motion.y, sizeof(double));
+	serializeCopy(&buffer, &motion.y, sizeof(double));
 
 	//stats structure
-	serializeStatistics(&buffer, &packet->stats);
+	serializeCopyStatistics(&buffer, &stats);
 
-	//gameplay components: equipment, items, buffs, debuffs...
+	//TODO: gameplay components: equipment, items, buffs, debuffs
 }
 
-void deserializeCharacter(void* buffer, CharacterPacket* packet) {
+void CharacterPacket::Deserialize(void* buffer) {
-	deserialCopy(&buffer, &packet->type, sizeof(SerialPacketType));
+	deserializeCopy(&buffer, &type, sizeof(SerialPacketType));
 
 	//identify the character
-	deserialCopy(&buffer, &packet->characterIndex, sizeof(int));
+	deserializeCopy(&buffer, &characterIndex, sizeof(int));
-	deserialCopy(&buffer, packet->handle, PACKET_STRING_SIZE);
+	deserializeCopy(&buffer, handle, PACKET_STRING_SIZE);
-	deserialCopy(&buffer, packet->avatar, PACKET_STRING_SIZE);
+	deserializeCopy(&buffer, avatar, PACKET_STRING_SIZE);
 
 	//the owner
-	deserialCopy(&buffer, &packet->accountIndex, sizeof(int));
+	deserializeCopy(&buffer, &accountIndex, sizeof(int));
 
 	//location
-	deserialCopy(&buffer, &packet->roomIndex, sizeof(int));
+	deserializeCopy(&buffer, &roomIndex, sizeof(int));
-	deserialCopy(&buffer, &packet->origin.x, sizeof(double));
+	deserializeCopy(&buffer, &origin.x, sizeof(double));
-	deserialCopy(&buffer, &packet->origin.y, sizeof(double));
+	deserializeCopy(&buffer, &origin.y, sizeof(double));
-	deserialCopy(&buffer, &packet->motion.x, sizeof(double));
+	deserializeCopy(&buffer, &motion.x, sizeof(double));
-	deserialCopy(&buffer, &packet->motion.y, sizeof(double));
+	deserializeCopy(&buffer, &motion.y, sizeof(double));
 
 	//stats structure
-	deserializeStatistics(&buffer, &packet->stats);
+	deserializeCopyStatistics(&buffer, &stats);
 
-	//gameplay components: equipment, items, buffs, debuffs...
+	//TODO: gameplay components: equipment, items, buffs, debuffs
 }

common/network/packet_types/character_packet.hpp

@@ -27,11 +27,48 @@
 #include "vector2.hpp"
 #include "statistics.hpp"
 
-struct CharacterPacket : SerialPacketBase {
+#include <cstring>
+
+class CharacterPacket : public SerialPacketBase {
+public:
+	CharacterPacket() {}
+	~CharacterPacket() {}
+
+	//indentity
+	int SetCharacterIndex(int i) { return characterIndex = i; }
+	const char* SetHandle(const char* s)
+	{ return strncpy(handle, s, PACKET_STRING_SIZE); }
+	const char* SetAvatar(const char* s)
+	{ return strncpy(handle, s, PACKET_STRING_SIZE); }
+
+	int SetAccountIndex(int i) { return accountIndex = i; }
+
+	int GetCharacterIndex() { return characterIndex; }
+	const char* GetHandle() { return handle; }
+	const char* GetAvatar() { return avatar; }
+
+	int GetAccountIndex() { return accountIndex; }
+
+	//location
+	int SetRoomIndex(int i) { return roomIndex = i; }
+	Vector2 SetOrigin(Vector2 v) { return origin = v; }
+	Vector2 SetMotion(Vector2 v) { return motion = v; }
+
+	int GetRoomIndex() { return roomIndex; }
+	Vector2 GetOrigin() { return origin; }
+	Vector2 GetMotion() { return motion; }
+
+	//gameplay
+	Statistics* GetStatistics() { return &stats; }
+
+	virtual void Serialize(void* buffer) override;
+	virtual void Deserialize(void* buffer) override;
+
+private:
 	//identify the character
 	int characterIndex;
-	char handle[PACKET_STRING_SIZE];
+	char handle[PACKET_STRING_SIZE+1];
-	char avatar[PACKET_STRING_SIZE];
+	char avatar[PACKET_STRING_SIZE+1];
 
 	//the owner
 	int accountIndex;
@@ -44,10 +81,7 @@ struct CharacterPacket : SerialPacketBase {
 	//gameplay
 	Statistics stats;
 
-	//gameplay components: equipment, items, buffs, debuffs...
+	//TODO: gameplay components: equipment, items, buffs, debuffs
 };
 
-void serializeCharacter(void* buffer, CharacterPacket* packet);
-void deserializeCharacter(void* buffer, CharacterPacket* packet);
-
 #endif

common/network/packet_types/client_packet.cpp

@@ -23,18 +23,18 @@
 
 #include "serial_utility.hpp"
 
-void serializeClient(void* buffer, ClientPacket* packet) {
+void ClientPacket::Serialize(void* buffer) {
-	serialCopy(&buffer, &packet->type, sizeof(SerialPacketType));
+	serializeCopy(&buffer, &type, sizeof(SerialPacketType));
 
-	serialCopy(&buffer, &packet->clientIndex, sizeof(int));
+	serializeCopy(&buffer, &clientIndex, sizeof(int));
-	serialCopy(&buffer, &packet->accountIndex, sizeof(int));
+	serializeCopy(&buffer, &accountIndex, sizeof(int));
-	serialCopy(&buffer, packet->username, PACKET_STRING_SIZE);
+	serializeCopy(&buffer, username, PACKET_STRING_SIZE);
 }
 
-void deserializeClient(void* buffer, ClientPacket* packet) {
+void ClientPacket::Deserialize(void* buffer) {
-	deserialCopy(&buffer, &packet->type, sizeof(SerialPacketType));
+	deserializeCopy(&buffer, &type, sizeof(SerialPacketType));
 
-	deserialCopy(&buffer, &packet->clientIndex, sizeof(int));
+	deserializeCopy(&buffer, &clientIndex, sizeof(int));
-	deserialCopy(&buffer, &packet->accountIndex, sizeof(int));
+	deserializeCopy(&buffer, &accountIndex, sizeof(int));
-	deserialCopy(&buffer, packet->username, PACKET_STRING_SIZE);
+	deserializeCopy(&buffer, username, PACKET_STRING_SIZE);
 }

common/network/packet_types/client_packet.hpp

@@ -24,13 +24,31 @@
 
 #include "serial_packet_base.hpp"
 
-struct ClientPacket : SerialPacketBase {
+#include <cstring>
+
+class ClientPacket : public SerialPacketBase {
+public:
+	ClientPacket() {}
+	~ClientPacket() {}
+
+	//accessors & mutators
+	int SetClientIndex(int i) { return clientIndex = i; }
+	int SetAccountIndex(int i) { return accountIndex = i; }
+	const char* SetUsername(const char* s)
+	{ return strncpy(username, s, PACKET_STRING_SIZE); }
+
+	int GetClientIndex() { return clientIndex; }
+	int GetAccountIndex() { return accountIndex; }
+	const char* GetUsername() { return username; }
+
+	virtual void Serialize(void* buffer) override;
+	virtual void Deserialize(void* buffer) override;
+
+private:
 	int clientIndex;
 	int accountIndex;
-	char username[PACKET_STRING_SIZE];
+	char username[PACKET_STRING_SIZE+1];
+//	char password[PACKET_STRING_SIZE]; //hashed, not currently used
 };
 
-void serializeClient(void* buffer, ClientPacket* packet);
-void deserializeClient(void* buffer, ClientPacket* packet);
-
 #endif

common/network/packet_types/region_packet.cpp

@@ -23,15 +23,15 @@
 
 #include "serial_utility.hpp"
 
-void serializeRegion(void* buffer, RegionPacket* packet) {
+void RegionPacket::Serialize(void* buffer) {
-	serialCopy(&buffer, &packet->type, sizeof(SerialPacketType));
+	serializeCopy(&buffer, &type, sizeof(SerialPacketType));
 
 	//format
-	serialCopy(&buffer, &packet->roomIndex, sizeof(int));
+	serializeCopy(&buffer, &roomIndex, sizeof(int));
-	serialCopy(&buffer, &packet->x, sizeof(int));
+	serializeCopy(&buffer, &x, sizeof(int));
-	serialCopy(&buffer, &packet->y, sizeof(int));
+	serializeCopy(&buffer, &y, sizeof(int));
 
-	if (packet->type != SerialPacketType::REGION_CONTENT) {
+	if (type != SerialPacketType::REGION_CONTENT) {
 		return;
 	}
 
@@ -39,41 +39,41 @@ void serializeRegion(void* buffer, RegionPacket* packet) {
 	for (int i = 0; i < REGION_WIDTH; i++) {
 		for (int j = 0; j < REGION_HEIGHT; j++) {
 			for (int k = 0; k < REGION_DEPTH; k++) {
-				*reinterpret_cast<Region::type_t*>(buffer) = packet->region->GetTile(i, j, k);
+				*reinterpret_cast<Region::type_t*>(buffer) = region->GetTile(i, j, k);
 				buffer = reinterpret_cast<char*>(buffer) + sizeof(Region::type_t);
 			}
 		}
 	}
 
 	//solids
-	serialCopy(&buffer, packet->region->GetSolidBitset(), REGION_SOLID_FOOTPRINT);
+	serializeCopy(&buffer, region->GetSolidBitset(), REGION_SOLID_FOOTPRINT);
 }
 
-void deserializeRegion(void* buffer, RegionPacket* packet) {
+void RegionPacket::Deserialize(void* buffer) {
-	deserialCopy(&buffer, &packet->type, sizeof(SerialPacketType));
+	deserializeCopy(&buffer, &type, sizeof(SerialPacketType));
 
 	//format
-	deserialCopy(&buffer, &packet->roomIndex, sizeof(int));
+	deserializeCopy(&buffer, &roomIndex, sizeof(int));
-	deserialCopy(&buffer, &packet->x, sizeof(int));
+	deserializeCopy(&buffer, &x, sizeof(int));
-	deserialCopy(&buffer, &packet->y, sizeof(int));
+	deserializeCopy(&buffer, &y, sizeof(int));
 
-	if (packet->type != SerialPacketType::REGION_CONTENT) {
+	if (type != SerialPacketType::REGION_CONTENT) {
 		return;
 	}
 
 	//an object to work on
-	packet->region = new Region(packet->x, packet->y);
+	region = new Region(x, y);
 
 	//tiles
 	for (int i = 0; i < REGION_WIDTH; i++) {
 		for (int j = 0; j < REGION_HEIGHT; j++) {
 			for (int k = 0; k < REGION_DEPTH; k++) {
-				packet->region->SetTile(i, j, k, *reinterpret_cast<Region::type_t*>(buffer));
+				region->SetTile(i, j, k, *reinterpret_cast<Region::type_t*>(buffer));
 				buffer = reinterpret_cast<char*>(buffer) + sizeof(Region::type_t);
 			}
 		}
 	}
 
 	//solids
-	deserialCopy(&buffer, packet->region->GetSolidBitset(), REGION_SOLID_FOOTPRINT);
+	deserializeCopy(&buffer, region->GetSolidBitset(), REGION_SOLID_FOOTPRINT);
 }

common/network/packet_types/region_packet.hpp

@@ -27,13 +27,35 @@
 #include "region.hpp"
 
 #include <cmath>
+#include <cstring>
 
 //define the memory footprint for the region's members
 constexpr int REGION_TILE_FOOTPRINT = sizeof(Region::type_t) * REGION_WIDTH * REGION_HEIGHT * REGION_DEPTH;
 constexpr int REGION_SOLID_FOOTPRINT = ceil(REGION_WIDTH * REGION_HEIGHT / 8.0);
 constexpr int REGION_METADATA_FOOTPRINT = sizeof(int) * 3;
 
-struct RegionPacket : SerialPacketBase {
+class RegionPacket : public SerialPacketBase {
+public:
+	RegionPacket() {}
+	~RegionPacket() {}
+
+	//location
+	int SetRoomIndex(int i) { return roomIndex = i; }
+	int SetX(int i) { return x = i; }
+	int SetY(int i) { return y = i; }
+
+	int GetRoomIndex() { return roomIndex; }
+	int GetX() { return x; }
+	int GetY() { return y; }
+
+	//the region itself
+	Region* SetRegion(Region* r) { return region = r; }
+	Region* GetRegion() { return region; }
+
+	virtual void Serialize(void* buffer) override;
+	virtual void Deserialize(void* buffer) override;
+
+private:
 	//location/identify the region
 	int roomIndex;
 	int x, y;
@@ -42,7 +64,4 @@ struct RegionPacket : SerialPacketBase {
 	Region* region;
 };
 
-void serializeRegion(void* buffer, RegionPacket* packet);
-void deserializeRegion(void* buffer, RegionPacket* packet);
-
 #endif

common/network/packet_types/serial_packet_base.cpp

@@ -1,4 +1,4 @@
-/* Copyright: (c) Kayne Ruse 2014
+/* Copyright: (c) Kayne Ruse 2013, 2014
  * 
  * This software is provided 'as-is', without any express or implied
  * warranty. In no event will the authors be held liable for any damages
@@ -21,4 +21,4 @@
 */
 #include "serial_packet_base.hpp"
 
-//sanity check
+//NOTE: This is a sanity check

common/network/packet_types/serial_packet_base.hpp

@@ -26,14 +26,28 @@
 
 #include "SDL/SDL_net.h"
 
+//The packets use a char array for string storage
 constexpr int PACKET_STRING_SIZE = 100;
 
-struct SerialPacketBase {
+class SerialPacketBase {
-	//members
+public:
+	SerialPacketType SetType(SerialPacketType t) { return type = t; }
+	SerialPacketType GetType() { return type; }
+
+	IPaddress GetAddress() { return srcAddress; }
+	IPaddress* GetAddressPtr() { return &srcAddress; }
+
+	SerialPacketBase() {};
+	virtual ~SerialPacketBase() {};
+
+	virtual void Serialize(void* buffer) = 0;
+	virtual void Deserialize(void* buffer) = 0;
+
+protected:
+	friend class UDPNetworkUtility;
+
 	SerialPacketType type;
 	IPaddress srcAddress;
-
-	virtual ~SerialPacketBase() {};
 };
 
 #endif

common/network/packet_types/serial_statistics.cpp

@@ -1,64 +0,0 @@
-/* Copyright: (c) Kayne Ruse 2014
- * 
- * This software is provided 'as-is', without any express or implied
- * warranty. In no event will the authors be held liable for any damages
- * arising from the use of this software.
- * 
- * Permission is granted to anyone to use this software for any purpose,
- * including commercial applications, and to alter it and redistribute it
- * freely, subject to the following restrictions:
- * 
- * 1. The origin of this software must not be misrepresented; you must not
- * claim that you wrote the original software. If you use this software
- * in a product, an acknowledgment in the product documentation would be
- * appreciated but is not required.
- * 
- * 2. Altered source versions must be plainly marked as such, and must not be
- * misrepresented as being the original software.
- * 
- * 3. This notice may not be removed or altered from any source
- * distribution.
-*/
-#include "serial_statistics.hpp"
-
-#include "serial_utility.hpp"
-
-void serializeStatistics(void** buffer, Statistics* stats) {
-	//integers
-	serialCopy(buffer, &stats->level, sizeof(int));
-	serialCopy(buffer, &stats->exp, sizeof(int));
-	serialCopy(buffer, &stats->maxHP, sizeof(int));
-	serialCopy(buffer, &stats->health, sizeof(int));
-	serialCopy(buffer, &stats->maxMP, sizeof(int));
-	serialCopy(buffer, &stats->mana, sizeof(int));
-	serialCopy(buffer, &stats->attack, sizeof(int));
-	serialCopy(buffer, &stats->defence, sizeof(int));
-	serialCopy(buffer, &stats->intelligence, sizeof(int));
-	serialCopy(buffer, &stats->resistance, sizeof(int));
-	serialCopy(buffer, &stats->speed, sizeof(int));
-
-	//floats
-	serialCopy(buffer, &stats->accuracy, sizeof(float));
-	serialCopy(buffer, &stats->evasion, sizeof(float));
-	serialCopy(buffer, &stats->luck, sizeof(float));
-}
-
-void deserializeStatistics(void** buffer, Statistics* stats) {
-	//integers
-	deserialCopy(buffer, &stats->level, sizeof(int));
-	deserialCopy(buffer, &stats->exp, sizeof(int));
-	deserialCopy(buffer, &stats->maxHP, sizeof(int));
-	deserialCopy(buffer, &stats->health, sizeof(int));
-	deserialCopy(buffer, &stats->maxMP, sizeof(int));
-	deserialCopy(buffer, &stats->mana, sizeof(int));
-	deserialCopy(buffer, &stats->attack, sizeof(int));
-	deserialCopy(buffer, &stats->defence, sizeof(int));
-	deserialCopy(buffer, &stats->intelligence, sizeof(int));
-	deserialCopy(buffer, &stats->resistance, sizeof(int));
-	deserialCopy(buffer, &stats->speed, sizeof(int));
-
-	//floats
-	deserialCopy(buffer, &stats->accuracy, sizeof(float));
-	deserialCopy(buffer, &stats->evasion, sizeof(float));
-	deserialCopy(buffer, &stats->luck, sizeof(float));
-}

common/network/packet_types/serial_statistics.hpp

@@ -1,30 +0,0 @@
-/* Copyright: (c) Kayne Ruse 2014
- * 
- * This software is provided 'as-is', without any express or implied
- * warranty. In no event will the authors be held liable for any damages
- * arising from the use of this software.
- * 
- * Permission is granted to anyone to use this software for any purpose,
- * including commercial applications, and to alter it and redistribute it
- * freely, subject to the following restrictions:
- * 
- * 1. The origin of this software must not be misrepresented; you must not
- * claim that you wrote the original software. If you use this software
- * in a product, an acknowledgment in the product documentation would be
- * appreciated but is not required.
- * 
- * 2. Altered source versions must be plainly marked as such, and must not be
- * misrepresented as being the original software.
- * 
- * 3. This notice may not be removed or altered from any source
- * distribution.
-*/
-#ifndef SERIALSTATISTICS_HPP_
-#define SERIALSTATISTICS_HPP_
-
-#include "statistics.hpp"
-
-void serializeStatistics(void** buffer, Statistics* stats);
-void deserializeStatistics(void** buffer, Statistics* stats);
-
-#endif

common/network/packet_types/server_packet.cpp

@@ -23,20 +23,20 @@
 
 #include "serial_utility.hpp"
 
-void serializeServer(void* buffer, ServerPacket* packet) {
+void ServerPacket::Serialize(void* buffer) {
-	serialCopy(&buffer, &packet->type, sizeof(SerialPacketType));
+	serializeCopy(&buffer, &type, sizeof(SerialPacketType));
 
 	//identify the server
-	serialCopy(&buffer, packet->name, PACKET_STRING_SIZE);
+	serializeCopy(&buffer, name, PACKET_STRING_SIZE);
-	serialCopy(&buffer, &packet->playerCount, sizeof(int));
+	serializeCopy(&buffer, &playerCount, sizeof(int));
-	serialCopy(&buffer, &packet->version, sizeof(int));
+	serializeCopy(&buffer, &version, sizeof(int));
 }
 
-void deserializeServer(void* buffer, ServerPacket* packet) {
+void ServerPacket::Deserialize(void* buffer) {
-	deserialCopy(&buffer, &packet->type, sizeof(SerialPacketType));
+	deserializeCopy(&buffer, &type, sizeof(SerialPacketType));
 
 	//identify the server
-	deserialCopy(&buffer, packet->name, PACKET_STRING_SIZE);
+	deserializeCopy(&buffer, name, PACKET_STRING_SIZE);
-	deserialCopy(&buffer, &packet->playerCount, sizeof(int));
+	deserializeCopy(&buffer, &playerCount, sizeof(int));
-	deserialCopy(&buffer, &packet->version, sizeof(int));
+	deserializeCopy(&buffer, &version, sizeof(int));
 }

common/network/packet_types/server_packet.hpp

@@ -24,14 +24,30 @@
 
 #include "serial_packet_base.hpp"
 
-struct ServerPacket : SerialPacketBase {
+#include <cstring>
+
+class ServerPacket : public SerialPacketBase {
+public:
+	ServerPacket() {}
+	~ServerPacket() {}
+
+	const char* SetName(const char* s)
+	{ return strncpy(name, s, PACKET_STRING_SIZE); }
+	int SetPlayerCount(int i) { return playerCount = i; }
+	int SetVersion(int i) { return version = i; }
+
+	const char* GetName() { return name; }
+	int GetPlayerCount() { return playerCount; }
+	int GetVersion() { return version; }
+
+	virtual void Serialize(void* buffer) override;
+	virtual void Deserialize(void* buffer) override;
+
+private:
 	//identify the server
-	char name[PACKET_STRING_SIZE];
+	char name[PACKET_STRING_SIZE+1];
 	int playerCount;
 	int version;
 };
 
-void serializeServer(void* buffer, ServerPacket* packet);
-void deserializeServer(void* buffer, ServerPacket* packet);
-
 #endif

common/network/packet_types/text_packet.cpp

@@ -1,40 +0,0 @@
-/* Copyright: (c) Kayne Ruse 2013, 2014
- * 
- * This software is provided 'as-is', without any express or implied
- * warranty. In no event will the authors be held liable for any damages
- * arising from the use of this software.
- * 
- * Permission is granted to anyone to use this software for any purpose,
- * including commercial applications, and to alter it and redistribute it
- * freely, subject to the following restrictions:
- * 
- * 1. The origin of this software must not be misrepresented; you must not
- * claim that you wrote the original software. If you use this software
- * in a product, an acknowledgment in the product documentation would be
- * appreciated but is not required.
- * 
- * 2. Altered source versions must be plainly marked as such, and must not be
- * misrepresented as being the original software.
- * 
- * 3. This notice may not be removed or altered from any source
- * distribution.
-*/
-#include "text_packet.hpp"
-
-#include "serial_utility.hpp"
-
-void serializeText(void* buffer, TextPacket* packet) {
-	serialCopy(&buffer, &packet->type, sizeof(SerialPacketType));
-
-	//content
-	serialCopy(&buffer, packet->name, PACKET_STRING_SIZE);
-	serialCopy(&buffer, packet->text, PACKET_STRING_SIZE);
-}
-
-void deserializeText(void* buffer, TextPacket* packet) {
-	deserialCopy(&buffer, &packet->type, sizeof(SerialPacketType));
-
-	//content
-	deserialCopy(&buffer, packet->name, PACKET_STRING_SIZE);
-	deserialCopy(&buffer, packet->text, PACKET_STRING_SIZE);
-}

common/network/packet_types/text_packet.hpp

@@ -1,35 +0,0 @@
-/* Copyright: (c) Kayne Ruse 2013, 2014
- * 
- * This software is provided 'as-is', without any express or implied
- * warranty. In no event will the authors be held liable for any damages
- * arising from the use of this software.
- * 
- * Permission is granted to anyone to use this software for any purpose,
- * including commercial applications, and to alter it and redistribute it
- * freely, subject to the following restrictions:
- * 
- * 1. The origin of this software must not be misrepresented; you must not
- * claim that you wrote the original software. If you use this software
- * in a product, an acknowledgment in the product documentation would be
- * appreciated but is not required.
- * 
- * 2. Altered source versions must be plainly marked as such, and must not be
- * misrepresented as being the original software.
- * 
- * 3. This notice may not be removed or altered from any source
- * distribution.
-*/
-#ifndef TEXTPACKET_HPP_
-#define TEXTPACKET_HPP_
-
-#include "serial_packet_base.hpp"
-
-struct TextPacket : SerialPacketBase {
-	char name[PACKET_STRING_SIZE];
-	char text[PACKET_STRING_SIZE];
-};
-
-void serializeText(void* buffer, TextPacket* packet);
-void deserializeText(void* buffer, TextPacket* packet);
-
-#endif

common/network/serial_packet.hpp

@@ -22,28 +22,31 @@
 #ifndef SERIALPACKET_HPP_
 #define SERIALPACKET_HPP_
 
+/* DOCS: serial_packet.hpp is used to define a number of required constants.
+ * These are used extensively by the server and client
+*/
+
 #include "serial_packet_base.hpp"
 #include "character_packet.hpp"
 #include "client_packet.hpp"
 #include "region_packet.hpp"
 #include "server_packet.hpp"
-#include "text_packet.hpp"
 
 //SerialPacketBase is defined in serial_packet_base.hpp
 typedef SerialPacketBase SerialPacket;
 
 //DOCS: NETWORK_VERSION is used to discern compatible servers and clients
-constexpr int NETWORK_VERSION = 20140909;
+constexpr int NETWORK_VERSION = 20140831;
 
-union MaxPacket {
+//_MaxPacket Should not be used
+union _MaxPacket {
 	CharacterPacket a;
 	ClientPacket b;
 	RegionPacket c;
 	ServerPacket d;
-	TextPacket e;
 };
 
-constexpr int MAX_PACKET_SIZE = sizeof(MaxPacket);
+constexpr int MAX_PACKET_SIZE = sizeof(_MaxPacket);
 
 /* DOCS: PACKET_BUFFER_SIZE is the memory required to store serialized data
  * DOCS: SerialPacketType::REGION_CONTENT is currently the largest packet type

common/network/serial_packet_type.hpp

@@ -52,6 +52,7 @@ enum class SerialPacketType {
 	//Connecting to a server as a client
 	JOIN_REQUEST,
 	JOIN_RESPONSE,
+	JOIN_REJECTION,
 
 	//client requests all information from the server
 	SYNCHRONIZE,
@@ -87,23 +88,10 @@ enum class SerialPacketType {
 	CHARACTER_STATS_REQUEST,
 	CHARACTER_STATS_RESPONSE,
 
-	//-------------------------
+	//reject a character request
-	//TextPacket
-	//  name, text
-	//-------------------------
-
-	//general speech
-	TEXT_BROADCAST,
-
-	//rejection/error messages
-	SHUTDOWN_REJECTION,
-	JOIN_REJECTION,
 	CHARACTER_REJECTION,
 
-	//-------------------------
 	//not used
-	//-------------------------
-
 	LAST
 };
 

common/network/serial_utility.cpp

@@ -21,99 +21,127 @@
 */
 #include "serial_utility.hpp"
 
-//packet types
+#include "serial_packet_type.hpp"
-#include "character_packet.hpp"
+
+#include "server_packet.hpp"
 #include "client_packet.hpp"
 #include "region_packet.hpp"
-#include "server_packet.hpp"
+#include "character_packet.hpp"
-#include "text_packet.hpp"
 
 #include <cstring>
 
-//raw memory copy
+void serializePacket(SerialPacketBase* packet, void* data) {
-void serialCopy(void** buffer, void* data, int size) {
+	switch(packet->GetType()) {
-	memcpy(*buffer, data, size);
-	*buffer = reinterpret_cast<char*>(*buffer) + size;
-}
-
-void deserialCopy(void** buffer, void* data, int size) {
-	memcpy(data, *buffer, size);
-	*buffer = reinterpret_cast<char*>(*buffer) + size;
-}
-
-//DOCS: The server and client MUST use the correct packet types
-
-//main switch functions
-void serializePacket(void* buffer, SerialPacketBase* packet) {
-	switch(packet->type) {
 		case SerialPacketType::PING:
 		case SerialPacketType::PONG:
 		case SerialPacketType::BROADCAST_REQUEST:
 		case SerialPacketType::BROADCAST_RESPONSE:
-			serializeServer(buffer, static_cast<ServerPacket*>(packet));
+			static_cast<ServerPacket*>(packet)->Serialize(data);
 		break;
 		case SerialPacketType::JOIN_REQUEST:
 		case SerialPacketType::JOIN_RESPONSE:
+		case SerialPacketType::JOIN_REJECTION:
 		case SerialPacketType::SYNCHRONIZE:
 		case SerialPacketType::DISCONNECT:
 		case SerialPacketType::SHUTDOWN:
-			serializeClient(buffer, static_cast<ClientPacket*>(packet));
+			static_cast<ClientPacket*>(packet)->Serialize(data);
 		break;
 		case SerialPacketType::REGION_REQUEST:
 		case SerialPacketType::REGION_CONTENT:
-			serializeRegion(buffer, static_cast<RegionPacket*>(packet));
+			static_cast<RegionPacket*>(packet)->Serialize(data);
 		break;
 		case SerialPacketType::CHARACTER_NEW:
 		case SerialPacketType::CHARACTER_DELETE:
 		case SerialPacketType::CHARACTER_UPDATE:
 		case SerialPacketType::CHARACTER_STATS_REQUEST:
 		case SerialPacketType::CHARACTER_STATS_RESPONSE:
-			serializeCharacter(buffer, static_cast<CharacterPacket*>(packet));
-		break;
-		case SerialPacketType::TEXT_BROADCAST:
-		case SerialPacketType::JOIN_REJECTION:
-		case SerialPacketType::SHUTDOWN_REJECTION:
 		case SerialPacketType::CHARACTER_REJECTION:
-			serializeText(buffer, static_cast<TextPacket*>(packet));
+			static_cast<CharacterPacket*>(packet)->Serialize(data);
 		break;
 	}
 }
 
-void deserializePacket(void* buffer, SerialPacketBase* packet) {
+void deserializePacket(SerialPacketBase* packet, void* data) {
-	//find the type, so that you can actually deserialize the packet!
+	//get the type
 	SerialPacketType type;
-	memcpy(&type, buffer, sizeof(SerialPacketType));
+	memcpy(&type, data, sizeof(SerialPacketType));
 
 	switch(type) {
 		case SerialPacketType::PING:
 		case SerialPacketType::PONG:
 		case SerialPacketType::BROADCAST_REQUEST:
 		case SerialPacketType::BROADCAST_RESPONSE:
-			deserializeServer(buffer, static_cast<ServerPacket*>(packet));
+			static_cast<ServerPacket*>(packet)->Deserialize(data);
 		break;
 		case SerialPacketType::JOIN_REQUEST:
 		case SerialPacketType::JOIN_RESPONSE:
+		case SerialPacketType::JOIN_REJECTION:
 		case SerialPacketType::SYNCHRONIZE:
 		case SerialPacketType::DISCONNECT:
 		case SerialPacketType::SHUTDOWN:
-			deserializeClient(buffer, static_cast<ClientPacket*>(packet));
+			static_cast<ClientPacket*>(packet)->Deserialize(data);
 		break;
 		case SerialPacketType::REGION_REQUEST:
 		case SerialPacketType::REGION_CONTENT:
-			deserializeRegion(buffer, static_cast<RegionPacket*>(packet));
+			static_cast<RegionPacket*>(packet)->Deserialize(data);
 		break;
 		case SerialPacketType::CHARACTER_NEW:
 		case SerialPacketType::CHARACTER_DELETE:
 		case SerialPacketType::CHARACTER_UPDATE:
 		case SerialPacketType::CHARACTER_STATS_REQUEST:
 		case SerialPacketType::CHARACTER_STATS_RESPONSE:
-			deserializeCharacter(buffer, static_cast<CharacterPacket*>(packet));
-		break;
-		case SerialPacketType::TEXT_BROADCAST:
-		case SerialPacketType::JOIN_REJECTION:
-		case SerialPacketType::SHUTDOWN_REJECTION:
 		case SerialPacketType::CHARACTER_REJECTION:
-			deserializeText(buffer, static_cast<TextPacket*>(packet));
+			static_cast<CharacterPacket*>(packet)->Deserialize(data);
 		break;
 	}
 }
+
+void serializeCopy(void** bufferHead, void* data, int size) {
+	memcpy(*bufferHead, data, size);
+	(*bufferHead) = static_cast<void*>(static_cast<char*>(*bufferHead) + size);
+}
+
+void deserializeCopy(void** bufferHead, void* data, int size) {
+	memcpy(data, *bufferHead, size);
+	(*bufferHead) = static_cast<void*>(static_cast<char*>(*bufferHead) + size);
+}
+
+void serializeCopyStatistics(void** bufferHead, Statistics* stats) {
+	//integers
+	serializeCopy(bufferHead, &stats->level, sizeof(int));
+	serializeCopy(bufferHead, &stats->exp, sizeof(int));
+	serializeCopy(bufferHead, &stats->maxHP, sizeof(int));
+	serializeCopy(bufferHead, &stats->health, sizeof(int));
+	serializeCopy(bufferHead, &stats->maxMP, sizeof(int));
+	serializeCopy(bufferHead, &stats->mana, sizeof(int));
+	serializeCopy(bufferHead, &stats->attack, sizeof(int));
+	serializeCopy(bufferHead, &stats->defence, sizeof(int));
+	serializeCopy(bufferHead, &stats->intelligence, sizeof(int));
+	serializeCopy(bufferHead, &stats->resistance, sizeof(int));
+	serializeCopy(bufferHead, &stats->speed, sizeof(int));
+
+	//floats
+	serializeCopy(bufferHead, &stats->accuracy, sizeof(float));
+	serializeCopy(bufferHead, &stats->evasion, sizeof(float));
+	serializeCopy(bufferHead, &stats->luck, sizeof(float));
+}
+
+void deserializeCopyStatistics(void** bufferHead, Statistics* stats) {
+	//integers
+	deserializeCopy(bufferHead, &stats->level, sizeof(int));
+	deserializeCopy(bufferHead, &stats->exp, sizeof(int));
+	deserializeCopy(bufferHead, &stats->maxHP, sizeof(int));
+	deserializeCopy(bufferHead, &stats->health, sizeof(int));
+	deserializeCopy(bufferHead, &stats->maxMP, sizeof(int));
+	deserializeCopy(bufferHead, &stats->mana, sizeof(int));
+	deserializeCopy(bufferHead, &stats->attack, sizeof(int));
+	deserializeCopy(bufferHead, &stats->defence, sizeof(int));
+	deserializeCopy(bufferHead, &stats->intelligence, sizeof(int));
+	deserializeCopy(bufferHead, &stats->resistance, sizeof(int));
+	deserializeCopy(bufferHead, &stats->speed, sizeof(int));
+
+	//floats
+	deserializeCopy(bufferHead, &stats->accuracy, sizeof(float));
+	deserializeCopy(bufferHead, &stats->evasion, sizeof(float));
+	deserializeCopy(bufferHead, &stats->luck, sizeof(float));
+}

common/network/serial_utility.hpp

@@ -24,14 +24,19 @@
 
 #include "serial_packet_base.hpp"
 
-#include <cstring>
+#include "statistics.hpp"
 
-//raw memory copy
+//NOTE: The naming conventions here are fucking terrible
-void serialCopy(void** buffer, void* data, int size);
-void deserialCopy(void** buffer, void* data, int size);
 
-//primary functions
+//BUGFIX: There's really no way to escape this :(
-void serializePacket(void* buffer, SerialPacketBase* packet);
+void serializePacket(SerialPacketBase* packet, void* data);
-void deserializePacket(void* buffer, SerialPacketBase* packet);
+void deserializePacket(SerialPacketBase* packet, void* data);
+
+//raw memcpy
+void serializeCopy(void** bufferHead, void* data, int size);
+void deserializeCopy(void** bufferHead, void* data, int size);
+
+void serializeCopyStatistics(void** bufferHead, Statistics* stats);
+void deserializeCopyStatistics(void** bufferHead, Statistics* stats);
 
 #endif

common/network/udp_network_utility.cpp

@@ -21,13 +21,12 @@
 */
 #include "udp_network_utility.hpp"
 
-#include "serial_packet.hpp"
 #include "serial_utility.hpp"
 
 #include <stdexcept>
 
-//NOTE: memset() is used before sending a packet to remove old data; you don't want to send sensitive data over the network
+//BUGFIX: memset() is used before sending a packet to remove old data; you don't want to send sensitive data over the network
-//NOTE: don't confuse SerialPacketBase with UDPpacket
+//NOTE: don't confuse SerialPacket with UDPpacket
 
 void UDPNetworkUtility::Open(int port) {
 	socket = SDLNet_UDP_Open(port);
@@ -55,11 +54,11 @@ int UDPNetworkUtility::Bind(const char* ip, int port, int channel) {
 		throw(std::runtime_error("Failed to resolve a host"));
 	}
 
-	return Bind(add, channel);
+	return Bind(&add, channel);
 }
 
-int UDPNetworkUtility::Bind(IPaddress add, int channel) {
+int UDPNetworkUtility::Bind(IPaddress* add, int channel) {
-	int ret = SDLNet_UDP_Bind(socket, channel, &add);
+	int ret = SDLNet_UDP_Bind(socket, channel, add);
 
 	if (ret < 0) {
 		throw(std::runtime_error("Failed to bind to a channel"));
@@ -82,17 +81,17 @@ int UDPNetworkUtility::SendTo(const char* ip, int port, void* data, int len) {
 		throw(std::runtime_error("Failed to resolve a host"));
 	}
 
-	SendTo(add, data, len);
+	SendTo(&add, data, len);
 }
 
-int UDPNetworkUtility::SendTo(IPaddress add, void* data, int len) {
+int UDPNetworkUtility::SendTo(IPaddress* add, void* data, int len) {
 	if (len > packet->maxlen) {
 		throw(std::runtime_error("The buffer is to large for the UDPpacket"));
 	}
 	memset(packet->data, 0, packet->maxlen);
 	memcpy(packet->data, data, len);
 	packet->len = len;
-	packet->address = add;
+	packet->address = *add;
 
 	int ret = SDLNet_UDP_Send(socket, -1, packet);
 
@@ -153,23 +152,23 @@ int UDPNetworkUtility::Receive() {
 }
 
 //-------------------------
-//send a SerialPacketBase
+//send a SerialPacket
 //-------------------------
 
-int UDPNetworkUtility::SendTo(const char* ip, int port, SerialPacketBase* serialPacket) {
+int UDPNetworkUtility::SendTo(const char* ip, int port, SerialPacket* serialPacket) {
 	IPaddress add;
 	if (SDLNet_ResolveHost(&add, ip, port) == -1) {
 		throw(std::runtime_error("Failed to resolve a host"));
 	}
 
-	SendTo(add, serialPacket);
+	SendTo(&add, serialPacket);
 }
 
-int UDPNetworkUtility::SendTo(IPaddress add, SerialPacketBase* serialPacket) {
+int UDPNetworkUtility::SendTo(IPaddress* add, SerialPacket* serialPacket) {
 	memset(packet->data, 0, packet->maxlen);
-	serializePacket(packet->data, serialPacket);
+	serializePacket(serialPacket, packet->data);
 	packet->len = PACKET_BUFFER_SIZE;
-	packet->address = add;
+	packet->address = *add;
 
 	int ret = SDLNet_UDP_Send(socket, -1, packet);
 
@@ -180,9 +179,9 @@ int UDPNetworkUtility::SendTo(IPaddress add, SerialPacketBase* serialPacket) {
 	return ret;
 }
 
-int UDPNetworkUtility::SendTo(int channel, SerialPacketBase* serialPacket) {
+int UDPNetworkUtility::SendTo(int channel, SerialPacket* serialPacket) {
 	memset(packet->data, 0, packet->maxlen);
-	serializePacket(packet->data, serialPacket);
+	serializePacket(serialPacket, packet->data);
 	packet->len = PACKET_BUFFER_SIZE;
 
 	int ret = SDLNet_UDP_Send(socket, channel, packet);
@@ -194,9 +193,9 @@ int UDPNetworkUtility::SendTo(int channel, SerialPacketBase* serialPacket) {
 	return ret;
 }
 
-int UDPNetworkUtility::SendToAllChannels(SerialPacketBase* serialPacket) {
+int UDPNetworkUtility::SendToAllChannels(SerialPacket* serialPacket) {
 	memset(packet->data, 0, packet->maxlen);
-	serializePacket(packet->data, serialPacket);
+	serializePacket(serialPacket, packet->data);
 	packet->len = PACKET_BUFFER_SIZE;
 
 	int sent = 0;
@@ -211,11 +210,14 @@ int UDPNetworkUtility::SendToAllChannels(SerialPacketBase* serialPacket) {
 	return sent;
 }
 
-int UDPNetworkUtility::Receive(SerialPacketBase* serialPacket) {
+int UDPNetworkUtility::Receive(SerialPacket* serialPacket) {
 	memset(packet->data, 0, packet->maxlen);
 	int ret = SDLNet_UDP_Recv(socket, packet);
-	deserializePacket(packet->data, serialPacket);
+	if (ret > 0) {
-	serialPacket->srcAddress = packet->address;
+		//BUG: This simply fails
+		deserializePacket(serialPacket, packet->data);
+		serialPacket->srcAddress = packet->address;
+	}
 
 	if (ret < 0) {
 		throw(std::runtime_error("Unknown network error occured"));

common/network/udp_network_utility.hpp

@@ -23,7 +23,7 @@
 #define UDPNETWORKUTILITY_HPP_
 
 //common
-#include "serial_packet_base.hpp"
+#include "serial_packet.hpp"
 #include "singleton.hpp"
 
 //APIs
@@ -36,7 +36,7 @@ public:
 
 	//bind to a channel
 	int Bind(const char* ip, int port, int channel = -1);
-	int Bind(IPaddress add, int channel = -1);
+	int Bind(IPaddress* add, int channel = -1);
 	void Unbind(int channel);
 
 	IPaddress* GetIPAddress(int channel) {
@@ -45,17 +45,17 @@ public:
 
 	//send a buffer
 	int SendTo(const char* ip, int port, void* data, int len);
-	int SendTo(IPaddress add, void* data, int len);
+	int SendTo(IPaddress* add, void* data, int len);
 	int SendTo(int channel, void* data, int len);
 	int SendToAllChannels(void* data, int len);
 	int Receive();
 
-	//send a SerialPacketBase
+	//send a SerialPacket
-	int SendTo(const char* ip, int port, SerialPacketBase* serialPacket);
+	int SendTo(const char* ip, int port, SerialPacket* serialPacket);
-	int SendTo(IPaddress add, SerialPacketBase* serialPacket);
+	int SendTo(IPaddress* add, SerialPacket* serialPacket);
-	int SendTo(int channel, SerialPacketBase* serialPacket);
+	int SendTo(int channel, SerialPacket* serialPacket);
-	int SendToAllChannels(SerialPacketBase* serialPacket);
+	int SendToAllChannels(SerialPacket* serialPacket);
-	int Receive(SerialPacketBase* serialPacket);
+	int Receive(SerialPacket* serialPacket);
 
 	//accessors
 	UDPpacket* GetPacket() const {

common/utilities/config_utility.cpp

@@ -22,61 +22,14 @@
 #include "config_utility.hpp"
 
 #include <cstdlib>
-#include <cstring>
 #include <fstream>
-#include <sstream>
 #include <stdexcept>
 
-void ConfigUtility::Load(std::string fname, int argc, char* argv[]) {
+void ConfigUtility::Load(std::string fname) {
 	//clear the stored configuration
 	configMap.clear();
-
+	//pass to the recursive method
-	//use the default file
+	configMap = Read(fname);
-	if (argc < 2) {
-		configMap = Read(fname);
-		return;
-	}
-
-	//some variables to use
-	table_t redirectedFile;
-	table_t cmdLineParams;
-	char key[256], val[256];
-	bool redirectUsed = false;
-
-	//reading from the command line
-	for (int i = 1; i < argc; ++i) {
-		//read from a specified config file
-		if (!strncmp(argv[i], "-config=", 8)) {
-			redirectedFile = Read(argv[i] + 8);
-			redirectUsed = true;
-			continue;
-		}
-
-		//set some specific values
-		if (!strncmp(argv[i], "-", 1)) {
-			//wipe the variables
-			memset(key, 0, 256);
-			memset(key, 0, 256);
-
-			//read the key-value pair
-			if (sscanf(argv[i], "-%[^=]=%[^\0]", key, val) != 2) {
-				std::ostringstream os;
-				os << "Failed to read a command line config argument (expected -%s=%s):" << std::endl;
-				os << "\targv[" << i << "]: " << argv[i] << std::endl;
-				os << "\tkey: " << key << std::endl;
-				os << "\tval: " << val << std::endl;
-				throw(std::runtime_error( os.str() ));
-			}
-			cmdLineParams[key] = val;
-		}
-	}
-
-	//finally, construct the final config table
-	if (!redirectUsed) {
-		redirectedFile = Read(fname);
-	}
-	configMap.insert(cmdLineParams.begin(), cmdLineParams.end());
-	configMap.insert(redirectedFile.begin(), redirectedFile.end());
 }
 
 ConfigUtility::table_t ConfigUtility::Read(std::string fname) {
@@ -85,9 +38,10 @@ ConfigUtility::table_t ConfigUtility::Read(std::string fname) {
 	std::ifstream is(fname);
 
 	if (!is.is_open()) {
-		std::ostringstream os;
+		std::string msg;
-		os << "Failed to open a config file: " << fname;
+		msg += "Failed to open a config file: ";
-		throw(std::runtime_error( os.str() ));
+		msg += fname;
+		throw(std::runtime_error(msg));
 	}
 
 	std::string key, val;
@@ -115,23 +69,15 @@ ConfigUtility::table_t ConfigUtility::Read(std::string fname) {
 		getline(is, key,'=');
 		getline(is, val);
 
-		//eat the whitespace at the start & end
+		//trim the strings at the start & end
-		while(key.size() && isspace( *key.begin() )) {
+		while(key.size() && isspace(*key.begin())) key.erase(0, 1);
-			key.erase(0, 1);
+		while(val.size() && isspace(*val.begin())) val.erase(0, 1);
-		}
-		while(val.size() && isspace( *val.begin() )) {
-			val.erase(0, 1);
-		}
 
-		while(key.size() && isspace( *(key.end()-1) )) {
+		while(key.size() && isspace(*(key.end()-1))) key.erase(key.end() - 1);
-			key.erase(key.end() - 1);
+		while(val.size() && isspace(*(val.end()-1))) val.erase(val.end() - 1);
-		}
-		while(val.size() && isspace( *(val.end()-1) )) {
-			val.erase(val.end() - 1);
-		}
 
-		//disallow empty/wiped pairs
+		//disallow empty/wiped values
-		if (key.size() == 0 || val.size() == 0) {
+		if (key.size() == 0) {
 			continue;
 		}
 
@@ -142,6 +88,7 @@ ConfigUtility::table_t ConfigUtility::Read(std::string fname) {
 	is.close();
 
 	//load in any subordinate config files
+	//TODO: Possibility of nesting config levels?
 	if (retTable.find("config.next") != retTable.end()) {
 		table_t subTable = Read(retTable["config.next"]);
 		retTable.insert(subTable.begin(), subTable.end());

common/utilities/config_utility.hpp

@@ -29,7 +29,7 @@
 
 class ConfigUtility : public Singleton<ConfigUtility> {
 public:
-	void Load(std::string fname, int argc = 0, char* argv[] = nullptr);
+	void Load(std::string fname);
 
 	//convert to a type
 	std::string& String(std::string);

common/utilities/singleton.hpp

@@ -33,13 +33,13 @@ public:
 		}
 		return *ptr;
 	}
-	static void CreateSingleton() {
+	static void Create() {
 		if (ptr) {
 			throw(std::logic_error("This singleton has already been created"));
 		}
 		ptr = new T();
 	}
-	static void DeleteSingleton() {
+	static void Delete() {
 		if (!ptr) {
 			throw(std::logic_error("A non-existant singleton cannot be deleted"));
 		}

common/utilities/sql_utility.cpp

@@ -19,7 +19,7 @@
  * 3. This notice may not be removed or altered from any source
  * distribution.
 */
-#include "sql_tools.hpp"
+#include "sql_utility.hpp"
 
 #include "utility.hpp"
 

rsc/scripts/map_maker.lua

@@ -1,37 +0,0 @@
-local mapMaker = {}
-
---utility functions
-function mapMaker.sqr(x) return x*x end
-function mapMaker.dist(x, y, i, j) return math.sqrt(mapMaker.sqr(x - i) + mapMaker.sqr(y - j)) end
-
---tile macros, mapped to the tilesheet "overworld.bmp"
-mapMaker.edges = {}
-mapMaker.edges.north = -16
-mapMaker.edges.south = 16
-mapMaker.edges.east = 1
-mapMaker.edges.west = -1
-
-mapMaker.water	= 18 + 3 * 0
-mapMaker.sand	= 18 + 3 * 1
-mapMaker.plains	= 18 + 3 * 2
-mapMaker.grass	= 18 + 3 * 3
-mapMaker.dirt	= 18 + 3 * 4
-
---custom generation systems here
-function mapMaker.debugIsland(region)
-	for i = 1, Region.GetWidth(region) do
-		for j = 1, Region.GetHeight(region) do
-			local dist = mapMaker.dist(0, 0, i + Region.GetX(region) -1, j + Region.GetY(region) -1)
-			if dist < 10 then
-				Region.SetTile(region, i, j, 1, mapMaker.plains)
-			elseif dist < 12 then
-				Region.SetTile(region, i, j, 1, mapMaker.sand)
-			else
-				Region.SetTile(region, i, j, 1, mapMaker.water)
-				Region.SetSolid(region, i, j, true)
-			end
-		end
-	end
-end
-
-return mapMaker

rsc/scripts/setup_server.lua

@@ -1,12 +1,52 @@
 print("Lua script check")
 
-mapMaker = require "map_maker"
+--uber lazy declarations
-mapSaver = require "map_saver"
+function math.sqr(x) return x*x end
+function math.dist(x, y, i, j) return math.sqrt(math.sqr(x - i) + math.sqr(y - j)) end
 
---BUG: #35 The server fails without at least one room
+--tile macros, mapped to the tilesheet
+local base = 14
+local shift = 36
+tiles = {
+	plains	= base + shift * 0,
+	grass	= base + shift * 1,
+	dirt	= base + shift * 2,
+	sand	= base + shift * 3,
+	water	= base + shift * 4
+}
+
+--custom generation systems here
+function islandGenerator(region)
+	io.write("Generating (", Region.GetX(region), ", ", Region.GetY(region), ")\n")
+	for i = 1, Region.GetWidth(region) do
+		for j = 1, Region.GetHeight(region) do
+			local dist = math.dist(0, 0, i + Region.GetX(region) -1, j + Region.GetY(region) -1)
+			if dist < 10 then
+				Region.SetTile(region, i, j, 1, tiles.plains)
+			elseif dist < 12 then
+				Region.SetTile(region, i, j, 1, tiles.sand)
+			else
+				Region.SetTile(region, i, j, 1, tiles.water)
+				Region.SetSolid(region, i, j, true)
+			end
+		end
+	end
+end
+
+--Get some regions
+--BUG: The server fails without at least one room
 --TODO: Create rooms with names?
-newRoom = RoomManager.CreateRoom("overworld", "overworld.bmp")
+newRoom = RoomManager.CreateRoom()
 pager = Room.GetPager(newRoom)
-RegionPager.SetOnCreate(pager, mapMaker.debugIsland)
+RegionPager.SetOnCreate(pager, islandGenerator)
+
+--[[
+regionTable = {
+	RegionPager.GetRegion(pager, Region.GetWidth() * 0, Region.GetHeight() * 0),
+	RegionPager.GetRegion(pager, Region.GetWidth() *-1, Region.GetHeight() * 0),
+	RegionPager.GetRegion(pager, Region.GetWidth() * 0, Region.GetHeight() *-1),
+	RegionPager.GetRegion(pager, Region.GetWidth() *-1, Region.GetHeight() *-1)
+}
+]]
 
 print("Finished the lua script")

rsc/scripts/setup_server.sql

@@ -1,51 +1,33 @@
+--TODO: why is the database setup script scripted, while accessing, etc. hardcoded?
+--there should be a way to control the database more directly
+--TODO: move this script into a hardocded Init() method?
+
 CREATE TABLE IF NOT EXISTS Accounts (
-	uid			INTEGER PRIMARY KEY AUTOINCREMENT,
+	uid INTEGER PRIMARY KEY AUTOINCREMENT,
-	username	varchar(100) UNIQUE,
+	username varchar(100) UNIQUE,
-
 	--TODO: server-client security
---	passhash	varchar(100),
+--	password varchar(100),
---	passsalt	varchar(100),
+	blacklisted BIT DEFAULT 0,
-
+	whitelisted BIT DEFAULT 1,
-	--server controls
+	mod BIT DEFAULT 0,
-	blacklisted	BIT DEFAULT 0,
+	admin BIT DEFAULT 0
-	whitelisted	BIT DEFAULT 1,
-	mod			BIT DEFAULT 0,
-	admin		BIT DEFAULT 0
 );
 
 CREATE TABLE IF NOT EXISTS Characters (
-	uid			INTEGER PRIMARY KEY AUTOINCREMENT,
+	uid INTEGER PRIMARY KEY AUTOINCREMENT,
 
 	--metadata
-	owner		INTEGER REFERENCES Accounts(uid),
+	owner INTEGER REFERENCES Accounts(uid),
-	handle		varchar(100) UNIQUE,
+	handle varchar(100) UNIQUE,
-	avatar		varchar(100),
+	avatar varchar(100),
-	birth		timestamp NOT NULL DEFAULT (datetime()),
+	birth timestamp NOT NULL DEFAULT (datetime()),
 
-	--position in the world
+	--position
 	roomIndex	INTEGER DEFAULT 0,
 	originX		INTEGER DEFAULT 0,
 	originY		INTEGER DEFAULT 0,
 
 	--statistics
-	baseStats	INTEGER REFERENCES StatisticSets(uid),
-
-	--equipment
-	weapon		INTEGER REFERENCES WornEquipment(uid),
-	helmet		INTEGER REFERENCES WornEquipment(uid),
-	armour		INTEGER REFERENCES WornEquipment(uid)
-	--etc.
-);
-
--------------------------
---Utility tables
--------------------------
-
-CREATE TABLE IF NOT EXISTS StatisticSets (
-	--metadata
-	uid				INTEGER PRIMARY KEY AUTOINCREMENT,
-
-	--general use statistics
 	level			INTEGER DEFAULT 0,
 	exp				INTEGER DEFAULT 0,
 	maxHP			INTEGER DEFAULT 0,
@@ -59,45 +41,28 @@ CREATE TABLE IF NOT EXISTS StatisticSets (
 	speed			INTEGER DEFAULT 0,
 	accuracy		REAL DEFAULT 0.0,
 	evasion			REAL DEFAULT 0.0,
-	luck			REAL DEFAULT 0.0
+	luck			REAL DEFAULT 0.0,
-);
 
-CREATE TABLE IF NOT EXISTS InWorldItems (
+	--equipment
-	--metadata
+	weapon INTEGER REFERENCES WornEquipment(uid),
-	uid			INTEGER PRIMARY KEY AUTOINCREMENT,
+	helmet INTEGER REFERENCES WornEquipment(uid),
-	itemType	INTEGER,
+	armour INTEGER REFERENCES WornEquipment(uid)
-
+	--etc.
-	--position in the world
-	roomIndex	INTEGER DEFAULT 0,
-	originX		INTEGER DEFAULT 0,
-	originY		INTEGER DEFAULT 0,
-
-	--unique information
-	stackSize	INTEGER DEFAULT 0,
-	durability	INTEGER DEFAULT 0,
-	stats		INTEGER REFERENCES StatisticSets(uid)
 );
 
 CREATE TABLE IF NOT EXISTS InventoryItems (
 	--metadata
-	uid			INTEGER PRIMARY KEY AUTOINCREMENT,
+	uid INTEGER PRIMARY KEY AUTOINCREMENT,
-	owner		INTEGER REFERENCES Characters(uid),
+	itemID INTEGER, --type
-	itemType	INTEGER,
+	stackSize INTEGER DEFAULT 0,
-
+	owner INTEGER REFERENCES Characters(uid)
-	--unique information
-	stackSize	INTEGER DEFAULT 0,
-	durability	INTEGER DEFAULT 0,
-	stats		INTEGER REFERENCES StatisticSets(uid)
 );
 
 CREATE TABLE IF NOT EXISTS WornEquipment (
 	--metadata
-	uid			INTEGER PRIMARY KEY AUTOINCREMENT,
+	uid INTEGER PRIMARY KEY AUTOINCREMENT,
-	owner		INTEGER REFERENCES Characters(uid),
+	itemID INTEGER, --type
-	itemType	INTEGER,
+	owner INTEGER REFERENCES Characters(uid)
-
+	--hold all equipment info
-	--unique information
+	--stat mods, special effects, etc.
-	durability	INTEGER DEFAULT 0,
-	stats		INTEGER REFERENCES StatisticSets(uid)
-	--TODO: attached script?
 );

server/accounts/account_manager.cpp

@@ -31,13 +31,12 @@ static const char* CREATE_USER_ACCOUNT = "INSERT INTO Accounts (username) VALUES
 static const char* LOAD_USER_ACCOUNT = "SELECT * FROM Accounts WHERE username = ?;";
 static const char* SAVE_USER_ACCOUNT = "UPDATE OR FAIL Accounts SET blacklisted = ?2, whitelisted = ?3, mod = ?4, admin = ?5 WHERE uid = ?1;";
 static const char* DELETE_USER_ACCOUNT = "DELETE FROM Accounts WHERE uid = ?;";
-static const char* COUNT_USER_ACCOUNT_RECORDS = "SELECT COUNT(*) FROM Accounts;";
 
 //-------------------------
 //Define the public methods
 //-------------------------
 
-int AccountManager::Create(std::string username, int clientIndex) {
+int AccountManager::CreateAccount(std::string username, int clientIndex) {
 	//create this user account, failing if it exists, leave this account in memory
 	sqlite3_stmt* statement = nullptr;
 
@@ -61,10 +60,10 @@ int AccountManager::Create(std::string username, int clientIndex) {
 	sqlite3_finalize(statement);
 
 	//load this account into memory
-	return Load(username, clientIndex);
+	return LoadAccount(username, clientIndex);
 }
 
-int AccountManager::Load(std::string username, int clientIndex) {
+int AccountManager::LoadAccount(std::string username, int clientIndex) {
 	//load this user account, failing if it is in memory, creating it if it doesn't exist
 	sqlite3_stmt* statement = nullptr;
 
@@ -87,13 +86,13 @@ int AccountManager::Load(std::string username, int clientIndex) {
 		int uid = sqlite3_column_int(statement, 0);
 
 		//check to see if this account is already loaded
-		if (elementMap.find(uid) != elementMap.end()) {
+		if (accountMap.find(uid) != accountMap.end()) {
 			sqlite3_finalize(statement);
 			return -1;
 		}
 
 		//extract the data into memory
-		AccountData& newAccount = elementMap[uid];
+		AccountData& newAccount = accountMap[uid];
 		newAccount.username = reinterpret_cast<const char*>(sqlite3_column_text(statement, 1));
 		newAccount.blackListed = sqlite3_column_int(statement, 2);
 		newAccount.whiteListed = sqlite3_column_int(statement, 3);
@@ -110,22 +109,22 @@ int AccountManager::Load(std::string username, int clientIndex) {
 
 	if (ret == SQLITE_DONE) {
 		//create the non-existant account instead
-		return Create(username, clientIndex);
+		return CreateAccount(username, clientIndex);
 	}
 
 	throw(std::runtime_error(std::string() + "Unknown SQL error in LoadAccount: " + sqlite3_errmsg(database) ));
 }
 
-int AccountManager::Save(int uid) {
+int AccountManager::SaveAccount(int uid) {
 	//save this user account from memory, replacing it if it exists in the database
 	//DOCS: To use this method, change the in-memory copy, and then call this function using that object's UID.
 
 	//this method fails if this account is not loaded
-	if (elementMap.find(uid) == elementMap.end()) {
+	if (accountMap.find(uid) == accountMap.end()) {
 		return -1;
 	}
 
-	AccountData& account = elementMap[uid];
+	AccountData& account = accountMap[uid];
 	sqlite3_stmt* statement = nullptr;
 
 	//prep
@@ -159,14 +158,14 @@ int AccountManager::Save(int uid) {
 	return 0;
 }
 
-void AccountManager::Unload(int uid) {
+void AccountManager::UnloadAccount(int uid) {
 	//save this user account, and then unload it
 	//NOTE: the associated characters are unloaded externally
-	Save(uid);
+	SaveAccount(uid);
-	elementMap.erase(uid);
+	accountMap.erase(uid);
 }
 
-void AccountManager::Delete(int uid) {
+void AccountManager::DeleteAccount(int uid) {
 	//delete a user account from the database, and remove it from memory
 	//NOTE: the associated characters should be deleted externally
 	sqlite3_stmt* statement = nullptr;
@@ -190,69 +189,32 @@ void AccountManager::Delete(int uid) {
 
 	//finish the routine
 	sqlite3_finalize(statement);
-	elementMap.erase(uid);
+	accountMap.erase(uid);
 }
 
 void AccountManager::UnloadAll() {
-	for (auto& it : elementMap) {
+	for (auto& it : accountMap) {
-		Save(it.first);
+		SaveAccount(it.first);
-	}
-	elementMap.clear();
-}
-
-void AccountManager::UnloadIf(std::function<bool(std::pair<const int, AccountData>)> fn) {
-	//replicate std::remove_if, using custom code
-	std::map<int, AccountData>::iterator it = elementMap.begin();
-	while (it != elementMap.end()) {
-		if (fn(*it)) {
-			Save(it->first);
-			it = elementMap.erase(it);
-		}
-		else {
-			++it;
-		}
 	}
+	accountMap.clear();
 }
 
 //-------------------------
 //Define the accessors and mutators
 //-------------------------
 
-AccountData* AccountManager::Get(int uid) {
+AccountData* AccountManager::GetAccount(int uid) {
-	//TODO: could this load an account first?
+	std::map<int, AccountData>::iterator it = accountMap.find(uid);
-	std::map<int, AccountData>::iterator it = elementMap.find(uid);
 
-	if (it == elementMap.end()) {
+	if (it == accountMap.end()) {
 		return nullptr;
 	}
 
 	return &it->second;
 }
 
-int AccountManager::GetLoadedCount() {
-	return elementMap.size();
-}
-
-int AccountManager::GetTotalCount() {
-	//a lot just to count something.
-	sqlite3_stmt* statement = nullptr;
-
-	//prep
-	if (sqlite3_prepare_v2(database, COUNT_USER_ACCOUNT_RECORDS, -1, &statement, nullptr) != SQLITE_OK) {
-		throw( std::runtime_error(std::string() + "Failed to prepare an SQL statement: " + sqlite3_errmsg(database)) );
-	}
-
-	//execute & retrieve the result
-	sqlite3_step(statement);
-	int ret = sqlite3_column_int(statement, 0);
-
-	//finish the routine
-	sqlite3_finalize(statement);
-	return ret;
-}
-
 std::map<int, AccountData>* AccountManager::GetContainer() {
-	return &elementMap;
+	return &accountMap;
 }
 
 sqlite3* AccountManager::SetDatabase(sqlite3* db) {

server/accounts/account_manager.hpp

@@ -24,33 +24,25 @@
 
 #include "account_data.hpp"
 #include "singleton.hpp"
-#include "manager_interface.hpp"
 
 #include "sqlite3/sqlite3.h"
 
-#include <functional>
 #include <map>
 
-class AccountManager:
+class AccountManager : public Singleton<AccountManager> {
-	public Singleton<AccountManager>,
-	public ManagerInterface<AccountData, std::string, int>
-{
 public:
-	//common public methods
+	//public access methods
-	int Create(std::string username, int clientIndex) override;
+	int CreateAccount(std::string username, int clientIndex);
-	int Load(std::string username, int clientIndex) override;
+	int LoadAccount(std::string username, int clientIndex);
-	int Save(int uid) override;
+	int SaveAccount(int uid);
-	void Unload(int uid) override;
+	void UnloadAccount(int uid);
-	void Delete(int uid) override;
+	void DeleteAccount(int uid);
 
-	void UnloadAll() override;
+	void UnloadAll();
-	void UnloadIf(std::function<bool(std::pair<const int, AccountData>)> fn) override;
 
 	//accessors and mutators
-	AccountData* Get(int uid) override;
+	AccountData* GetAccount(int uid);
-	int GetLoadedCount() override;
+	std::map<int, AccountData>* GetContainer();
-	int GetTotalCount() override;
-	std::map<int, AccountData>* GetContainer() override;
 
 	sqlite3* SetDatabase(sqlite3* db);
 	sqlite3* GetDatabase();
@@ -61,6 +53,7 @@ private:
 	AccountManager() = default;
 	~AccountManager() = default;
 
+	std::map<int, AccountData> accountMap;
 	sqlite3* database = nullptr;
 };
 

server/accounts/makefile

@@ -1,5 +1,5 @@
 #config
-INCLUDES+=. ../server_utilities ../../common/utilities
+INCLUDES+=. ../../common/utilities
 LIBS+=
 CXXFLAGS+=-std=c++11 $(addprefix -I,$(INCLUDES))
 

server/characters/character_manager.cpp

@@ -23,7 +23,6 @@
 
 #include "sqlite3/sqlite3.h"
 
-#include <algorithm>
 #include <stdexcept>
 
 //-------------------------
@@ -32,16 +31,35 @@
 
 static const char* CREATE_CHARACTER = "INSERT INTO Characters (owner, handle, avatar) VALUES (?, ?, ?);";
 static const char* LOAD_CHARACTER = "SELECT * FROM Characters WHERE handle = ?;";
-static const char* SAVE_CHARACTER = "UPDATE OR FAIL Characters SET roomIndex = ?2, originX = ?3, originY = ?4 WHERE uid = ?1;";
+
+static const char* SAVE_CHARACTER = "UPDATE OR FAIL Characters SET "
+	"roomIndex = ?2,"
+	"originX = ?3,"
+	"originY = ?4,"
+	"level = ?5,"
+	"exp = ?6,"
+	"maxHP = ?7,"
+	"health = ?8,"
+	"maxMP = ?9,"
+	"mana = ?10,"
+	"attack = ?11,"
+	"defence = ?12,"
+	"intelligence = ?13,"
+	"resistance = ?14,"
+	"speed = ?15,"
+	"accuracy = ?16,"
+	"evasion = ?17,"
+	"luck = ?18"
+" WHERE uid = ?1;";
+
 static const char* DELETE_CHARACTER = "DELETE FROM Characters WHERE uid = ?;";
-static const char* COUNT_CHARACTER_RECORDS = "SELECT COUNT(*) FROM Characters;";
 
 //-------------------------
 //Define the methods
 //-------------------------
 
 //NOTE: default baseStats as a parameter would be good for different beggining states or multiple classes
-int CharacterManager::Create(int owner, std::string handle, std::string avatar) {
+int CharacterManager::CreateCharacter(int owner, std::string handle, std::string avatar) {
 	//Create the character, failing if it exists
 	sqlite3_stmt* statement = nullptr;
 
@@ -71,10 +89,10 @@ int CharacterManager::Create(int owner, std::string handle, std::string avatar)
 	sqlite3_finalize(statement);
 
 	//load this character into memory
-	return Load(owner, handle, avatar);
+	return LoadCharacter(owner, handle, avatar);
 }
 
-int CharacterManager::Load(int owner, std::string handle, std::string avatar) {
+int CharacterManager::LoadCharacter(int owner, std::string handle, std::string avatar) {
 	//load the specified character, creating it if it doesn't exist
 	//fail if it is already loaded, or does not belong to this account
 	sqlite3_stmt* statement = nullptr;
@@ -98,7 +116,7 @@ int CharacterManager::Load(int owner, std::string handle, std::string avatar) {
 		int uid = sqlite3_column_int(statement, 0);
 
 		//check to see if this character is already loaded
-		if (elementMap.find(uid) != elementMap.end()) {
+		if (characterMap.find(uid) != characterMap.end()) {
 			sqlite3_finalize(statement);
 			return -1;
 		}
@@ -110,7 +128,7 @@ int CharacterManager::Load(int owner, std::string handle, std::string avatar) {
 		}
 
 		//extract the data into memory
-		CharacterData& newChar = elementMap[uid];
+		CharacterData& newChar = characterMap[uid];
 
 		//metadata
 		newChar.owner = owner;
@@ -123,7 +141,23 @@ int CharacterManager::Load(int owner, std::string handle, std::string avatar) {
 		newChar.origin.x = (double)sqlite3_column_int(statement, 6);
 		newChar.origin.y = (double)sqlite3_column_int(statement, 7);
 
-		//gameplay components: equipment, items, buffs, debuffs...
+		//statistics
+		newChar.baseStats.level = sqlite3_column_int(statement, 8);
+		newChar.baseStats.exp = sqlite3_column_int(statement, 9);
+		newChar.baseStats.maxHP = sqlite3_column_int(statement, 10);
+		newChar.baseStats.health = sqlite3_column_int(statement, 11);
+		newChar.baseStats.maxMP = sqlite3_column_int(statement, 12);
+		newChar.baseStats.mana = sqlite3_column_int(statement, 13);
+		newChar.baseStats.attack = sqlite3_column_int(statement, 14);
+		newChar.baseStats.defence = sqlite3_column_int(statement, 15);
+		newChar.baseStats.intelligence = sqlite3_column_int(statement, 16);
+		newChar.baseStats.resistance = sqlite3_column_int(statement, 17);
+		newChar.baseStats.speed = sqlite3_column_int(statement, 18);
+		newChar.baseStats.accuracy = sqlite3_column_double(statement, 19);
+		newChar.baseStats.evasion = sqlite3_column_double(statement, 20);
+		newChar.baseStats.luck = sqlite3_column_double(statement, 21);
+
+		//TODO: gameplay components: equipment, items, buffs, debuffs
 
 		//finish the routine
 		sqlite3_finalize(statement);
@@ -134,22 +168,22 @@ int CharacterManager::Load(int owner, std::string handle, std::string avatar) {
 
 	if (ret == SQLITE_DONE) {
 		//create the non-existant character instead
-		return Create(owner, handle, avatar);
+		return CreateCharacter(owner, handle, avatar);
 	}
 
 	throw(std::runtime_error(std::string() + "Unknown SQL error in LoadCharacter: " + sqlite3_errmsg(database) ));
 }
 
-int CharacterManager::Save(int uid) {
+int CharacterManager::SaveCharacter(int uid) {
 	//save this character from memory, replacing it if it exists in the database
 	//DOCS: To use this method, change the in-memory copy, and then call this function using that object's UID.
 
 	//this method fails if this character is not loaded
-	if (elementMap.find(uid) == elementMap.end()) {
+	if (characterMap.find(uid) == characterMap.end()) {
 		return -1;
 	}
 
-	CharacterData& character = elementMap[uid];
+	CharacterData& character = characterMap[uid];
 	sqlite3_stmt* statement = nullptr;
 
 	//prep
@@ -164,7 +198,23 @@ int CharacterManager::Save(int uid) {
 	ret |= sqlite3_bind_int(statement, 3, (int)character.origin.x) != SQLITE_OK;
 	ret |= sqlite3_bind_int(statement, 4, (int)character.origin.y) != SQLITE_OK;
 
-	//gameplay components: equipment, items, buffs, debuffs...
+	//statistics
+	ret |= sqlite3_bind_int(statement, 5, character.baseStats.level) != SQLITE_OK;
+	ret |= sqlite3_bind_int(statement, 6, character.baseStats.exp) != SQLITE_OK;
+	ret |= sqlite3_bind_int(statement, 7, character.baseStats.maxHP) != SQLITE_OK;
+	ret |= sqlite3_bind_int(statement, 8, character.baseStats.health) != SQLITE_OK;
+	ret |= sqlite3_bind_int(statement, 9, character.baseStats.maxMP) != SQLITE_OK;
+	ret |= sqlite3_bind_int(statement, 10, character.baseStats.mana) != SQLITE_OK;
+	ret |= sqlite3_bind_int(statement, 11, character.baseStats.attack) != SQLITE_OK;
+	ret |= sqlite3_bind_int(statement, 12, character.baseStats.defence) != SQLITE_OK;
+	ret |= sqlite3_bind_int(statement, 13, character.baseStats.intelligence) != SQLITE_OK;
+	ret |= sqlite3_bind_int(statement, 14, character.baseStats.resistance) != SQLITE_OK;
+	ret |= sqlite3_bind_int(statement, 15, character.baseStats.speed) != SQLITE_OK;
+	ret |= sqlite3_bind_double(statement, 16, character.baseStats.accuracy) != SQLITE_OK;
+	ret |= sqlite3_bind_double(statement, 17, character.baseStats.evasion) != SQLITE_OK;
+	ret |= sqlite3_bind_double(statement, 18, character.baseStats.luck) != SQLITE_OK;
+
+	//TODO: gameplay components: equipment, items, buffs, debuffs
 
 	//check for binding errors
 	if (ret) {
@@ -175,7 +225,7 @@ int CharacterManager::Save(int uid) {
 	if (sqlite3_step(statement) != SQLITE_DONE) {
 		//if this fails, than something went horribly wrong
 		sqlite3_finalize(statement);
-		throw( std::runtime_error(std::string() + "Unknown SQL error when saving a character: " + sqlite3_errmsg(database)) );
+		throw( std::runtime_error(std::string() + "Unknown SQL error when saving an account: " + sqlite3_errmsg(database)) );
 	}
 
 	sqlite3_finalize(statement);
@@ -184,13 +234,13 @@ int CharacterManager::Save(int uid) {
 	return 0;
 }
 
-void CharacterManager::Unload(int uid) {
+void CharacterManager::UnloadCharacter(int uid) {
 	//save this character, then unload it
-	Save(uid);
+	SaveCharacter(uid);
-	elementMap.erase(uid);
+	characterMap.erase(uid);
 }
 
-void CharacterManager::Delete(int uid) {
+void CharacterManager::DeleteCharacter(int uid) {
 	//delete this character from the database, then remove it from memory
 	sqlite3_stmt* statement = nullptr;
 
@@ -208,72 +258,49 @@ void CharacterManager::Delete(int uid) {
 	if (sqlite3_step(statement) != SQLITE_DONE) {
 		//if this fails, than something went horribly wrong
 		sqlite3_finalize(statement);
-		throw( std::runtime_error(std::string() + "Unknown SQL error when deleting a character: " + sqlite3_errmsg(database)) );
+		throw( std::runtime_error(std::string() + "Unknown SQL error when deleting an account: " + sqlite3_errmsg(database)) );
 	}
 
 	//finish the routine
 	sqlite3_finalize(statement);
-	elementMap.erase(uid);
+	characterMap.erase(uid);
+}
+
+void CharacterManager::UnloadCharacterIf(std::function<bool(std::map<int, CharacterData>::iterator)> f) {
+	//save this character, then unload it if the parameter returns true
+	for (std::map<int, CharacterData>::iterator it = characterMap.begin(); it != characterMap.end(); /* EMPTY */ ) {
+		if (f(it)) {
+			SaveCharacter(it->first);
+			it = characterMap.erase(it);
+			continue;
+		}
+		it++;
+	}
 }
 
 void CharacterManager::UnloadAll() {
-	for (auto& it : elementMap) {
+	for (auto& it : characterMap) {
-		Save(it.first);
+		SaveCharacter(it.first);
-	}
-	elementMap.clear();
-}
-
-void CharacterManager::UnloadIf(std::function<bool(std::pair<const int, CharacterData>)> fn) {
-	std::map<int, CharacterData>::iterator it = elementMap.begin();
-	while (it != elementMap.end()) {
-		if (fn(*it)) {
-			Save(it->first);
-			it = elementMap.erase(it);
-		}
-		else {
-			++it;
-		}
 	}
+	characterMap.clear();
 }
 
 //-------------------------
 //Define the accessors and mutators
 //-------------------------
 
-CharacterData* CharacterManager::Get(int uid) {
+CharacterData* CharacterManager::GetCharacter(int uid) {
-	std::map<int, CharacterData>::iterator it = elementMap.find(uid);
+	std::map<int, CharacterData>::iterator it = characterMap.find(uid);
 
-	if (it == elementMap.end()) {
+	if (it == characterMap.end()) {
 		return nullptr;
 	}
 
 	return &it->second;
 }
 
-int CharacterManager::GetLoadedCount() {
-	return elementMap.size();
-}
-
-int CharacterManager::GetTotalCount() {
-	//a lot just to count something.
-	sqlite3_stmt* statement = nullptr;
-
-	//prep
-	if (sqlite3_prepare_v2(database, COUNT_CHARACTER_RECORDS, -1, &statement, nullptr) != SQLITE_OK) {
-		throw( std::runtime_error(std::string() + "Failed to prepare an SQL statement: " + sqlite3_errmsg(database)) );
-	}
-
-	//execute & retrieve the result
-	sqlite3_step(statement);
-	int ret = sqlite3_column_int(statement, 0);
-
-	//finish the routine
-	sqlite3_finalize(statement);
-	return ret;
-}
-
 std::map<int, CharacterData>* CharacterManager::GetContainer() {
-	return &elementMap;
+	return &characterMap;
 }
 
 sqlite3* CharacterManager::SetDatabase(sqlite3* db) {

server/characters/character_manager.hpp

@@ -24,33 +24,28 @@
 
 #include "character_data.hpp"
 #include "singleton.hpp"
-#include "manager_interface.hpp"
 
 #include "sqlite3/sqlite3.h"
 
-#include <functional>
 #include <map>
+#include <functional>
 
-class CharacterManager:
+class CharacterManager : public Singleton<CharacterManager> {
-	public Singleton<CharacterManager>,
-	public ManagerInterface<CharacterData, int, std::string, std::string>
-{
 public:
-	//common public methods
+	//public access methods
-	int Create(int owner, std::string handle, std::string avatar) override;
+	int CreateCharacter(int owner, std::string handle, std::string avatar);
-	int Load(int owner, std::string handle, std::string avatar) override;
+	int LoadCharacter(int owner, std::string handle, std::string avatar);
-	int Save(int uid) override;
+	int SaveCharacter(int uid);
-	void Unload(int uid) override;
+	void UnloadCharacter(int uid);
-	void Delete(int uid) override;
+	void DeleteCharacter(int uid);
 
-	void UnloadAll() override;
+	void UnloadCharacterIf(std::function<bool(std::map<int, CharacterData>::iterator)> f);
-	void UnloadIf(std::function<bool(std::pair<const int, CharacterData>)> fn) override;
+
+	void UnloadAll();
 
 	//accessors and mutators
-	CharacterData* Get(int uid) override;
+	CharacterData* GetCharacter(int uid);
-	int GetLoadedCount() override;
+	std::map<int, CharacterData>* GetContainer();
-	int GetTotalCount() override;
-	std::map<int, CharacterData>* GetContainer() override;
 
 	sqlite3* SetDatabase(sqlite3* db);
 	sqlite3* GetDatabase();
@@ -61,6 +56,7 @@ private:
 	CharacterManager() = default;
 	~CharacterManager() = default;
 
+	std::map<int, CharacterData> characterMap;
 	sqlite3* database = nullptr;
 };
 

server/characters/makefile

@@ -1,5 +1,5 @@
 #config
-INCLUDES+=. ../server_utilities ../../common/gameplay ../../common/utilities
+INCLUDES+=. ../../common/gameplay ../../common/utilities
 LIBS+=
 CXXFLAGS+=-std=c++11 $(addprefix -I,$(INCLUDES))
 

server/client_data.cpp

@@ -1,32 +0,0 @@
-/* Copyright: (c) Kayne Ruse 2014
- * 
- * This software is provided 'as-is', without any express or implied
- * warranty. In no event will the authors be held liable for any damages
- * arising from the use of this software.
- * 
- * Permission is granted to anyone to use this software for any purpose,
- * including commercial applications, and to alter it and redistribute it
- * freely, subject to the following restrictions:
- * 
- * 1. The origin of this software must not be misrepresented; you must not
- * claim that you wrote the original software. If you use this software
- * in a product, an acknowledgment in the product documentation would be
- * appreciated but is not required.
- * 
- * 2. Altered source versions must be plainly marked as such, and must not be
- * misrepresented as being the original software.
- * 
- * 3. This notice may not be removed or altered from any source
- * distribution.
-*/
-#include "client_data.hpp"
-
-int ClientData::IncrementAttempts() {
-	lastBeat = Clock::now();
-	return attemptedBeats++;
-}
-
-int ClientData::ResetAttempts() {
-	lastBeat = Clock::now();
-	return attemptedBeats = 0;
-}

server/client_data.hpp

@@ -24,31 +24,9 @@
 
 #include "SDL/SDL_net.h"
 
-#include <chrono>
+struct ClientData {
-
-//TODO: ClientManager?
-class ClientData {
-public:
-	typedef std::chrono::steady_clock Clock;
-
-	ClientData() = default;
-	ClientData(IPaddress add): address(add) {}
-	~ClientData() = default;
-
-	IPaddress SetAddress(IPaddress add) { return address = add; }
-	IPaddress GetAddress() { return address; }
-
-	Clock::time_point GetLastBeat() { return lastBeat; }
-
-	int GetAttempts() { return attemptedBeats; }
-	int IncrementAttempts();
-	int ResetAttempts();
-
-private:
 	IPaddress address = {0,0};
-
+	//TODO: ping system?
-	Clock::time_point lastBeat = Clock::now();
-	int attemptedBeats = 0;
 };
 
 #endif

server/main.cpp

@@ -22,10 +22,7 @@
 #include "server_application.hpp"
 
 //singletons
-#include "account_manager.hpp"
-#include "character_manager.hpp"
 #include "config_utility.hpp"
-#include "room_manager.hpp"
 #include "udp_network_utility.hpp"
 
 #include <stdexcept>
@@ -33,31 +30,31 @@
 
 using namespace std;
 
-int main(int argc, char* argv[]) {
+int main(int argc, char** argv) {
 	try {
 		//create the singletons
-		AccountManager::CreateSingleton();
+		AccountManager::Create();
-		CharacterManager::CreateSingleton();
+		CharacterManager::Create();
-		ConfigUtility::CreateSingleton();
+		ConfigUtility::Create();
-		RoomManager::CreateSingleton();
+		RoomManager::Create();
-		UDPNetworkUtility::CreateSingleton();
+		UDPNetworkUtility::Create();
 
 		//call the server's routines
-		ServerApplication::CreateSingleton();
+		ServerApplication::Create();
 		ServerApplication& app = ServerApplication::GetSingleton();
 
 		app.Init(argc, argv);
 		app.Proc();
 		app.Quit();
 
-		ServerApplication::DeleteSingleton();
+		ServerApplication::Delete();
 
 		//delete the singletons
-		AccountManager::DeleteSingleton();
+		AccountManager::Delete();
-		CharacterManager::DeleteSingleton();
+		CharacterManager::Delete();
-		ConfigUtility::DeleteSingleton();
+		ConfigUtility::Delete();
-		RoomManager::DeleteSingleton();
+		RoomManager::Delete();
-		UDPNetworkUtility::DeleteSingleton();
+		UDPNetworkUtility::Delete();
 	}
 	catch(exception& e) {
 		cerr << "Fatal exception thrown: " << e.what() << endl;

server/makefile

@@ -1,5 +1,5 @@
 #config
-INCLUDES+=. accounts characters rooms server_utilities ../common/debugging ../common/gameplay ../common/map ../common/network ../common/network/packet_types ../common/utilities
+INCLUDES+=. accounts characters rooms ../common/debugging ../common/gameplay ../common/map ../common/network ../common/network/packet_types ../common/utilities
 LIBS+=server.a ../libcommon.a -lSDL_net -lwsock32 -liphlpapi -lmingw32 -lSDLmain -lSDL -llua -lsqlite3
 CXXFLAGS+=-std=c++11 $(addprefix -I,$(INCLUDES))
 
@@ -19,7 +19,6 @@ all: $(OBJ) $(OUT)
 	$(MAKE) -C accounts
 	$(MAKE) -C characters
 	$(MAKE) -C rooms
-	$(MAKE) -C server_utilities
 	$(CXX) $(CXXFLAGS) -o $(OUT) $(OBJ) $(LIBS)
 
 $(OBJ): | $(OBJDIR)

server/rooms/makefile

@@ -1,5 +1,5 @@
 #config
-INCLUDES+=. ../server_utilities ../../common/map ../../common/utilities
+INCLUDES+=. ../../common/map ../../common/utilities
 LIBS+=
 CXXFLAGS+=-std=c++11 $(addprefix -I,$(INCLUDES))
 

server/rooms/room_api.cpp

@@ -29,36 +29,21 @@ static int getPager(lua_State* L) {
 	return 1;
 }
 
-static int setRoomName(lua_State* L) {
+static int create(lua_State* L) {
-	RoomData* room = reinterpret_cast<RoomData*>(lua_touserdata(L, 1));
+	//EMPTY
-	room->SetRoomName(lua_tostring(L, 2));
+	//NOTE: This can be used to set defaults for the pager
 	return 0;
 }
 
-static int getRoomName(lua_State* L) {
+static int unload(lua_State* L) {
-	RoomData* room = reinterpret_cast<RoomData*>(lua_touserdata(L, 1));
+	//EMPTY
-	lua_pushstring(L, room->GetRoomName().c_str());
-	return 1;
-}
-
-static int setTilesetName(lua_State* L) {
-	RoomData* room = reinterpret_cast<RoomData*>(lua_touserdata(L, 1));
-	room->SetTilesetName(lua_tostring(L, 2));
 	return 0;
 }
 
-static int getTilesetName(lua_State* L) {
-	RoomData* room = reinterpret_cast<RoomData*>(lua_touserdata(L, 1));
-	lua_pushstring(L, room->GetTilesetName().c_str());
-	return 1;
-}
-
 static const luaL_Reg roomLib[] = {
 	{"GetPager",getPager},
-	{"SetRoomName", setRoomName},
+	{"Create", create},
-	{"GetRoomName", getRoomName},
+	{"Unload", unload},
-	{"SetTileset", setTilesetName},
-	{"GetTileset", getTilesetName},
 	{nullptr, nullptr}
 };
 

server/rooms/room_data.hpp

@@ -25,8 +25,6 @@
 //map system
 #include "region_pager_lua.hpp"
 
-#include <string>
-
 class RoomData {
 public:
 	RoomData() = default;
@@ -35,21 +33,11 @@ public:
 	//accessors and mutators
 	RegionPagerLua* GetPager() { return &pager; }
 
-	std::string SetRoomName(std::string s) { return roomName = s; }
-	std::string GetRoomName() { return roomName; }
-
-	std::string SetTilesetName(std::string s) { return tilesetName = s; }
-	std::string GetTilesetName() { return tilesetName; }
-
 private:
 	friend class RoomManager;
 
 	//members
 	RegionPagerLua pager;
-	std::string roomName;
-	std::string tilesetName;
-	//TODO: pass the room name & tileset name to the clients
-	//TODO: lua references i.e. create, unload, etc.
 };
 
 #endif

server/rooms/room_manager.cpp

@@ -29,76 +29,78 @@
 //public access methods
 //-------------------------
 
-int RoomManager::Create() {
+int RoomManager::CreateRoom() {
 	//create the room
-	RoomData* newRoom = &elementMap[counter]; //implicitly constructs the element
+	RoomData* newRoom = new RoomData();
-	newRoom->pager.SetLuaState(lua);
+	newRoom->pager.SetLuaState(luaState);
+
+	//register the room
+	roomMap[counter] = newRoom;
+
+	//API hook
+	lua_getglobal(luaState, TORTUGA_ROOM_NAME);
+	lua_getfield(luaState, -1, "Create");
+	lua_pushlightuserdata(luaState, newRoom);
+	if (lua_pcall(luaState, 1, 0, 0) != LUA_OK) {
+		throw(std::runtime_error(std::string() + "Lua error: " + lua_tostring(luaState, -1) ));
+	}
+	lua_pop(luaState, 1);
 
 	//finish the routine
 	return counter++;
 }
 
-int RoomManager::Load() {
+void RoomManager::UnloadRoom(int uid) {
-	//TODO: RoomManager::Load()
-	return -1;
-}
-
-int RoomManager::Save(int uid) {
-	//TODO: RoomManager::Save(uid)
-	return -1;
-}
-
-void RoomManager::Unload(int uid) {
 	//find the room
-	std::map<int, RoomData>::iterator it = elementMap.find(uid);
+	RoomData* room = FindRoom(uid);
-	if (it == elementMap.end()) {
+	if (!room) {
 		return;
 	}
 
+	//API hook
+	lua_getglobal(luaState, TORTUGA_ROOM_NAME);
+	lua_getfield(luaState, -1, "Unload");
+	lua_pushlightuserdata(luaState, room);
+	if (lua_pcall(luaState, 1, 0, 0) != LUA_OK) {
+		throw(std::runtime_error(std::string() + "Lua error: " + lua_tostring(luaState, -1) ));
+	}
+	lua_pop(luaState, 1);
+
 	//free the memory
-	elementMap.erase(uid);
+	delete room;
+	roomMap.erase(uid);
 }
 
-void RoomManager::Delete(int uid) {
+RoomData* RoomManager::GetRoom(int uid) {
-	//TODO: RoomManager::Delete(int uid)
+	return FindRoom(uid);
-	//NOTE: aliased to RoomManager::Unload(int uid)
+	//TODO: expand this to auto-create the room
-	Unload(uid);
+}
+
+RoomData* RoomManager::FindRoom(int uid) {
+	std::map<int, RoomData*>::iterator it = roomMap.find(uid);
+	if (it == roomMap.end()) {
+		return nullptr;
+	}
+	return it->second;
+}
+
+int RoomManager::PushRoom(RoomData* room) {
+	roomMap[counter++] = room;
+	return counter;
 }
 
 void RoomManager::UnloadAll() {
-	elementMap.clear();
+	lua_getglobal(luaState, TORTUGA_ROOM_NAME);
-}
 
-void RoomManager::UnloadIf(std::function<bool(std::pair<const int,RoomData>)> fn) {
+	for (auto& it : roomMap) {
-	std::map<int, RoomData>::iterator it = elementMap.begin();
+		//API hook
-	while (it != elementMap.end()) {
+		lua_getfield(luaState, -1, "Unload");
-		if (fn(*it)) {
+		lua_pushlightuserdata(luaState, it.second);
-			it = elementMap.erase(it);
+		if (lua_pcall(luaState, 1, 0, 0) != LUA_OK) {
-		}
+			throw(std::runtime_error(std::string() + "Lua error: " + lua_tostring(luaState, -1) ));
-		else {
-			++it;
 		}
 	}
-}
+
-
+	lua_pop(luaState, 1);
-RoomData* RoomManager::Get(int uid) {
+	roomMap.clear();
-	std::map<int, RoomData>::iterator it = elementMap.find(uid);
-
-	if (it == elementMap.end()) {
-		return nullptr;
-	}
-
-	return &it->second;
-}
-
-int RoomManager::GetLoadedCount() {
-	return elementMap.size();
-}
-
-int RoomManager::GetTotalCount() {
-	return elementMap.size();
-}
-
-std::map<int, RoomData>* RoomManager::GetContainer() {
-	return &elementMap;
 }

server/rooms/room_manager.hpp

@@ -24,34 +24,28 @@
 
 #include "room_data.hpp"
 #include "singleton.hpp"
-#include "manager_interface.hpp"
 
 #include "lua/lua.hpp"
 
-class RoomManager:
+#include <map>
-	public Singleton<RoomManager>,
-	public ManagerInterface<RoomData>
-{
-public:
-	//common public methods
-	int Create() override;
-	int Load() override;
-	int Save(int uid) override;
-	void Unload(int uid) override;
-	void Delete(int uid) override;
 
-	void UnloadAll() override;
+class RoomManager : public Singleton<RoomManager> {
-	void UnloadIf(std::function<bool(std::pair<const int,RoomData>)> fn) override;
+public:
+	//public access methods
+	int CreateRoom();
+	void UnloadRoom(int uid);
+
+	RoomData* GetRoom(int uid);
+	RoomData* FindRoom(int uid);
+	int PushRoom(RoomData*);
+
+	void UnloadAll();
 
 	//accessors and mutators
-	RoomData* Get(int uid) override;
+	std::map<int, RoomData*>* GetContainer() { return &roomMap; }
-	int GetLoadedCount() override;
-	int GetTotalCount() override;
-	std::map<int, RoomData>* GetContainer() override;
 
-	//hooks
+	lua_State* SetLuaState(lua_State* L) { return luaState = L; }
-	lua_State* SetLuaState(lua_State* L) { return lua = L; }
+	lua_State* GetLuaState() { return luaState; }
-	lua_State* GetLuaState() { return lua; }
 
 private:
 	friend Singleton<RoomManager>;
@@ -59,7 +53,8 @@ private:
 	RoomManager() = default;
 	~RoomManager() = default;
 
-	lua_State* lua = nullptr;
+	std::map<int, RoomData*> roomMap;
+	lua_State* luaState = nullptr;
 	int counter = 0;
 };
 

server/rooms/room_manager_api.cpp

@@ -23,34 +23,34 @@
 
 #include "room_manager.hpp"
 
-int createRoom(lua_State* L) {
+#include <string>
-	//create & get the room
-	RoomManager& roomMgr = RoomManager::GetSingleton();
-	int uid = roomMgr.Create();
-	RoomData* room = roomMgr.Get(uid);
 
-	//setup the room
+static int getRoom(lua_State* L) {
-	//TODO: room parameters only set via lua, fix this
+	//find, push and return the room
-	room->SetRoomName(lua_tostring(L, 1));
+	RoomData* room = RoomManager::GetSingleton().GetRoom(lua_tointeger(L, -2));
-	room->SetTilesetName(lua_tostring(L, 2));
+	lua_pushlightuserdata(L, reinterpret_cast<void*>(room));
-
+	return 1;
-	//return room, uid
-	lua_pushlightuserdata(L, static_cast<void*>(room));
-	lua_pushinteger(L, uid);
-
-	return 2;
 }
 
-int unloadRoom(lua_State* L) {
+static int createRoom(lua_State* L) {
-	//TODO: check authorization for room deletion
+	//TODO: check parameter count for the glue functions
-	RoomManager& roomMgr = RoomManager::GetSingleton();
+
-	roomMgr.Unload(lua_tointeger(L, 1));
+	//create, find and return the room
+	int uid = RoomManager::GetSingleton().CreateRoom();
+	lua_pushlightuserdata(L, RoomManager::GetSingleton().FindRoom(uid));
+	return 1;
+}
+
+static int unloadRoom(lua_State* L) {
+	//unload the specified room
+	RoomManager::GetSingleton().UnloadRoom(lua_tointeger(L, -2));
 	return 0;
 }
 
 static const luaL_Reg roomManagerLib[] = {
-	{"CreateRoom", createRoom},
+	{"GetRoom",getRoom},
-	{"UnloadRoom", unloadRoom},
+	{"CreateRoom",createRoom},
+	{"UnloadRoom",unloadRoom},
 	{nullptr, nullptr}
 };
 

server/server_application.hpp

@@ -30,7 +30,6 @@
 
 //common utilities
 #include "udp_network_utility.hpp"
-#include "serial_packet.hpp"
 #include "config_utility.hpp"
 #include "singleton.hpp"
 
@@ -47,7 +46,7 @@
 class ServerApplication: public Singleton<ServerApplication> {
 public:
 	//public methods
-	void Init(int argc, char* argv[]);
+	void Init(int argc, char** argv);
 	void Proc();
 	void Quit();
 
@@ -61,12 +60,10 @@ private:
 	void HandlePacket(SerialPacket* const);
 
 	//basic connections
-	void HandlePing(ServerPacket* const);
+	void HandleBroadcastRequest(SerialPacket* const);
-	void HandlePong(ServerPacket* const);
-	void HandleBroadcastRequest(ServerPacket* const);
 	void HandleJoinRequest(ClientPacket* const);
 	void HandleDisconnect(ClientPacket* const);
-	void HandleShutdown(ClientPacket* const);
+	void HandleShutdown(SerialPacket* const);
 
 	//map management
 	void HandleRegionRequest(RegionPacket* const);
@@ -80,9 +77,7 @@ private:
 	void HandleSynchronize(ClientPacket* const);
 
 	//utility methods
-	void CheckClientConnections();
 	//TODO: a function that only sends to characters in a certain proximity
-	void CleanupLostConnection(int index);
 	void PumpPacket(SerialPacket* const);
 	void PumpCharacterUnload(int uid);
 	void CopyCharacterToPacket(CharacterPacket* const packet, int characterIndex);

server/server_logic.cpp

@@ -21,26 +21,26 @@
 */
 #include "server_application.hpp"
 
+#include "serial_packet.hpp"
+
 //utility functions
-#include "sql_tools.hpp"
+#include "sql_utility.hpp"
 #include "utility.hpp"
 
 #include <stdexcept>
-#include <chrono>
 #include <iostream>
-#include <sstream>
 #include <string>
 
 //-------------------------
 //public methods
 //-------------------------
 
-void ServerApplication::Init(int argc, char* argv[]) {
+void ServerApplication::Init(int argc, char** argv) {
 	//NOTE: I might need to rearrange the init process so that lua & SQL can interact with the map system as needed.
 	std::cout << "Beginning " << argv[0] << std::endl;
 
 	//load the prerequisites
-	config.Load("rsc\\config.cfg", argc, argv);
+	config.Load("rsc\\config.cfg");
 
 	//-------------------------
 	//Initialize the APIs
@@ -72,27 +72,8 @@ void ServerApplication::Init(int argc, char* argv[]) {
 		throw(std::runtime_error("Failed to initialize lua"));
 	}
 	luaL_openlibs(luaState);
-
 	std::cout << "Initialized lua" << std::endl;
 
-	//append config["dir.scripts"] to the module path
-	if (config["dir.scripts"].size() > 0) {
-		//get the original path
-		lua_getglobal(luaState, "package");
-		lua_getfield(luaState, -1, "path");
-
-		//build & push the message
-		std::ostringstream path;
-		path << lua_tostring(luaState, -1) << ";" << config["dir.scripts"] << "?.lua";
-		lua_pushstring(luaState, path.str().c_str());
-
-		//set the new path and clean up the stack
-		lua_setfield(luaState, -3, "path");
-		lua_pop(luaState, 2);
-
-		std::cout << "\tLua script directory appended" << std::endl;
-	}
-
 	//-------------------------
 	//Setup the objects
 	//-------------------------
@@ -130,7 +111,6 @@ void ServerApplication::Init(int argc, char* argv[]) {
 
 	std::cout << "Internal sizes:" << std::endl;
 
-	DEBUG_OUTPUT_VAR(NETWORK_VERSION);
 	DEBUG_OUTPUT_VAR(sizeof(Region::type_t));
 	DEBUG_OUTPUT_VAR(sizeof(Region));
 	DEBUG_OUTPUT_VAR(REGION_WIDTH);
@@ -138,10 +118,8 @@ void ServerApplication::Init(int argc, char* argv[]) {
 	DEBUG_OUTPUT_VAR(REGION_DEPTH);
 	DEBUG_OUTPUT_VAR(REGION_TILE_FOOTPRINT);
 	DEBUG_OUTPUT_VAR(REGION_SOLID_FOOTPRINT);
-	DEBUG_OUTPUT_VAR(PACKET_STRING_SIZE);
 	DEBUG_OUTPUT_VAR(PACKET_BUFFER_SIZE);
 	DEBUG_OUTPUT_VAR(MAX_PACKET_SIZE);
-	DEBUG_OUTPUT_VAR(static_cast<int>(SerialPacketType::LAST));
 
 #undef DEBUG_OUTPUT_VAR
 
@@ -166,10 +144,7 @@ void ServerApplication::Proc() {
 			HandlePacket(packetBuffer);
 		}
 		//update the internals
-		//...
+		//BUG: #30 Update the internals i.e. player positions
-
-		//Check connections
-		CheckClientConnections();
 
 		//give the computer a break
 		SDL_Delay(10);
@@ -203,16 +178,10 @@ void ServerApplication::Quit() {
 //-------------------------
 
 void ServerApplication::HandlePacket(SerialPacket* const argPacket) {
-	switch(argPacket->type) {
+	switch(argPacket->GetType()) {
 		//basic connections
-		case SerialPacketType::PING:
-			HandlePing(static_cast<ServerPacket*>(argPacket));
-		break;
-		case SerialPacketType::PONG:
-			HandlePong(static_cast<ServerPacket*>(argPacket));
-		break;
 		case SerialPacketType::BROADCAST_REQUEST:
-			HandleBroadcastRequest(static_cast<ServerPacket*>(argPacket));
+			HandleBroadcastRequest(static_cast<SerialPacket*>(argPacket));
 		break;
 		case SerialPacketType::JOIN_REQUEST:
 			HandleJoinRequest(static_cast<ClientPacket*>(argPacket));
@@ -221,7 +190,7 @@ void ServerApplication::HandlePacket(SerialPacket* const argPacket) {
 			HandleDisconnect(static_cast<ClientPacket*>(argPacket));
 		break;
 		case SerialPacketType::SHUTDOWN:
-			HandleShutdown(static_cast<ClientPacket*>(argPacket));
+			HandleShutdown(static_cast<SerialPacket*>(argPacket));
 		break;
 
 		//map management
@@ -255,7 +224,7 @@ void ServerApplication::HandlePacket(SerialPacket* const argPacket) {
 		//handle errors
 		default: {
 			std::string msg = "Unknown SerialPacketType encountered in the server: ";
-			msg += to_string_custom(static_cast<int>(argPacket->type));
+			msg += to_string_custom(static_cast<int>(argPacket->GetType()));
 			throw(std::runtime_error(msg));
 		}
 		break;

server/server_methods.cpp

@@ -21,74 +21,49 @@
 */
 #include "server_application.hpp"
 
-#include <chrono>
 #include <iostream>
 
 //-------------------------
 //basic connections
 //-------------------------
 
-void ServerApplication::HandlePing(ServerPacket* const argPacket) {
+void ServerApplication::HandleBroadcastRequest(SerialPacket* const argPacket) {
-	ServerPacket newPacket;
-	newPacket.type = SerialPacketType::PONG;
-	network.SendTo(argPacket->srcAddress, &newPacket);
-}
-
-void ServerApplication::HandlePong(ServerPacket* const argPacket) {
-	//find and update the specified client
-	for (auto& it : clientMap) {
-		if (it.second.GetAddress().host == argPacket->srcAddress.host &&
-			it.second.GetAddress().port == argPacket->srcAddress.port
-			) {
-			it.second.ResetAttempts();
-			break;
-		}
-	}
-}
-
-void ServerApplication::HandleBroadcastRequest(ServerPacket* const argPacket) {
 	//send the server's data
 	ServerPacket newPacket;
 
-	newPacket.type = SerialPacketType::BROADCAST_RESPONSE;
+	newPacket.SetType(SerialPacketType::BROADCAST_RESPONSE);
-	strncpy(newPacket.name, config["server.name"].c_str(), PACKET_STRING_SIZE);
+	newPacket.SetName(config["server.name"].c_str());
-	newPacket.playerCount = characterMgr.GetLoadedCount();
+	newPacket.SetPlayerCount(characterMgr.GetContainer()->size());
-	newPacket.version = NETWORK_VERSION;
+	newPacket.SetVersion(NETWORK_VERSION);
 
-	network.SendTo(argPacket->srcAddress, static_cast<SerialPacket*>(&newPacket));
+	network.SendTo(argPacket->GetAddressPtr(), static_cast<SerialPacket*>(&newPacket));
 }
 
 void ServerApplication::HandleJoinRequest(ClientPacket* const argPacket) {
+	//create the new client
+	ClientData newClient;
+	newClient.address = argPacket->GetAddress();
+
 	//load the user account
 	//TODO: handle passwords
-	int accountIndex = accountMgr.Load(argPacket->username, clientIndex);
+	int accountIndex = accountMgr.LoadAccount(argPacket->GetUsername(), clientIndex);
-
-	//Cannot load
 	if (accountIndex < 0) {
-		TextPacket newPacket;
+		//TODO: send rejection packet
-		newPacket.type = SerialPacketType::JOIN_REJECTION;
+		std::cerr << "Error: Account already loaded: " << accountIndex << std::endl;
-		std::string msg = std::string() + "Account already loaded: " + argPacket->username;
-		memset(newPacket.name, 0, PACKET_STRING_SIZE);
-		strncpy(newPacket.text, msg.c_str(), PACKET_STRING_SIZE); //BUG: If the name is too long this would truncate it
-		network.SendTo(argPacket->srcAddress, static_cast<SerialPacket*>(&newPacket));
 		return;
 	}
 
 	//send the client their info
 	ClientPacket newPacket;
-	newPacket.type = SerialPacketType::JOIN_RESPONSE;
+	newPacket.SetType(SerialPacketType::JOIN_RESPONSE);
-	newPacket.clientIndex = clientIndex;
+	newPacket.SetClientIndex(clientIndex);
-	newPacket.accountIndex = accountIndex;
+	newPacket.SetAccountIndex(accountIndex);
 
-	network.SendTo(argPacket->srcAddress, static_cast<SerialPacket*>(&newPacket));
+	network.SendTo(&newClient.address, static_cast<SerialPacket*>(&newPacket));
-
-	//register the client
-	ClientData newClient;
-	newClient.SetAddress(argPacket->srcAddress);
-	clientMap[clientIndex++] = newClient;
 
 	//finished this routine
-	std::cout << "New connection, " << clientMap.size() << " clients and " << accountMgr.GetLoadedCount() << " accounts total" << std::endl;
+	clientMap[clientIndex++] = newClient;
+	std::cout << "New connection, " << clientMap.size() << " clients and " << accountMgr.GetContainer()->size() << " accounts total" << std::endl;
 }
 
 void ServerApplication::HandleDisconnect(ClientPacket* const argPacket) {
@@ -105,29 +80,29 @@ void ServerApplication::HandleDisconnect(ClientPacket* const argPacket) {
 
 	//forward to the specified client
 	network.SendTo(
-		clientMap[ accountMgr.Get(argPacket->accountIndex)->GetClientIndex() ].GetAddress(),
+		&clientMap[ accountMgr.GetAccount(argPacket->GetAccountIndex())->GetClientIndex() ].address,
 		static_cast<SerialPacket*>(argPacket)
 	);
 
 	//save and unload this account's characters
-	characterMgr.UnloadIf([&](std::pair<int, CharacterData> it) -> bool {
+	//pump the unload message to all remaining clients
-		if (argPacket->accountIndex == it.second.GetOwner()) {
+	characterMgr.UnloadCharacterIf([&](std::map<int, CharacterData>::iterator it) -> bool {
-			//pump the unload message to all remaining clients
+		if (argPacket->GetAccountIndex() == it->second.GetOwner()) {
-			PumpCharacterUnload(it.first);
+			PumpCharacterUnload(it->first);
 			return true;
 		}
 		return false;
 	});
 
 	//erase the in-memory stuff
-	clientMap.erase(accountMgr.Get(argPacket->accountIndex)->GetClientIndex());
+	clientMap.erase(accountMgr.GetAccount(argPacket->GetAccountIndex())->GetClientIndex());
-	accountMgr.Unload(argPacket->accountIndex);
+	accountMgr.UnloadAccount(argPacket->GetAccountIndex());
 
 	//finished this routine
-	std::cout << "Disconnection, " << clientMap.size() << " clients and " << accountMgr.GetLoadedCount() << " accounts total" << std::endl;
+	std::cout << "Disconnection, " << clientMap.size() << " clients and " << accountMgr.GetContainer()->size() << " accounts total" << std::endl;
 }
 
-void ServerApplication::HandleShutdown(ClientPacket* const argPacket) {
+void ServerApplication::HandleShutdown(SerialPacket* const argPacket) {
 	//TODO: authenticate who is shutting the server down
 	/*Pseudocode:
 	if sender's account -> admin is not true then
@@ -140,8 +115,8 @@ void ServerApplication::HandleShutdown(ClientPacket* const argPacket) {
 	running = false;
 
 	//disconnect all clients
-	ClientPacket newPacket;
+	ServerPacket newPacket;
-	newPacket.type = SerialPacketType::DISCONNECT;
+	newPacket.SetType(SerialPacketType::DISCONNECT);
 	PumpPacket(&newPacket);
 
 	//finished this routine
@@ -155,16 +130,15 @@ void ServerApplication::HandleShutdown(ClientPacket* const argPacket) {
 void ServerApplication::HandleRegionRequest(RegionPacket* const argPacket) {
 	RegionPacket newPacket;
 
-	newPacket.type = SerialPacketType::REGION_CONTENT;
+	newPacket.SetType(SerialPacketType::REGION_CONTENT);
-	newPacket.roomIndex = argPacket->roomIndex;
+	newPacket.SetRoomIndex(argPacket->GetRoomIndex());
-	newPacket.x = argPacket->x;
+	newPacket.SetX(argPacket->GetX());
-	newPacket.y = argPacket->y;
+	newPacket.SetY(argPacket->GetY());
 
-	//BUG: possibly related to #35
+	newPacket.SetRegion(roomMgr.GetRoom(argPacket->GetRoomIndex())->GetPager()->GetRegion(argPacket->GetX(), argPacket->GetY() ));
-	newPacket.region = roomMgr.Get(argPacket->roomIndex)->GetPager()->GetRegion(argPacket->x, argPacket->y);
 
 	//send the content
-	network.SendTo(argPacket->srcAddress, static_cast<SerialPacket*>(&newPacket));
+	network.SendTo(argPacket->GetAddressPtr(), static_cast<SerialPacket*>(&newPacket));
 }
 
 //-------------------------
@@ -172,33 +146,25 @@ void ServerApplication::HandleRegionRequest(RegionPacket* const argPacket) {
 //-------------------------
 
 void ServerApplication::HandleCharacterNew(CharacterPacket* const argPacket) {
+	//BUG: #27 Characters can be created with an invalid account index
 	//NOTE: misnomer, try to load the character first
-	int characterIndex = characterMgr.Load(argPacket->accountIndex, argPacket->handle, argPacket->avatar);
+	int characterIndex = characterMgr.LoadCharacter(argPacket->GetAccountIndex(), argPacket->GetHandle(), argPacket->GetAvatar());
 
-	//cannot load or create
+	if (characterIndex == -1) {
-	if (characterIndex < 0) {
+		//TODO: rejection packet
-		//build the error message
+		std::cerr << "Warning: Character already loaded" << std::endl;
-		std::string msg;
+		return;
-		if (characterIndex == -1) {
+	}
-			msg += "Character already loaded: ";
-		}
-		else if (characterIndex == -2) {
-			msg += "Character already exists: ";
-		}
-		msg += argPacket->handle;
 
-		//create, fill and send the packet
+	if (characterIndex == -2) {
-		TextPacket newPacket;
+		//TODO: rejection packet
-		newPacket.type = SerialPacketType::CHARACTER_REJECTION;
+		std::cerr << "Warning: Character already exists" << std::endl;
-		memset(newPacket.name, 0, PACKET_STRING_SIZE);
-		strncpy(newPacket.text, msg.c_str(), PACKET_STRING_SIZE);
-		network.SendTo(argPacket->srcAddress, static_cast<SerialPacket*>(&newPacket));
 		return;
 	}
 
 	//send this new character to all clients
 	CharacterPacket newPacket;
-	newPacket.type = SerialPacketType::CHARACTER_NEW;
+	newPacket.SetType(SerialPacketType::CHARACTER_NEW);
 	CopyCharacterToPacket(&newPacket, characterIndex);
 	PumpPacket(&newPacket);
 }
@@ -207,26 +173,22 @@ void ServerApplication::HandleCharacterDelete(CharacterPacket* const argPacket)
 	//NOTE: Disconnecting only unloads a character, this explicitly deletes it
 
 	//Authenticate the owner is doing this
-	int characterIndex = characterMgr.Load(argPacket->accountIndex, argPacket->handle, argPacket->avatar);
+	int characterIndex = characterMgr.LoadCharacter(argPacket->GetAccountIndex(), argPacket->GetHandle(), argPacket->GetAvatar());
 
 	//if this is not your character
-	if (characterIndex < 0 && characterMgr.Get(characterIndex)->GetOwner() != argPacket->accountIndex) {
+	if (characterIndex == -2) {
-		//send the rejection packet
+		//TODO: rejection packet
-		TextPacket newPacket;
+		std::cerr << "Warning: Character cannot be deleted" << std::endl;
-		newPacket.type = SerialPacketType::CHARACTER_REJECTION;
-		memset(newPacket.name, 0, PACKET_STRING_SIZE);
-		strncpy(newPacket.text, "Character cannot be deleted", PACKET_STRING_SIZE);
-		network.SendTo(argPacket->srcAddress, static_cast<SerialPacket*>(&newPacket));
 
 		//unload an unneeded character
 		if (characterIndex != -1) {
-			characterMgr.Unload(characterIndex);
+			characterMgr.UnloadCharacter(characterIndex);
 		}
 		return;
 	}
 
 	//delete it
-	characterMgr.Delete(characterIndex);
+	characterMgr.DeleteCharacter(characterIndex);
 
 	//TODO: success packet
 
@@ -235,20 +197,22 @@ void ServerApplication::HandleCharacterDelete(CharacterPacket* const argPacket)
 }
 
 void ServerApplication::HandleCharacterUpdate(CharacterPacket* const argPacket) {
-	CharacterData* character = characterMgr.Get(argPacket->characterIndex);
+	CharacterData* character = characterMgr.GetCharacter(argPacket->GetCharacterIndex());
 
 	//make a new character if this one doesn't exist
 	if (!character) {
+		//this isn't normal
+		std::cerr << "Warning: HandleCharacterUpdate() is passing to HandleCharacterNew()" << std::endl;
 		HandleCharacterNew(argPacket);
 		return;
 	}
 
 	//accept client-side logic
-	character->SetRoomIndex(argPacket->roomIndex);
+	character->SetRoomIndex(argPacket->GetRoomIndex());
-	character->SetOrigin(argPacket->origin);
+	character->SetOrigin(argPacket->GetOrigin());
-	character->SetMotion(argPacket->motion);
+	character->SetMotion(argPacket->GetMotion());
 
-	*character->GetBaseStats() = argPacket->stats;
+	*character->GetBaseStats() = *argPacket->GetStatistics();
 
 	//TODO: gameplay components: equipment, items, buffs, debuffs
 
@@ -264,15 +228,16 @@ void ServerApplication::HandleSynchronize(ClientPacket* const argPacket) {
 	//NOTE: I quite dislike this function
 
 	//send all of the server's data to this client
-	ClientData& client = clientMap[argPacket->clientIndex];
+	ClientData& client = clientMap[argPacket->GetClientIndex()];
 
 	//send all characters
 	CharacterPacket newPacket;
-	newPacket.type = SerialPacketType::CHARACTER_UPDATE;
+	newPacket.SetType(SerialPacketType::CHARACTER_UPDATE);
 
 	for (auto& it : *characterMgr.GetContainer()) {
+		newPacket.SetCharacterIndex(it.first);
 		CopyCharacterToPacket(&newPacket, it.first);
-		network.SendTo(client.GetAddress(), static_cast<SerialPacket*>(&newPacket));
+		network.SendTo(&client.address, static_cast<SerialPacket*>(&newPacket));
 	}
 
 	//TODO: more in HandleSynchronize()
@@ -282,95 +247,35 @@ void ServerApplication::HandleSynchronize(ClientPacket* const argPacket) {
 //utility methods
 //-------------------------
 
-void ServerApplication::CheckClientConnections() {
-	for (auto& it : clientMap) {
-		if (std::chrono::steady_clock::now() - it.second.GetLastBeat() > std::chrono::seconds(3)) {
-			ServerPacket newPacket;
-			newPacket.type = SerialPacketType::PING;
-			network.SendTo(it.second.GetAddress(), &newPacket);
-			it.second.IncrementAttempts();
-		}
-
-		if (it.second.GetAttempts() > 2) {
-			CleanupLostConnection(it.first);
-			//all iterators are invalid, so we can't continue
-			break;
-		}
-	}
-}
-
-void ServerApplication::CleanupLostConnection(int clientIndex) {
-	//NOTE: This assumes each player has only one account and character at a time
-	//TODO: handle multiple characters (bots, etc.)
-
-	//find the account
-	int accountIndex = -1;
-	for (auto& it : *accountMgr.GetContainer()) {
-		if (it.second.GetClientIndex() == clientIndex) {
-			accountIndex = it.first;
-			break;
-		}
-	}
-
-	//find the character
-	int characterIndex = -1;
-	for (auto& it : *characterMgr.GetContainer()) {
-		if (it.second.GetOwner() == accountIndex) {
-			characterIndex = it.first;
-			break;
-		}
-	}
-
-	//send a disconnection message just in case
-	ClientPacket newPacket;
-	newPacket.type = SerialPacketType::DISCONNECT;
-	network.SendTo(clientMap[clientIndex].GetAddress(), &newPacket);
-
-	//clean up this mess
-	characterMgr.Unload(characterIndex);
-	accountMgr.Unload(accountIndex);
-	clientMap.erase(clientIndex);
-
-	PumpCharacterUnload(characterIndex);
-
-	//output a message
-	std::cerr << "Connection lost: " << std::endl;
-	std::cerr << "\tClient: " << clientIndex << std::endl;
-	std::cerr << "\tAccount: " << accountIndex << std::endl;
-	std::cerr << "\tCharacter: " << characterIndex << std::endl;
-	std::cout << clientMap.size() << " clients and " << accountMgr.GetLoadedCount() << " accounts total" << std::endl;
-}
-
 //TODO: a function that only sends to characters in a certain proximity
 
 void ServerApplication::PumpPacket(SerialPacket* const argPacket) {
 	for (auto& it : clientMap) {
-		network.SendTo(it.second.GetAddress(), argPacket);
+		network.SendTo(&it.second.address, argPacket);
 	}
 }
 
 void ServerApplication::PumpCharacterUnload(int uid) {
 	//delete the client-side character(s)
-	//NOTE: This is a strange function
 	CharacterPacket newPacket;
-	newPacket.type = SerialPacketType::CHARACTER_DELETE;
+	newPacket.SetType(SerialPacketType::CHARACTER_DELETE);
-	newPacket.characterIndex = uid;
+	newPacket.SetCharacterIndex(uid);
 	PumpPacket(static_cast<SerialPacket*>(&newPacket));
 }
 
 void ServerApplication::CopyCharacterToPacket(CharacterPacket* const packet, int characterIndex) {
-	CharacterData* character = characterMgr.Get(characterIndex);
+	CharacterData* character = characterMgr.GetCharacter(characterIndex);
 	if (!character) {
 		throw(std::runtime_error("Failed to copy a character to a packet"));
 	}
 
 	//TODO: keep this up to date when the character changes
-	packet->characterIndex = characterIndex;
+	packet->SetCharacterIndex(characterIndex);
-	strncpy(packet->handle, character->GetHandle().c_str(), PACKET_STRING_SIZE);
+	packet->SetHandle(character->GetHandle().c_str());
-	strncpy(packet->avatar, character->GetAvatar().c_str(), PACKET_STRING_SIZE);
+	packet->SetAvatar(character->GetAvatar().c_str());
-	packet->accountIndex = character->GetOwner();
+	packet->SetAccountIndex(character->GetOwner());
-	packet->roomIndex = character->GetRoomIndex();
+	packet->SetRoomIndex(character->GetRoomIndex());
-	packet->origin = character->GetOrigin();
+	packet->SetOrigin(character->GetOrigin());
-	packet->motion = character->GetMotion();
+	packet->SetMotion(character->GetMotion());
-	packet->stats = *character->GetBaseStats();
+	*packet->GetStatistics() = *character->GetBaseStats();
 }

server/server_utilities/makefile

@@ -1,37 +0,0 @@
-#config
-INCLUDES+=. ../../common/utilities
-LIBS+=
-CXXFLAGS+=-std=c++11 $(addprefix -I,$(INCLUDES))
-
-#source
-CXXSRC=$(wildcard *.cpp)
-
-#objects
-OBJDIR=obj
-OBJ+=$(addprefix $(OBJDIR)/,$(CXXSRC:.cpp=.o))
-
-#output
-OUTDIR=..
-OUT=$(addprefix $(OUTDIR)/,server.a)
-
-#targets
-all: $(OBJ) $(OUT)
-	ar -crs $(OUT) $(OBJ)
-
-$(OBJ): | $(OBJDIR)
-
-$(OUT): | $(OUTDIR)
-
-$(OBJDIR):
-	mkdir $(OBJDIR)
-
-$(OUTDIR):
-	mkdir $(OUTDIR)
-
-$(OBJDIR)/%.o: %.cpp
-	$(CXX) $(CXXFLAGS) -c -o $@ $<
-
-clean:
-	$(RM) *.o *.a *.exe
-
-rebuild: clean all

server/server_utilities/manager_interface.hpp

@@ -1,55 +0,0 @@
-/* Copyright: (c) Kayne Ruse 2014
- * 
- * This software is provided 'as-is', without any express or implied
- * warranty. In no event will the authors be held liable for any damages
- * arising from the use of this software.
- * 
- * Permission is granted to anyone to use this software for any purpose,
- * including commercial applications, and to alter it and redistribute it
- * freely, subject to the following restrictions:
- * 
- * 1. The origin of this software must not be misrepresented; you must not
- * claim that you wrote the original software. If you use this software
- * in a product, an acknowledgment in the product documentation would be
- * appreciated but is not required.
- * 
- * 2. Altered source versions must be plainly marked as such, and must not be
- * misrepresented as being the original software.
- * 
- * 3. This notice may not be removed or altered from any source
- * distribution.
-*/
-#ifndef MANAGERINTERFACE_HPP_
-#define MANAGERINTERFACE_HPP_
-
-#include <functional>
-#include <map>
-
-template<typename T, typename... Arguments>
-class ManagerInterface {
-public:
-	//common public methods
-	virtual int Create(Arguments... parameters) = 0;
-	virtual int Load(Arguments... parameters) = 0;
-	virtual int Save(int uid) = 0;
-	virtual void Unload(int uid) = 0;
-	virtual void Delete(int uid) = 0;
-
-	virtual void UnloadAll() = 0;
-	virtual void UnloadIf(std::function<bool(std::pair<const int, T>)> fn) = 0;
-
-	//accessors & mutators
-	virtual T* Get(int uid) = 0;
-	virtual int GetLoadedCount() = 0;
-	virtual int GetTotalCount() = 0; //can be an alias of GetLoadedCount()
-	virtual std::map<int, T>* GetContainer() = 0;
-
-protected:
-	ManagerInterface() = default;
-	~ManagerInterface() = default;
-
-	//members
-	std::map<int, T> elementMap;
-};
-
-#endif

todo.txt

@@ -0,0 +1,17 @@
+TODO: Reduce the verbosity of the network packets
+TODO: encapsulate the data structures
+TODO: Ping-pong and keep alive system
+TODO: Move the statistics into their own SQL table, instead of duplicating the structure a dozen times
+TODO: Get the rooms working, even if only via hotkeys
+TODO: Rejection messages
+TODO: Move the map system into it's own namespace
+TODO: The TileSheet class should implement the surface itself
+
+TODO: Fix shoddy movement
+TODO: make the whole thing more fault tolerant
+TODO: Authentication
+TODO: server is slaved to the client
+
+TODO: Time delay for requesting region packets
+TODO: command line parameters overriding config.cfg settings
+TODO: A proper logging system