Merge branch 'dev-charshare' (early part) into develop (read more)

Moved the server's containers into the common directories, and removed the
server's static members.

This commit does build, but the next commit in 'dev-charshare' won't so
I'm merging this while I can.

common/gameplay/character_data.hpp

@@ -28,6 +28,11 @@
 #include "statistics.hpp"
 
 #include <string>
+#include <cmath>
+
+//the speeds that the characters move
+constexpr double CHARACTER_WALKING_SPEED = 140;
+constexpr double CHARACTER_WALKING_MOD = 1.0/sqrt(2.0);
 
 struct CharacterData {
 	//metadata

common/gameplay/client_data.hpp

@@ -26,7 +26,6 @@
 
 struct ClientData {
 	IPaddress address = {0,0};
-	static int uidCounter;
 };
 
 #endif

common/gameplay/combat_data.hpp

@@ -46,8 +46,6 @@ struct CombatData {
 
 	//time interval
 	Clock::time_point lastTick = Clock::now();
-
-	static int uidCounter;
 };
 
 #endif

common/gameplay/enemy_data.hpp

@@ -43,8 +43,6 @@ struct EnemyData {
 	//NOTE: these are lost when unloaded
 	int tableIndex;
 	int atbGauge = 0;
-
-	static int uidCounter;
 };
 
 #endif

server/server_application.hpp

@@ -117,6 +117,9 @@ private:
 	//misc
 	bool running = true;
 	ConfigUtility config;
+	int clientUID = 0;
+	int combatUID = 0;
+	int enemyUID = 0;
 };
 
 #endif

server/server_connections.cpp

@@ -47,7 +47,7 @@ void ServerApplication::HandleJoinRequest(SerialPacket packet) {
 	newClient.address = packet.meta.srcAddress;
 
 	//load the user account
-	int accountIndex = LoadUserAccount(packet.clientInfo.username, ClientData::uidCounter);
+	int accountIndex = LoadUserAccount(packet.clientInfo.username, clientUID);
 	if (accountIndex < 0) {
 		//TODO: send rejection packet
 		std::cerr << "Error: Account already loaded: " << accountIndex << std::endl;
@@ -65,7 +65,7 @@ void ServerApplication::HandleJoinRequest(SerialPacket packet) {
 
 	//send the client their info
 	packet.meta.type = SerialPacket::Type::JOIN_RESPONSE;
-	packet.clientInfo.clientIndex = ClientData::uidCounter;
+	packet.clientInfo.clientIndex = clientUID;
 	packet.clientInfo.accountIndex = accountIndex;
 	packet.clientInfo.characterIndex = characterIndex;
 
@@ -85,7 +85,7 @@ void ServerApplication::HandleJoinRequest(SerialPacket packet) {
 
 	//TODO: don't send anything to a certain client until they send the OK (the sync packet? or ignore client side?)
 	//finished this routine
-	clientMap[ClientData::uidCounter++] = newClient;
+	clientMap[clientUID++] = newClient;
 	std::cout << "Connect, total: " << clientMap.size() << std::endl;
 }
 

server/server_internals.cpp

@@ -27,14 +27,6 @@
 #include <iostream>
 #include <string>
 
-//-------------------------
-//Define the various UIDs
-//-------------------------
-
-int ClientData::uidCounter = 0;
-int CombatData::uidCounter = 0;
-int EnemyData::uidCounter = 0;
-
 //-------------------------
 //Define the public members
 //-------------------------