Merge branch 'high-water-mark' into collisions

client/client_application.cpp

@@ -49,7 +49,7 @@ void ClientApplication::Init(int argc, char* argv[]) {
 
 	//load the prerequisites
 	ConfigUtility& config = ConfigUtility::GetSingleton();
-	config.Load("rsc/config.cfg", argc, argv);
+	config.Load("rsc/config.cfg", false, argc, argv);
 
 	//-------------------------
 	//Initialize the APIs

client/main.cpp

@@ -36,7 +36,7 @@ int main(int argc, char* argv[]) {
 		ConfigUtility::CreateSingleton();
 		UDPNetworkUtility::CreateSingleton();
 
-		//call the server's routines
+		//call the client's routines
 		ClientApplication::CreateSingleton();
 		ClientApplication& app = ClientApplication::GetSingleton();
 

client/scenes/in_world.cpp

@@ -137,10 +137,8 @@ void InWorld::Update() {
 	//check the connection (heartbeat)
 	if (Clock::now() - lastBeat > std::chrono::seconds(3)) {
 		if (attemptedBeats > 2) {
-			//two-step logout
-			SendLogoutRequest();
+			//escape to the disconnect screen
 			SendDisconnectRequest();
-
 			SetNextScene(SceneList::DISCONNECTEDSCREEN);
 			ConfigUtility::GetSingleton()["client.disconnectMessage"] = "Error: Lost connection to the server";
 		}
@@ -248,7 +246,6 @@ void InWorld::Render(SDL_Surface* const screen) {
 
 void InWorld::QuitEvent() {
 	//two-step logout
-	SendLogoutRequest();
 	SendDisconnectRequest();
 	SetNextScene(SceneList::QUIT);
 }
@@ -276,9 +273,9 @@ void InWorld::KeyDown(SDL_KeyboardEvent const& key) {
 	//hotkeys
 	switch(key.keysym.sym) {
 		case SDLK_ESCAPE:
-			//the escape key should actually control menus and stuff
+			//TODO: the escape key should actually control menus and stuff
 			SendLogoutRequest();
-		break;
+		return;
 	}
 
 	//character movement
@@ -299,6 +296,9 @@ void InWorld::KeyDown(SDL_KeyboardEvent const& key) {
 		case SDLK_d:
 			motion.x += CHARACTER_WALKING_SPEED;
 		break;
+		default:
+			//DOCS: prevents wrong keys screwing with character movement
+			return;
 	}
 	//handle diagonals
 	if (motion.x != 0 && motion.y != 0) {
@@ -329,6 +329,9 @@ void InWorld::KeyUp(SDL_KeyboardEvent const& key) {
 		case SDLK_d:
 			motion.x = std::max(0.0, motion.x -= CHARACTER_WALKING_SPEED);
 		break;
+		default:
+			//DOCS: prevents wrong keys screwing with character movement
+			return;
 	}
 	//BUGFIX: reset cardinal direction speed on key release
 	if (motion.x > 0) {
@@ -473,30 +476,29 @@ void InWorld::SendShutdownRequest() {
 }
 
 void InWorld::HandleLogoutResponse(ClientPacket* const argPacket) {
+	if (localCharacter) {
+		characterMap.erase(characterIndex);
+		localCharacter = nullptr;
+	}
+
 	accountIndex = -1;
 	characterIndex = -1;
 
 	//reset the camera
-	camera.x = camera.y = 0;
 	camera.marginX = camera.marginY = 0;
 
+	//because, why not? I guess...
 	SendDisconnectRequest();
 }
 
 void InWorld::HandleDisconnectResponse(ClientPacket* const argPacket) {
+	HandleLogoutResponse(argPacket);//shortcut
 	SetNextScene(SceneList::DISCONNECTEDSCREEN);
 	ConfigUtility::GetSingleton()["client.disconnectMessage"] = "You have successfully logged out";
 }
 
 void InWorld::HandleDisconnectForced(ClientPacket* const argPacket) {
-	//clear the local data
-	accountIndex = -1;
-	characterIndex = -1;
-
-	//reset the camera
-	camera.x = camera .y = 0;
-	camera.marginX = camera.marginY = 0;
-
+	HandleDisconnectResponse(argPacket);//shortcut
 	SetNextScene(SceneList::DISCONNECTEDSCREEN);
 	ConfigUtility::GetSingleton()["client.disconnectMessage"] = "You have been forcibly disconnected by the server";
 }

common/debugging/timer.cpp

@@ -39,7 +39,7 @@ void Timer::Stop() {
 
 std::ostream& operator<<(std::ostream& os, Timer& t) {
 	os << t.GetName() << ": ";
-	os << std::chrono::duration_cast<std::chrono::milliseconds>(t.GetTime()).count();
-	os << "ms";
+	os << std::chrono::duration_cast<std::chrono::microseconds>(t.GetTime()).count();
+	os << "us";
 	return os;
 }

common/debugging/timer.hpp

@@ -34,8 +34,8 @@ public:
 	Timer(std::string s);
 	~Timer() = default;
 
-	inline void Start();
-	inline void Stop();
+	void Start();
+	void Stop();
 
 	//accessors and mutators
 	Clock::duration GetTime() { return timeSpan; }

common/utilities/config_utility.cpp

@@ -27,13 +27,13 @@
 #include <sstream>
 #include <stdexcept>
 
-void ConfigUtility::Load(std::string fname, int argc, char* argv[]) {
+void ConfigUtility::Load(std::string fname, bool skipMissingFile, int argc, char* argv[]) {
 	//clear the stored configuration
 	configMap.clear();
 
 	//use the default file
 	if (argc < 2) {
-		configMap = Read(fname);
+		configMap = Read(fname, skipMissingFile);
 		return;
 	}
 
@@ -47,7 +47,9 @@ void ConfigUtility::Load(std::string fname, int argc, char* argv[]) {
 	for (int i = 1; i < argc; ++i) {
 		//read from a specified config file
 		if (!strncmp(argv[i], "-config=", 8)) {
-			redirectedFile = Read(argv[i] + 8);
+			//older specified files take precedence
+			table_t tmp = Read(argv[i] + 8, skipMissingFile);
+			redirectedFile.insert(tmp.begin(), tmp.end());
 			redirectUsed = true;
 			continue;
 		}
@@ -73,18 +75,21 @@ void ConfigUtility::Load(std::string fname, int argc, char* argv[]) {
 
 	//finally, construct the final config table
 	if (!redirectUsed) {
-		redirectedFile = Read(fname);
+		redirectedFile = Read(fname, skipMissingFile);
 	}
 	configMap.insert(cmdLineParams.begin(), cmdLineParams.end());
 	configMap.insert(redirectedFile.begin(), redirectedFile.end());
 }
 
-ConfigUtility::table_t ConfigUtility::Read(std::string fname) {
+ConfigUtility::table_t ConfigUtility::Read(std::string fname, bool skipMissingFile) {
 	//read in and return this file's data
 	table_t retTable;
 	std::ifstream is(fname);
 
 	if (!is.is_open()) {
+		if (skipMissingFile) {
+			return {}; //empty table
+		}
 		std::ostringstream os;
 		os << "Failed to open a config file: " << fname;
 		throw(std::runtime_error( os.str() ));
@@ -143,7 +148,7 @@ ConfigUtility::table_t ConfigUtility::Read(std::string fname) {
 
 	//load in any subordinate config files
 	if (retTable.find("config.next") != retTable.end()) {
-		table_t subTable = Read(retTable["config.next"]);
+		table_t subTable = Read(retTable["config.next"], skipMissingFile);
 		retTable.insert(subTable.begin(), subTable.end());
 	}
 

common/utilities/config_utility.hpp

@@ -27,9 +27,9 @@
 #include <map>
 #include <string>
 
-class ConfigUtility : public Singleton<ConfigUtility> {
+class ConfigUtility: public Singleton<ConfigUtility> {
 public:
-	void Load(std::string fname, int argc = 0, char* argv[] = nullptr);
+	void Load(std::string fname, bool skipMissingFile = false, int argc = 0, char* argv[] = nullptr);
 
 	//convert to a type
 	std::string& String(std::string);
@@ -47,10 +47,7 @@ private:
 
 	friend Singleton<ConfigUtility>;
 
-	ConfigUtility() = default;
-	~ConfigUtility() = default;
-
-	table_t Read(std::string fname);
+	table_t Read(std::string fname, bool skipMissingFile);
 
 	table_t configMap;
 };

server/server_logic.cpp

@@ -43,7 +43,7 @@ void ServerApplication::Init(int argc, char* argv[]) {
 	std::cout << "Beginning " << argv[0] << std::endl;
 
 	//load the config settings
-	config.Load("rsc/config.cfg", argc, argv);
+	config.Load("rsc/config.cfg", false, argc, argv);
 
 	//-------------------------
 	//Initialize the APIs