Compare commits

..

2 Commits

Author SHA1 Message Date
Kayne Ruse 3c790f51c7 Bump 2023-06-27 04:26:58 +10:00
Kayne Ruse 44e19154ab Fixed a nasty async race condition 2023-06-27 04:25:52 +10:00
7 changed files with 12 additions and 14 deletions
+1 -1
View File
@@ -1,6 +1,6 @@
{ {
"name": "auth-server", "name": "auth-server",
"version": "1.7.10", "version": "1.7.11",
"description": "An API centric auth server. Uses Sequelize and mariaDB by default.", "description": "An API centric auth server. Uses Sequelize and mariaDB by default.",
"main": "server/server.js", "main": "server/server.js",
"scripts": { "scripts": {
+1 -1
View File
@@ -49,7 +49,7 @@ const route = async (req, res) => {
} }
//generate the JWTs //generate the JWTs
const { accessToken, refreshToken } = tokenGenerateRefresh(account.index, account.email, account.username, account.type, account.admin, account.mod); const { accessToken, refreshToken } = await tokenGenerateRefresh(account.index, account.email, account.username, account.type, account.admin, account.mod);
//set the cookie //set the cookie
res.cookie('refreshToken', refreshToken, { path: '/', httpOnly: true, secure: true, sameSite: 'none', maxAge: 60 * 60 * 24 * 30 * 1000 }); //30 days res.cookie('refreshToken', refreshToken, { path: '/', httpOnly: true, secure: true, sameSite: 'none', maxAge: 60 * 60 * 24 * 30 * 1000 }); //30 days
+1 -3
View File
@@ -1,10 +1,8 @@
const jwt = require('jsonwebtoken');
const tokenRefresh = require('../utilities/token-refresh'); const tokenRefresh = require('../utilities/token-refresh');
//auth/token //auth/token
module.exports = async (req, res) => { module.exports = async (req, res) => {
return tokenRefresh(req.cookies.refreshToken || '', (err, accessToken, refreshToken) => { return await tokenRefresh(req.cookies.refreshToken || '', (err, accessToken, refreshToken) => {
if (err) { if (err) {
return res.status(err).end(); return res.status(err).end();
} }
+2 -2
View File
@@ -1,7 +1,7 @@
const { tokens } = require('../database/models'); const { tokens } = require('../database/models');
module.exports = (refreshToken) => { module.exports = async (refreshToken) => {
tokens.destroy({ await tokens.destroy({
where: { where: {
token: refreshToken || '' token: refreshToken || ''
} }
+2 -2
View File
@@ -2,7 +2,7 @@ const jwt = require('jsonwebtoken');
const { tokens } = require('../database/models'); const { tokens } = require('../database/models');
//generates a JWT token based on the given arguments //generates a JWT token based on the given arguments
module.exports = (index, email, username, type, admin, mod) => { module.exports = async (index, email, username, type, admin, mod) => {
const content = { const content = {
index, index,
email, email,
@@ -16,7 +16,7 @@ module.exports = (index, email, username, type, admin, mod) => {
const accessToken = jwt.sign(content, process.env.SECRET_ACCESS, { expiresIn: '10m', issuer: 'auth' }); const accessToken = jwt.sign(content, process.env.SECRET_ACCESS, { expiresIn: '10m', issuer: 'auth' });
const refreshToken = jwt.sign(content, process.env.SECRET_REFRESH, { expiresIn: '30d', issuer: 'auth' }); const refreshToken = jwt.sign(content, process.env.SECRET_REFRESH, { expiresIn: '30d', issuer: 'auth' });
tokens.create({ token: refreshToken, email: email }); await tokens.create({ token: refreshToken, email: email });
return { accessToken, refreshToken }; return { accessToken, refreshToken };
}; };
+4 -4
View File
@@ -19,15 +19,15 @@ module.exports = async (oldRefreshToken, callback) => {
return callback(403); return callback(403);
} }
jwt.verify(oldRefreshToken, process.env.SECRET_REFRESH, (err, user) => { jwt.verify(oldRefreshToken, process.env.SECRET_REFRESH, async (err, user) => {
if (err) { if (err) {
return callback(403); return callback(403);
} }
const { accessToken, refreshToken } = generate(user.index, user.email, user.username, user.type, user.admin, user.mod); await destroy(oldRefreshToken);
destroy(oldRefreshToken); const { accessToken, refreshToken } = await generate(user.index, user.email, user.username, user.type, user.admin, user.mod);
return callback(null, accessToken, refreshToken); return await callback(null, accessToken, refreshToken);
}); });
}; };
+1 -1
View File
@@ -31,7 +31,7 @@ const TokenProvider = props => {
let bearer = accessToken; let bearer = accessToken;
//if expired (10 minutes, normally) //if expired (10 minutes, normally)
const expired = new Date(decode(accessToken).exp + 600) < Date.now(); const expired = new Date(decode(accessToken).exp * 1000) < Date.now();
if (expired) { if (expired) {
//BUGFIX: if logging out, just skip over the refresh token //BUGFIX: if logging out, just skip over the refresh token