Added privilege modification to the API

Dockerfile

@@ -1,3 +1,4 @@
+
 FROM node:15
 WORKDIR "/app"
 COPY package*.json ./

README.md

@@ -77,4 +77,13 @@ Content-Type: application/json
 	"password": "helloworld"
 }
 
+//DOCS: Sets the privilege of the specified user; usable only by admins
+DELETE /auth/deletion
+Authorization: Bearer accessToken
+Content-Type: application/json
+
+{
+	"username": "example",
+	"privilege: "administrator"
+}
 ```

configure-script.js

@@ -140,7 +140,7 @@ CMD ["sleep 10 && npm start"]
 	const sqlfile = `
 CREATE DATABASE IF NOT EXISTS ${appName};
 CREATE USER IF NOT EXISTS '${appDBUser}'@'%' IDENTIFIED BY '${appDBPass}';
-GRANT ALL PRIVILEGES ON ${appName}.* TO '${appDBUser}'@'%';	
+GRANT ALL PRIVILEGES ON ${appName}.* TO '${appDBUser}'@'%';
 `;
 
 	fs.writeFileSync('docker-compose.yml', ymlfile);

server/auth/account-privilege.js

@@ -0,0 +1,25 @@
+const { accounts } = require('../database/models');
+
+//auth/account/privilege
+const route = async (req, res) => {
+	//check the user's privilege
+	if (req.user.privilege != 'administrator') {
+		return res.status(401).send('Only admins can change privilege');
+	}
+
+	const updated = await accounts.update({
+		privilege: req.body.privilege
+	}, {
+		where: {
+			username: req.body.username
+		}
+	});
+
+	if (updated < 1) {
+		return res.status(403).send(`Unknown account`);
+	}
+
+	return res.status(200).end();
+};
+
+module.exports = route;

server/auth/account.js

@@ -9,12 +9,12 @@ const route = async (req, res) => {
 	});
 
 	if (!account) {
-		res.status(401).send('Unknown account');
+		return res.status(401).send('Unknown account');
 	}
 
 	//respond with the private-facing data
-	res.status(200).json({
-		contact: await account.contact
+	return res.status(200).json({
+		contact: account.contact
 	});
 };
 

server/auth/deletion.js

@@ -17,7 +17,7 @@ const route = async (req, res) => {
 
 	//compare the user's password
 	const compare = utils.promisify(bcrypt.compare);
-	const match = await compare(req.body.password, account.hash);
+	const match = await compare(req.body.password || '', account.hash);
 
 	if (!match) {
 		return res.status(401).send('incorrect password');

server/auth/index.js

@@ -2,7 +2,7 @@ const express = require('express');
 const router = express.Router();
 
 //middleware
-const authToken = require('../utilities/token-auth');
+const tokenAuth = require('../utilities/token-auth');
 
 //signup -> validate -> login all without a token
 router.post('/signup', require('./signup'));
@@ -13,7 +13,7 @@ router.post('/login', require('./login'));
 router.post('/token', require('./token'));
 
 //middleware
-router.use(authToken);
+router.use(tokenAuth);
 
 //basic account management (needs a token)
 router.delete('/logout', require('./logout'));
@@ -21,4 +21,6 @@ router.get('/account', require('./account'));
 router.patch('/update', require('./update'));
 router.delete('/deletion', require('./deletion'));
 
+router.patch('/account/privilege', require('./account-privilege'));
+
 module.exports = router;

server/database/index.js

@@ -4,7 +4,7 @@ const sequelize = new Sequelize(process.env.DB_DATABASE, process.env.DB_USERNAME
 	host: process.env.DB_HOSTNAME,
 	dialect: 'mariadb',
 	timezone: process.env.DB_TIMEZONE,
-	logging: false
+	logging: process.env.DB_LOGGING ? console.log : false
 });
 
 sequelize.sync();

server/utilities/token-auth.js

@@ -6,16 +6,16 @@ module.exports = (req, res, next) => {
 	const token = authHeader?.split (' ')[1]; //'Bearer token'
 
 	if (!token) {
-		return res.status(401).end();
+		return res.status(401).send('No token found');
 	}
 
-	jwt.verify(token, process.env.SECRET_ACCESS, (err, user) => {
+	return jwt.verify(token, process.env.SECRET_ACCESS, (err, user) => {
 		if (err) {
-			return res.status(403).end();
+			return res.status(403).send(err);
 		}
 
 		req.user = user;
 
-		next();
+		return next();
 	});
 };