krgamestudios/Toy
1
0
Fork 0
mirror of https://github.com/krgamestudios/Toy.git synced 2026-04-15 14:54:07 +10:00
Code Issues Packages Projects Releases Wiki Activity

Patched a potential leak

Browse Source
This commit is contained in:
Kayne Ruse
2022-08-22 21:23:24 +01:00
parent 08e2adab50
commit ce2073832b
2 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
source/literal_dictionary.c
View File

@@ -8,20 +8,23 @@
//util functions //util functions
static void setEntryValues(_entry* entry, Literal key, Literal value) { static void setEntryValues(_entry* entry, Literal key, Literal value) {
//free the original string and overwrite it //free the original string/identifier and overwrite it
if (IS_STRING(entry->key)) { if (IS_STRING(entry->key) || IS_IDENTIFIER(entry->key)) {
freeLiteral(entry->key); freeLiteral(entry->key);
} }
//take ownership of the copied string //take ownership of the copied string
if (IS_STRING(key)) { if (IS_STRING(key)) {
char* buffer = ALLOCATE(char, STRLEN(key) + 1); entry->key = TO_STRING_LITERAL( copyString(AS_STRING(key), STRLEN(key)) );
strncpy(buffer, AS_STRING(key), STRLEN(key)); }
buffer[STRLEN(key)] = '\0';
entry->key = TO_STRING_LITERAL(buffer); //buffer becomes a part of the key literal //OR take ownership of the copied identifier
else if (IS_IDENTIFIER(key)) {
entry->key = TO_IDENTIFIER_LITERAL( copyString(AS_IDENTIFIER(key), STRLEN_I(key)) );
} }
else { else {
freeLiteral(entry->key); //for types
entry->key = key; entry->key = key;
} }

2
source/node.c
View File

@@ -79,8 +79,6 @@ void freeNode(Node* node) {
freeLiteral(node->increment.identifier); freeLiteral(node->increment.identifier);
break; break;
} }
FREE(Node, node);
} }
void emitNodeLiteral(Node** nodeHandle, Literal literal) { void emitNodeLiteral(Node** nodeHandle, Literal literal) {