From c2197d5e71d4bd47013fb50587499394fafe0106 Mon Sep 17 00:00:00 2001
From: Kayne Ruse <kayneruse@gmail.com>
Date: Mon, 21 Mar 2016 20:02:49 +1100
Subject: [PATCH] Removed some empty methods

---
 server/server_application.cpp | 52 +----------------------------------
 server/server_application.hpp | 19 +++++++------
 2 files changed, 12 insertions(+), 59 deletions(-)

diff --git a/server/server_application.cpp b/server/server_application.cpp
index 65c159c..3512005 100644
--- a/server/server_application.cpp
+++ b/server/server_application.cpp
@@ -283,22 +283,6 @@ void ServerApplication::HandlePacket(SerialPacket* const argPacket) {
 		case SerialPacketType::QUERY_CHARACTER_EXISTS:
 			hQueryCharacterExists(static_cast<CharacterPacket*>(argPacket));
 		break;
-		case SerialPacketType::QUERY_CHARACTER_STATS:
-			hQueryCharacterStats(static_cast<CharacterPacket*>(argPacket));
-		break;
-		case SerialPacketType::QUERY_CHARACTER_LOCATION:
-			hQueryCharacterLocation(static_cast<CharacterPacket*>(argPacket));
-		break;
-
-		case SerialPacketType::QUERY_MONSTER_EXISTS:
-			hQueryMonsterExists(static_cast<MonsterPacket*>(argPacket));
-		break;
-		case SerialPacketType::QUERY_MONSTER_STATS:
-			hQueryMonsterStats(static_cast<MonsterPacket*>(argPacket));
-		break;
-		case SerialPacketType::QUERY_MONSTER_LOCATION:
-			hQueryMonsterLocation(static_cast<MonsterPacket*>(argPacket));
-		break;
 
 		//character management
 		case SerialPacketType::CHARACTER_CREATE:
@@ -318,12 +302,6 @@ void ServerApplication::HandlePacket(SerialPacket* const argPacket) {
 		case SerialPacketType::CHARACTER_MOVEMENT:
 			hCharacterMovement(static_cast<CharacterPacket*>(argPacket));
 		break;
-		case SerialPacketType::CHARACTER_ATTACK:
-			hCharacterAttack(static_cast<CharacterPacket*>(argPacket));
-		break;
-		case SerialPacketType::CHARACTER_DAMAGE:
-			hCharacterDamage(static_cast<CharacterPacket*>(argPacket));
-		break;
 
 		//chat
 		case SerialPacketType::TEXT_BROADCAST:
@@ -608,26 +586,6 @@ void ServerApplication::hQueryCharacterExists(CharacterPacket* const argPacket)
 	}
 }
 
-void ServerApplication::hQueryCharacterStats(CharacterPacket* const argPacket) {
-	//TODO: (9) ServerApplication::hQueryCharacterStats()
-}
-
-void ServerApplication::hQueryCharacterLocation(CharacterPacket* const argPacket) {
-	//TODO: (9) ServerApplication::hQueryCharacterLocation()
-}
-
-void ServerApplication::hQueryMonsterExists(MonsterPacket* const argPacket) {
-	//TODO: (9) ServerApplication::hQueryMonsterExists()
-}
-
-void ServerApplication::hQueryMonsterStats(MonsterPacket* const argPacket) {
-	//TODO: (9) ServerApplication::hQueryMonsterStats()
-}
-
-void ServerApplication::hQueryMonsterLocation(MonsterPacket* const argPacket) {
-	//TODO: (9) ServerApplication::hQueryMonsterLocation()
-}
-
 //-------------------------
 //Character Management
 //-------------------------
@@ -704,7 +662,7 @@ void ServerApplication::hCharacterDelete(CharacterPacket* const argPacket) {
 	newPacket.characterIndex = characterIndex;
 	pumpPacketProximity(static_cast<SerialPacket*>(&newPacket), characterData->GetRoomIndex());
 
-	//delete the character
+	//delete the character from the database
 	characterMgr.Delete(characterIndex);
 }
 
@@ -837,14 +795,6 @@ void ServerApplication::hCharacterMovement(CharacterPacket* const argPacket) {
 	}
 }
 
-void ServerApplication::hCharacterAttack(CharacterPacket* const argPacket) {
-	//TODO: (9) ServerApplication::hCharacterAttack()
-}
-
-void ServerApplication::hCharacterDamage(CharacterPacket* const argPacket) {
-	//TODO: (9) ServerApplication::hCharacterDamage()
-}
-
 //-------------------------
 //chat
 //-------------------------
diff --git a/server/server_application.hpp b/server/server_application.hpp
index 516cf3d..1b7ef5a 100644
--- a/server/server_application.hpp
+++ b/server/server_application.hpp
@@ -49,7 +49,10 @@
 #include <map>
 #include <string>
 
-//The main application class
+//DOCS: The main application class
+//DOCS: Please note that this is NOT a god class. Instead, it acts as the central relay for all managers.
+//DOCS: It's also the only class that prints to the screen, and it handles a number of error cases.
+
 class ServerApplication: public Singleton<ServerApplication> {
 public:
 	//public methods
@@ -86,11 +89,11 @@ private:
 	//data management
 	void hRegionRequest(RegionPacket* const);
 	void hQueryCharacterExists(CharacterPacket* const);
-	void hQueryCharacterStats(CharacterPacket* const);
-	void hQueryCharacterLocation(CharacterPacket* const);
-	void hQueryMonsterExists(MonsterPacket* const);
-	void hQueryMonsterStats(MonsterPacket* const);
-	void hQueryMonsterLocation(MonsterPacket* const);
+//	void hQueryCharacterStats(CharacterPacket* const);
+//	void hQueryCharacterLocation(CharacterPacket* const);
+//	void hQueryMonsterExists(MonsterPacket* const);
+//	void hQueryMonsterStats(MonsterPacket* const);
+//	void hQueryMonsterLocation(MonsterPacket* const);
 
 	//character management
 	void hCharacterCreate(CharacterPacket* const);
@@ -100,8 +103,8 @@ private:
 
 	//character movement
 	void hCharacterMovement(CharacterPacket* const);
-	void hCharacterAttack(CharacterPacket* const);
-	void hCharacterDamage(CharacterPacket* const);
+//	void hCharacterAttack(CharacterPacket* const);
+//	void hCharacterDamage(CharacterPacket* const);
 
 	//chat
 	void hTextBroadcast(TextPacket* const);