From c010c0da0affa85cf160e46bef7f05452e787c8e Mon Sep 17 00:00:00 2001 From: Kayne Ruse Date: Sun, 28 Sep 2014 20:22:11 +1000 Subject: [PATCH] comment tweaks to bug tags --- rsc/scripts/setup_server.lua | 2 +- server/server_logic.cpp | 2 +- server/server_methods.cpp | 6 ++---- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/rsc/scripts/setup_server.lua b/rsc/scripts/setup_server.lua index 6396596..ab851c1 100644 --- a/rsc/scripts/setup_server.lua +++ b/rsc/scripts/setup_server.lua @@ -34,7 +34,7 @@ function islandGenerator(region) end --Get some regions ---BUG: The server fails without at least one room +--BUG: #35 The server fails without at least one room --TODO: Create rooms with names? newRoom = RoomManager.CreateRoom() pager = Room.GetPager(newRoom) diff --git a/server/server_logic.cpp b/server/server_logic.cpp index 48fd153..51ed785 100644 --- a/server/server_logic.cpp +++ b/server/server_logic.cpp @@ -146,7 +146,7 @@ void ServerApplication::Proc() { HandlePacket(packetBuffer); } //update the internals - //BUG: #30 Update the internals i.e. player positions + //... //TODO: This could be checked only every few seconds //Check connections diff --git a/server/server_methods.cpp b/server/server_methods.cpp index 2cc3b31..bf77776 100644 --- a/server/server_methods.cpp +++ b/server/server_methods.cpp @@ -170,9 +170,6 @@ void ServerApplication::HandleRegionRequest(RegionPacket* const argPacket) { //------------------------- void ServerApplication::HandleCharacterNew(CharacterPacket* const argPacket) { - //BUG: #27 Characters can be created with an invalid account index - //TODO: Make sure that a character's owner's account is loaded before continuing - //NOTE: misnomer, try to load the character first int characterIndex = characterMgr.LoadCharacter(argPacket->accountIndex, argPacket->handle, argPacket->avatar); @@ -285,6 +282,7 @@ void ServerApplication::HandleSynchronize(ClientPacket* const argPacket) { void ServerApplication::CleanupLostConnection(int clientIndex) { //NOTE: This assumes each player has only one account and character at a time + //TODO: handle multiple characters (bots, etc.) //find the account int accountIndex = -1; @@ -304,7 +302,7 @@ void ServerApplication::CleanupLostConnection(int clientIndex) { } } - //send a dissconnection message just in case + //send a disconnection message just in case ClientPacket newPacket; newPacket.type = SerialPacketType::DISCONNECT; network.SendTo(clientMap[clientIndex].GetAddress(), &newPacket);